From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuxuan Shui Subject: [PATCH 2/2] fsck.c: Rewrite fsck_commit() to use skip_prefix() Date: Thu, 13 Mar 2014 02:18:24 +0800 Message-ID: <1394648304-19159-3-git-send-email-yshuiv7@gmail.com> References: <1394648304-19159-1-git-send-email-yshuiv7@gmail.com> Cc: Yuxuan Shui To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Wed Mar 12 19:19:41 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WNnki-0002OI-VX for gcvg-git-2@plane.gmane.org; Wed, 12 Mar 2014 19:19:41 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755460AbaCLSTg (ORCPT ); Wed, 12 Mar 2014 14:19:36 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:56709 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755267AbaCLSTc (ORCPT ); Wed, 12 Mar 2014 14:19:32 -0400 Received: by mail-pa0-f50.google.com with SMTP id kq14so1466442pab.9 for ; Wed, 12 Mar 2014 11:19:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Mi5kPE/ke27xlk/NRN4PDxi6yqL3PkCcWd+LQY5v24U=; b=m4TCq9G9m4E5QyWhnlHSxwxkZnZg8BE8PnBIEh5r8IOatDC7EOFgwWf/nOx18ga297 Hxv/8IARwpXkyShXY0GfKJhAKVinBScjnwlOXS0CPgK59AFOK1oCjTUf3coIYwD4pmlD IEJ/BDlrmt1xD4bEtUFTGheQK2uoOS1KTwZ0vybJRA21WSnBOUnHAWy59SxmxX+y4nsQ nLee/Ns44TwTERzlzj8OzwrwY7Qsq5Zq5zRRQ6CMkXHIUy9hUKKXPUV+nZCQrREfU2SX FRfD138+vISjht/0/adUHIxIpIjYDlDPsR0PqqdDArGmSrnsZbJWHFhmI1Bi80lHOU9j jnoA== X-Received: by 10.67.24.1 with SMTP id ie1mr6740064pad.133.1394648372148; Wed, 12 Mar 2014 11:19:32 -0700 (PDT) Received: from localhost.localdomain ([123.151.32.162]) by mx.google.com with ESMTPSA id pi1sm24592117pac.14.2014.03.12.11.19.20 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 12 Mar 2014 11:19:31 -0700 (PDT) X-Mailer: git-send-email 1.9.0 In-Reply-To: <1394648304-19159-1-git-send-email-yshuiv7@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The purpose of skip_prefix() is much clearer than memcmp(). Also skip_prefix() takes one less argument and its return value makes more sense. --- fsck.c | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/fsck.c b/fsck.c index 1789c34..7e6b829 100644 --- a/fsck.c +++ b/fsck.c @@ -281,7 +281,7 @@ static int fsck_ident(const char **ident, struct object *obj, fsck_error error_f static int fsck_commit(struct commit *commit, fsck_error error_func) { - char *buffer = commit->buffer; + const char *buffer = commit->buffer, *tmp; unsigned char tree_sha1[20], sha1[20]; struct commit_graft *graft; int parents = 0; @@ -290,15 +290,17 @@ static int fsck_commit(struct commit *commit, fsck_error error_func) if (commit->date == ULONG_MAX) return error_func(&commit->object, FSCK_ERROR, "invalid author/committer line"); - if (memcmp(buffer, "tree ", 5)) + buffer = skip_prefix(buffer, "tree "); + if (buffer == NULL) return error_func(&commit->object, FSCK_ERROR, "invalid format - expected 'tree' line"); - if (get_sha1_hex(buffer+5, tree_sha1) || buffer[45] != '\n') + if (get_sha1_hex(buffer, tree_sha1) || buffer[40] != '\n') return error_func(&commit->object, FSCK_ERROR, "invalid 'tree' line format - bad sha1"); - buffer += 46; - while (!memcmp(buffer, "parent ", 7)) { - if (get_sha1_hex(buffer+7, sha1) || buffer[47] != '\n') + buffer += 41; + while ((tmp = skip_prefix(buffer, "parent "))) { + buffer = tmp; + if (get_sha1_hex(buffer, sha1) || buffer[40] != '\n') return error_func(&commit->object, FSCK_ERROR, "invalid 'parent' line format - bad sha1"); - buffer += 48; + buffer += 41; parents++; } graft = lookup_commit_graft(commit->object.sha1); @@ -322,15 +324,15 @@ static int fsck_commit(struct commit *commit, fsck_error error_func) if (p || parents) return error_func(&commit->object, FSCK_ERROR, "parent objects missing"); } - if (memcmp(buffer, "author ", 7)) + buffer = skip_prefix(buffer, "author "); + if (buffer == NULL) return error_func(&commit->object, FSCK_ERROR, "invalid format - expected 'author' line"); - buffer += 7; err = fsck_ident(&buffer, &commit->object, error_func); if (err) return err; - if (memcmp(buffer, "committer ", strlen("committer "))) + buffer = skip_prefix(buffer, "committer "); + if (buffer == NULL) return error_func(&commit->object, FSCK_ERROR, "invalid format - expected 'committer' line"); - buffer += strlen("committer "); err = fsck_ident(&buffer, &commit->object, error_func); if (err) return err; -- 1.9.0