git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: git@vger.kernel.org
Cc: Felipe Contreras <felipe.contreras@gmail.com>
Subject: [PATCH v2 5/5] remote-helpers: add exec-path links
Date: Sat, 12 Oct 2013 02:04:21 -0500	[thread overview]
Message-ID: <1381561465-20147-2-git-send-email-felipe.contreras@gmail.com> (raw)
In-Reply-To: <1381561465-20147-1-git-send-email-felipe.contreras@gmail.com>

This way we don't have to modify the PATH ourselves and it's easier to
test without 'make'.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 contrib/remote-helpers/Makefile | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/contrib/remote-helpers/Makefile b/contrib/remote-helpers/Makefile
index 8799c77..2e14b65 100644
--- a/contrib/remote-helpers/Makefile
+++ b/contrib/remote-helpers/Makefile
@@ -1,15 +1,15 @@
 TESTS := $(wildcard test-*.t)
 SCRIPTS := $(wildcard git-remote-*.py)
+LINKS := $(addprefix ../../,$(patsubst %.py,%,$(SCRIPTS)))
 
 export T := $(addprefix $(CURDIR)/,$(TESTS))
 export MAKE := $(MAKE) -e
-export PATH := $(CURDIR):$(PATH)
 export TEST_LINT := test-lint-executable test-lint-shell-syntax
 export TEST_DIRECTORY := $(CURDIR)/../../t
 
 export SCRIPT_PYTHON := $(addprefix $(CURDIR)/,$(SCRIPTS))
 
-all: $(SCRIPTS)
+all: $(LINKS)
 	$(MAKE) -C ../.. build-python-script
 
 install:
@@ -17,10 +17,14 @@ install:
 
 clean:
 	$(MAKE) -C ../.. clean-python-script
+	$(RM) $(LINKS)
 
 test: all
 	$(MAKE) -C ../../t $@
 
+$(LINKS):
+	ln -sf contrib/remote-helpers/$(notdir $@) ../..
+
 $(TESTS): all
 	$(MAKE) -C ../../t $(CURDIR)/$@
 
-- 
1.8.4-fc

  reply	other threads:[~2013-10-12  7:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-12  7:04 [PATCH v2 0/5] remote-helpers: test reorganization Felipe Contreras
2013-10-12  7:04 ` Felipe Contreras [this message]
2013-10-12  7:04 ` [PATCH v2 4/5] remote-helpers: allow direct test execution Felipe Contreras
2013-10-12  7:04 ` [PATCH v2 3/5] remote-helpers: rename tests Felipe Contreras
2013-10-12  7:04 ` [PATCH v2 2/5] build: fix installation of scripts Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1381561465-20147-2-git-send-email-felipe.contreras@gmail.com \
    --to=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).