git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Stefan Beller <stefanbeller@googlemail.com>
To: git@vger.kernel.org, gitster@pobox.com, sunshine@sunshineco.com
Cc: Stefan Beller <stefanbeller@googlemail.com>
Subject: [PATCHv3 0/9] Removing deprecated parsing macros
Date: Sat,  3 Aug 2013 13:51:17 +0200	[thread overview]
Message-ID: <1375530686-2309-1-git-send-email-stefanbeller@googlemail.com> (raw)

Suggested changes by Eric Sunshine included.

Within the builtin/ folder all occurrences of OPT_BOOLEAN have been removed.
Now we only need to review the usage of it in parse-options as used in
OPT__VERBOSE, OPT__QUIET, OPT__DRY_RUN and OPT__FORCE.
Most likely we could just use OPT_SET_INT there and then OPT_BOOLEAN is 
gone.

The patch 1 and 2 are not intended to change any semantics,
but were the most work, because of the checking for each place not
changing the semantics.

Patch 3 introduces -q the shortform of --quiet for log and format-patch 

Patch 4,5 are unspectacular, just improving readability.

Patch 6 is indeed the only occurence, where I needed to use OPT_COUNTUP
for OPT_BOOLEAN. Personally I'd change it there as well, but it's plumbing.

Patch 7 makes git config a little more flexible (allowing --global 
multiple times).

Patch 8 is a change in the plumbing layer, what I'd call a bugfix,
not urgent, but still.

Patch 9 introduces the new OPT_CMDMODE to revert. Junio suggested to 
change the OPT_CMDMODE a little and use the short parameter as the value
assigned to the command variable. This patch shows, why it might not be a
good idea, as the options there do not have short parameters.


Stefan Beller (9):
  Remove deprecated OPTION_BOOLEAN for parsing arguments
  Replace deprecated OPT_BOOLEAN by OPT_BOOL
  log, format-patch: parsing uses OPT__QUIET
  checkout: remove superfluous local variable
  branch, commit, name-rev: ease up boolean conditions
  hash-object: Replace stdin parsing OPT_BOOLEAN by OPT_COUNTUP
  config parsing options: allow one flag multiple times
  checkout-index: Fix negations of even numbers of -n
  revert: use the OPT_CMDMODE for parsing, reducing code

 Documentation/git-format-patch.txt |  1 +
 builtin/apply.c                    | 24 +++++++--------
 builtin/bisect--helper.c           |  8 ++---
 builtin/blame.c                    |  8 ++---
 builtin/branch.c                   | 13 ++++----
 builtin/check-attr.c               |  8 ++---
 builtin/check-ignore.c             | 12 ++++----
 builtin/checkout-index.c           |  8 ++---
 builtin/checkout.c                 | 27 ++++++++---------
 builtin/clean.c                    |  6 ++--
 builtin/clone.c                    | 23 +++++++-------
 builtin/commit.c                   | 48 ++++++++++++++---------------
 builtin/config.c                   |  8 ++---
 builtin/describe.c                 | 20 ++++++------
 builtin/fast-export.c              | 10 +++---
 builtin/fetch.c                    | 24 +++++++--------
 builtin/fsck.c                     | 16 +++++-----
 builtin/gc.c                       |  4 +--
 builtin/grep.c                     | 38 +++++++++++------------
 builtin/hash-object.c              |  8 ++---
 builtin/log.c                      | 17 +++++------
 builtin/ls-files.c                 | 24 +++++++--------
 builtin/ls-tree.c                  |  6 ++--
 builtin/merge-base.c               | 10 +++---
 builtin/merge-file.c               |  2 +-
 builtin/merge.c                    | 12 ++++----
 builtin/mv.c                       |  2 +-
 builtin/name-rev.c                 | 14 ++++-----
 builtin/notes.c                    | 12 ++++----
 builtin/push.c                     |  6 ++--
 builtin/remote.c                   | 28 ++++++++---------
 builtin/replace.c                  |  6 ++--
 builtin/reset.c                    |  2 +-
 builtin/rev-parse.c                |  4 +--
 builtin/revert.c                   | 62 +++++++++-----------------------------
 builtin/rm.c                       |  6 ++--
 builtin/shortlog.c                 | 12 ++++----
 builtin/show-branch.c              | 28 ++++++++---------
 builtin/show-ref.c                 | 15 +++++----
 builtin/tag.c                      |  4 +--
 builtin/update-ref.c               |  4 +--
 parse-options.h                    |  5 ++-
 42 files changed, 278 insertions(+), 317 deletions(-)

-- 
1.8.4.rc0.16.g7fca822.dirty

             reply	other threads:[~2013-08-03 11:51 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-03 11:51 Stefan Beller [this message]
2013-08-03 11:51 ` [PATCHv3 1/9] Remove deprecated OPTION_BOOLEAN for parsing arguments Stefan Beller
2013-08-03 11:51 ` [PATCHv3 2/9] Replace deprecated OPT_BOOLEAN by OPT_BOOL Stefan Beller
2013-08-03 11:51 ` [PATCHv3 3/9] log, format-patch: parsing uses OPT__QUIET Stefan Beller
2013-08-03 11:51 ` [PATCHv3 4/9] checkout: remove superfluous local variable Stefan Beller
2013-08-03 11:51 ` [PATCHv3 5/9] branch, commit, name-rev: ease up boolean conditions Stefan Beller
2013-08-03 11:51 ` [PATCHv3 6/9] hash-object: Replace stdin parsing OPT_BOOLEAN by OPT_COUNTUP Stefan Beller
2013-08-05 18:50   ` Junio C Hamano
2013-08-03 11:51 ` [PATCHv3 7/9] config parsing options: allow one flag multiple times Stefan Beller
2013-08-05 18:52   ` Junio C Hamano
2013-08-03 11:51 ` [PATCHv3 8/9] checkout-index: Fix negations of even numbers of -n Stefan Beller
2013-08-03 11:51 ` [PATCHv3 9/9] revert: use the OPT_CMDMODE for parsing, reducing code Stefan Beller
2013-08-03 11:55 ` [PATCHv3 0/9] Removing deprecated parsing macros Stefan Beller
2013-08-06  6:39 ` Junio C Hamano
2013-08-06 13:02   ` Stefan Beller
2013-08-06 13:07     ` [PATCH] branch, commit, name-rev: ease up boolean conditions Stefan Beller
2013-08-06 18:46       ` Eric Sunshine
2013-08-06 20:18         ` Stefan Beller
2013-08-06 20:18           ` Stefan Beller
2013-08-06 17:20     ` [PATCHv3 0/9] Removing deprecated parsing macros Junio C Hamano
2013-08-06 23:31       ` [PATCH 0/4] Update built-in parseopt macros Junio C Hamano
2013-08-06 23:31         ` [PATCH 1/4] OPT__QUIET(): switch from count-up to true bool Junio C Hamano
2013-08-06 23:31         ` [PATCH 2/4] OPT__VERBOSE(): clarify its expected use by using OPT_COUNTUP Junio C Hamano
2013-08-06 23:31         ` [PATCH 3/4] OPT__DRY_RUN(): use OPT_BOOL, not OPT_BOOLEAN Junio C Hamano
2013-08-06 23:31         ` [RFH/PATCH 4/4] OPT__FORCE(): clarify its expected use by using OPT_COUNTUP Junio C Hamano
2013-08-07  7:33           ` Stefan Beller
2013-08-07 15:28             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1375530686-2309-1-git-send-email-stefanbeller@googlemail.com \
    --to=stefanbeller@googlemail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).