From: Stefan Beller <stefanbeller@googlemail.com>
To: git@vger.kernel.org
Cc: Stefan Beller <stefanbeller@googlemail.com>
Subject: [PATCH 4/4] name-rev: ease up condition
Date: Mon, 29 Jul 2013 21:49:58 +0200 [thread overview]
Message-ID: <1375127398-31904-5-git-send-email-stefanbeller@googlemail.com> (raw)
In-Reply-To: <1375127398-31904-1-git-send-email-stefanbeller@googlemail.com>
Now that the internal variables 'all' and 'transform_stdin' are read in
by OPT_BOOL, which makes sure to have the variable being 0 or 1 after
reading, we do not need the double negation to map any other value to
1.
Signed-off-by: Stefan Beller <stefanbeller@googlemail.com>
---
builtin/name-rev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/name-rev.c b/builtin/name-rev.c
index a908a34..20fcf8c 100644
--- a/builtin/name-rev.c
+++ b/builtin/name-rev.c
@@ -331,7 +331,7 @@ int cmd_name_rev(int argc, const char **argv, const char *prefix)
git_config(git_default_config, NULL);
argc = parse_options(argc, argv, prefix, opts, name_rev_usage, 0);
- if (!!all + !!transform_stdin + !!argc > 1) {
+ if (all + transform_stdin + !!argc > 1) {
error("Specify either a list, or --all, not both!");
usage_with_options(name_rev_usage, opts);
}
--
1.8.4.rc0.1.g8f6a3e5
prev parent reply other threads:[~2013-07-29 19:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 19:49 [PATCH 0/4] Removing deprecated parsing macros Stefan Beller
2013-07-29 19:49 ` [PATCH 1/4] Replace deprecated OPT_BOOLEAN by OPT_BOOL Stefan Beller
2013-07-29 19:49 ` [PATCH 2/4] log, format-patch: accept short parameter 'q' for quiet Stefan Beller
2013-07-29 22:05 ` René Scharfe
2013-07-31 10:35 ` Stefan Beller
2013-07-29 19:49 ` [PATCH 3/4] checkout: remove superfluous local variable Stefan Beller
2013-07-29 19:49 ` Stefan Beller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375127398-31904-5-git-send-email-stefanbeller@googlemail.com \
--to=stefanbeller@googlemail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).