From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joern Hees Subject: [PATCH v3] remotes-hg: bugfix for fetching non local remotes Date: Thu, 25 Jul 2013 02:42:57 +0200 Message-ID: <1374712977-3215-1-git-send-email-dev@joernhees.de> Cc: git@vger.kernel.org, apelisse@gmail.com, felipe.contreras@gmail.com, Joern Hees To: gitster@pobox.com X-From: git-owner@vger.kernel.org Thu Jul 25 02:43:41 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1V29ee-0006Ti-Ix for gcvg-git-2@plane.gmane.org; Thu, 25 Jul 2013 02:43:40 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754247Ab3GYAnh (ORCPT ); Wed, 24 Jul 2013 20:43:37 -0400 Received: from srv1.joernhees.de ([81.20.133.80]:43604 "EHLO mail.joernhees.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753255Ab3GYAng (ORCPT ); Wed, 24 Jul 2013 20:43:36 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.joernhees.de (Postfix) with ESMTP id A0E3AE8C2AA; Thu, 25 Jul 2013 02:43:35 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at joernhees.de Received: from mail.joernhees.de ([127.0.0.1]) by localhost (srv1.joernhees.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id p9f0-Z90ILkp; Thu, 25 Jul 2013 02:43:34 +0200 (CEST) Received: from localhost.localdomain (95-88-55-57-dynip.superkabel.de [95.88.55.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.joernhees.de (Postfix) with ESMTPSA id 0D52BE8C28D; Thu, 25 Jul 2013 02:43:34 +0200 (CEST) X-Mailer: git-send-email 1.8.3.4 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: 6796d49 introduced a bug by making shared_path == ".git/hg' which will most likely exist already, causing a new remote never to be cloned and subsequently causing hg.share to fail with error msg: "mercurial.error.RepoError: repository .git/hg not found" Changing shared_path to ".git/hg/.shared" will solve this problem and create a shared local mercurial repository for non local remotes. The initial dot circumvents a name clash problem should a remote be called "shared". Signed-off-by: Joern Hees Mentored-by: Antoine Pelisse Thanks-to: Junio C Hamano --- contrib/remote-helpers/git-remote-hg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg index 0194c67..f4e9d1c 100755 --- a/contrib/remote-helpers/git-remote-hg +++ b/contrib/remote-helpers/git-remote-hg @@ -390,7 +390,7 @@ def get_repo(url, alias): if not os.path.exists(dirname): os.makedirs(dirname) else: - shared_path = os.path.join(gitdir, 'hg') + shared_path = os.path.join(gitdir, 'hg', '.shared') if not os.path.exists(shared_path): try: hg.clone(myui, {}, url, shared_path, update=False, pull=True) -- 1.8.3.4