From: Dennis Kaarsemaker <dennis@kaarsemaker.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] remote: make prune work for mixed mirror/non-mirror repos
Date: Fri, 21 Jun 2013 01:38:30 +0200 [thread overview]
Message-ID: <1371771510.17896.61.camel@localhost> (raw)
In-Reply-To: <7vhagspdfx.fsf@alter.siamese.dyndns.org>
On do, 2013-06-20 at 16:30 -0700, Junio C Hamano wrote:
> Maybe there is a miscommunication.
>
> $ git ls-remote git://github.com/git/git.git | grep remotes/
>
> shows that that repository, your origin, has refs/remotes/github/html
Yes, I misunderstood you and see the problem now. Thanks for being
patient with me :)
> > Yeah, I'm starting to think this is not such a good idea. How about plan
> > B: issuing a warning when adding a remote with a refspec that also
> > matches another remote's refspec?
>
> Surely that will make things safer.
>
> > Or plan C: add a per-remote pruneIgnore setting that in this case I
> > could set to refs/tags/* refs/remotes/* as I know it's correct? Could
> > even be combined with plan B.
>
> As I already said "I dunno", I am not sure if it is worth the effort
> to support overlapping RHSs of fetch refspecs, so between B and C, I
> would vote for B.
I'm halfway through cooking up a patch for B, as I agree that it will
make things safer.
I'd really like to have C as well though, would you accept a patch that
implements it?
--
Dennis Kaarsemaker
www.kaarsemaker.net
next prev parent reply other threads:[~2013-06-20 23:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 21:23 [BUG?] remote prune origin interacts badly with clone --mirror and multiple remotes Dennis Kaarsemaker
2013-06-20 22:11 ` [PATCH] remote: make prune work for mixed mirror/non-mirror repos Dennis Kaarsemaker
2013-06-20 22:46 ` Junio C Hamano
2013-06-20 23:07 ` Dennis Kaarsemaker
2013-06-20 23:30 ` Junio C Hamano
2013-06-20 23:38 ` Dennis Kaarsemaker [this message]
2013-06-20 23:44 ` Junio C Hamano
2013-06-20 23:08 ` Jeff King
2013-06-20 23:29 ` Dennis Kaarsemaker
2013-06-20 23:36 ` Junio C Hamano
2013-06-20 22:53 ` [PATCH v2] " Dennis Kaarsemaker
2013-06-21 10:04 ` [PATCH 0/3] Handling overlapping refspecs slightly smarter Dennis Kaarsemaker
2013-06-21 10:04 ` [PATCH 1/3] remote: Add warnings about mixin --mirror and other remotes Dennis Kaarsemaker
2013-06-21 18:42 ` Junio C Hamano
2013-06-23 13:35 ` Dennis Kaarsemaker
2013-06-23 21:22 ` Junio C Hamano
2013-06-23 21:43 ` Dennis Kaarsemaker
2013-06-23 22:33 ` Junio C Hamano
2013-06-26 21:10 ` Dennis Kaarsemaker
2013-06-26 23:42 ` Junio C Hamano
2013-06-21 10:04 ` [PATCH 2/3] remote: Add test for prune and mixed --mirror and normal remotes Dennis Kaarsemaker
2013-06-21 10:04 ` [PATCH 3/3] remote: don't prune when detecting overlapping refspecs Dennis Kaarsemaker
2013-06-21 18:53 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371771510.17896.61.camel@localhost \
--to=dennis@kaarsemaker.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).