git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Git List <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH v3 2/7] wt-status: remove unused field in grab_1st_switch_cbdata
Date: Wed, 19 Jun 2013 13:34:44 +0530	[thread overview]
Message-ID: <1371629089-27008-3-git-send-email-artagnon@gmail.com> (raw)
In-Reply-To: <1371629089-27008-1-git-send-email-artagnon@gmail.com>

The struct grab_1st_switch_cbdata has the field "found", which is
set in grab_1st_switch() when a match is found.  This information is
redundant and unused by any code.  The return value of the function
serves to communicate this information anyway.

Remove the field.

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 wt-status.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/wt-status.c b/wt-status.c
index bf84a86..2511270 100644
--- a/wt-status.c
+++ b/wt-status.c
@@ -1035,7 +1035,6 @@ got_nothing:
 }
 
 struct grab_1st_switch_cbdata {
-	int found;
 	struct strbuf buf;
 	unsigned char nsha1[20];
 };
@@ -1059,7 +1058,6 @@ static int grab_1st_switch(unsigned char *osha1, unsigned char *nsha1,
 	for (end = target; *end && *end != '\n'; end++)
 		;
 	strbuf_add(&cb->buf, target, end - target);
-	cb->found = 1;
 	return 1;
 }
 
-- 
1.8.3.1.449.g41b32a4.dirty

  parent reply	other threads:[~2013-06-19  8:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-19  8:04 [PATCH v3 0/7] Re-roll rr/rebase-checkout-reflog Ramkumar Ramachandra
2013-06-19  8:04 ` [PATCH v3 1/7] t/t7512-status-help: test "HEAD detached from" Ramkumar Ramachandra
2013-06-19  8:04 ` Ramkumar Ramachandra [this message]
2013-06-19  8:04 ` [PATCH v3 3/7] t/t2012-checkout-last: test "checkout -" after a rebase Ramkumar Ramachandra
2013-06-19  9:10   ` Johannes Sixt
2013-06-19  9:41     ` Ramkumar Ramachandra
2013-06-19  8:04 ` [PATCH v3 4/7] status: do not depend on rebase reflog messages Ramkumar Ramachandra
2013-06-19  8:04 ` [PATCH v3 5/7] checkout: respect GIT_REFLOG_ACTION Ramkumar Ramachandra
2013-06-19  8:04 ` [PATCH v3 6/7] rebase: write better reflog messages Ramkumar Ramachandra
2013-06-24  3:26   ` Junio C Hamano
2013-06-24  7:07     ` Ramkumar Ramachandra
2013-06-24  7:57       ` Junio C Hamano
2013-06-24  8:12         ` Ramkumar Ramachandra
2013-06-19  8:04 ` [PATCH v3 7/7] rebase -i: " Ramkumar Ramachandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371629089-27008-3-git-send-email-artagnon@gmail.com \
    --to=artagnon@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).