From: "Célestin Matte" <celestin.matte@ensimag.fr>
To: git@vger.kernel.org
Cc: benoit.person@ensimag.fr, matthieu.moy@grenoble-inp.fr,
"Célestin Matte" <celestin.matte@ensimag.fr>
Subject: [PATCH v4 04/31] git-remote-mediawiki: Always end a subroutine with a return
Date: Wed, 12 Jun 2013 00:17:55 +0200 [thread overview]
Message-ID: <1370989102-24942-5-git-send-email-celestin.matte@ensimag.fr> (raw)
In-Reply-To: <1370989102-24942-1-git-send-email-celestin.matte@ensimag.fr>
Follow Subroutines::RequireFinalReturn
Signed-off-by: Célestin Matte <celestin.matte@ensimag.fr>
Signed-off-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
---
contrib/mw-to-git/git-remote-mediawiki.perl | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl b/contrib/mw-to-git/git-remote-mediawiki.perl
index 5e198e0..f19b276 100755
--- a/contrib/mw-to-git/git-remote-mediawiki.perl
+++ b/contrib/mw-to-git/git-remote-mediawiki.perl
@@ -197,12 +197,14 @@ sub mw_connect_maybe {
exit 1;
}
}
+ return;
}
## Functions for listing pages on the remote wiki
sub get_mw_tracked_pages {
my $pages = shift;
get_mw_page_list(\@tracked_pages, $pages);
+ return;
}
sub get_mw_page_list {
@@ -218,6 +220,7 @@ sub get_mw_page_list {
get_mw_first_pages(\@slice, $pages);
@some_pages = @some_pages[51..$#some_pages];
}
+ return;
}
sub get_mw_tracked_categories {
@@ -240,6 +243,7 @@ sub get_mw_tracked_categories {
$pages->{$page->{title}} = $page;
}
}
+ return;
}
sub get_mw_all_pages {
@@ -259,6 +263,7 @@ sub get_mw_all_pages {
foreach my $page (@{$mw_pages}) {
$pages->{$page->{title}} = $page;
}
+ return;
}
# queries the wiki for a set of pages. Meant to be used within a loop
@@ -289,6 +294,7 @@ sub get_mw_first_pages {
$pages->{$page->{title}} = $page;
}
}
+ return;
}
# Get the list of pages to be fetched according to configuration.
@@ -357,6 +363,7 @@ sub get_all_mediafiles {
foreach my $page (@{$mw_pages}) {
$pages->{$page->{title}} = $page;
}
+ return;
}
sub get_linked_mediafiles {
@@ -403,6 +410,7 @@ sub get_linked_mediafiles {
@titles = @titles[($batch+1)..$#titles];
}
+ return;
}
sub get_mw_mediafile_for_page_revision {
@@ -578,6 +586,7 @@ sub mediawiki_smudge_filename {
sub literal_data {
my ($content) = @_;
print STDOUT "data ", bytes::length($content), "\n", $content;
+ return;
}
sub literal_data_raw {
@@ -588,6 +597,7 @@ sub literal_data_raw {
binmode STDOUT, ":raw";
print STDOUT "data ", bytes::length($content), "\n", $content;
binmode STDOUT, ":encoding(UTF-8)";
+ return;
}
sub mw_capabilities {
@@ -599,6 +609,7 @@ sub mw_capabilities {
print STDOUT "list\n";
print STDOUT "push\n";
print STDOUT "\n";
+ return;
}
sub mw_list {
@@ -607,11 +618,13 @@ sub mw_list {
print STDOUT "? refs/heads/master\n";
print STDOUT "\@refs/heads/master HEAD\n";
print STDOUT "\n";
+ return;
}
sub mw_option {
print STDERR "remote-helper command 'option $_[0]' not yet implemented\n";
print STDOUT "unsupported\n";
+ return;
}
sub fetch_mw_revisions_for_page {
@@ -733,6 +746,7 @@ sub import_file_revision {
print STDOUT "N inline :$n\n";
literal_data("mediawiki_revision: " . $commit{mw_revision});
print STDOUT "\n\n";
+ return;
}
# parse a sequence of
@@ -753,6 +767,7 @@ sub get_more_refs {
die("Invalid command in a '$cmd' batch: ". $_);
}
}
+ return;
}
sub mw_import {
@@ -762,6 +777,7 @@ sub mw_import {
mw_import_ref($ref);
}
print STDOUT "done\n";
+ return;
}
sub mw_import_ref {
@@ -805,6 +821,7 @@ sub mw_import_ref {
# thrown saying that HEAD is referring to unknown object 0000000000000000000
# and the clone fails.
}
+ return;
}
sub mw_import_ref_by_pages {
@@ -1111,6 +1128,7 @@ sub mw_push {
print STDERR " git pull --rebase\n";
print STDERR "\n";
}
+ return;
}
sub mw_push_revision {
--
1.7.9.5
next prev parent reply other threads:[~2013-06-11 22:20 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 22:17 [PATCH v4 00/31] git-remote-mediawiki: Follow perlcritic's recommandations Célestin Matte
2013-06-11 22:17 ` [PATCH v4 01/31] git-remote-mediawiki: Make a regexp clearer Célestin Matte
2013-06-11 22:17 ` [PATCH v4 02/31] git-remote-mediawiki: Move "use warnings;" before any instruction Célestin Matte
2013-06-11 22:17 ` [PATCH v4 03/31] git-remote-mediawiki: Replace :utf8 by :encoding(UTF-8) Célestin Matte
2013-06-11 22:17 ` Célestin Matte [this message]
2013-06-11 22:17 ` [PATCH v4 05/31] git-remote-mediawiki: Move a variable declaration at the top of the code Célestin Matte
2013-06-11 22:17 ` [PATCH v4 06/31] git-remote-mediawiki: Change syntax of map calls Célestin Matte
2013-06-11 22:17 ` [PATCH v4 07/31] git-remote-mediawiki: Rewrite unclear line of instructions Célestin Matte
2013-06-11 22:17 ` [PATCH v4 08/31] git-remote-mediawiki: Remove useless regexp modifier (m) Célestin Matte
2013-06-11 22:18 ` [PATCH v4 09/31] git-remote-mediawiki: Change the behaviour of a split Célestin Matte
2013-06-12 1:54 ` Eric Sunshine
2013-06-11 22:18 ` [PATCH v4 10/31] git-remote-mediawiki: Change separator of some regexps Célestin Matte
2013-06-11 22:18 ` [PATCH v4 11/31] git-remote-mediawiki: Change style in a regexp Célestin Matte
2013-06-11 22:18 ` [PATCH v4 12/31] " Célestin Matte
2013-06-11 22:18 ` [PATCH v4 13/31] git-remote-mediawiki: Add newline in the end of die() error messages Célestin Matte
2013-06-11 22:18 ` [PATCH v4 14/31] git-remote-mediawiki: Change the name of a variable Célestin Matte
2013-06-11 22:18 ` [PATCH v4 15/31] git-remote-mediawiki: Turn double-negated expressions into simple expressions Célestin Matte
2013-06-11 22:18 ` [PATCH v4 16/31] git-remote-mediawiki: Remove unused variable $entry Célestin Matte
2013-06-11 22:18 ` [PATCH v4 17/31] git-remote-mediawiki: Rename a variable ($last) which has the name of a keyword Célestin Matte
2013-06-11 22:18 ` [PATCH v4 18/31] git-remote-mediawiki: Assign a variable as undef and make proper indentation Célestin Matte
2013-06-11 22:18 ` [PATCH v4 19/31] git-remote-mediawiki: Check return value of open Célestin Matte
2013-06-11 22:18 ` [PATCH v4 20/31] git-remote-mediawiki: remove import of unused open2 Célestin Matte
2013-06-11 22:18 ` [PATCH v4 21/31] git-remote-mediawiki: Put long code into a subroutine Célestin Matte
2013-06-11 22:18 ` [PATCH v4 22/31] git-remote-mediawiki: Modify strings for a better coding-style Célestin Matte
2013-06-11 22:18 ` [PATCH v4 23/31] git-remote-mediawiki: Brace file handles for print for more clarity Célestin Matte
2013-06-11 22:18 ` [PATCH v4 24/31] git-remote-mediawiki: Replace "unless" statements with negated "if" statements Célestin Matte
2013-06-11 22:18 ` [PATCH v4 25/31] git-remote-mediawiki: Don't use quotes for empty strings Célestin Matte
2013-06-11 22:18 ` [PATCH v4 26/31] git-remote-mediawiki: Put non-trivial numeric values in constants Célestin Matte
2013-06-11 22:18 ` [PATCH v4 27/31] git-remote-mediawiki: Fix a typo ("mediwiki" instead of "mediawiki") Célestin Matte
2013-06-11 22:18 ` [PATCH v4 28/31] git-remote-mediawiki: Clearly rewrite double dereference Célestin Matte
2013-06-11 22:18 ` [PATCH v4 29/31] git-remote-mediawiki: Add a .perlcriticrc file Célestin Matte
2013-06-12 2:02 ` Eric Sunshine
2013-06-11 22:18 ` [PATCH v4 30/31] git-remote-mediawiki: add a perlcritic rule in Makefile Célestin Matte
2013-06-11 22:18 ` [PATCH v4 31/31] git-remote-mediawiki: Make error message more precise Célestin Matte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370989102-24942-5-git-send-email-celestin.matte@ensimag.fr \
--to=celestin.matte@ensimag.fr \
--cc=benoit.person@ensimag.fr \
--cc=git@vger.kernel.org \
--cc=matthieu.moy@grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).