From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?C=C3=A9lestin=20Matte?= Subject: [PATCH v4 29/31] git-remote-mediawiki: Add a .perlcriticrc file Date: Wed, 12 Jun 2013 00:18:20 +0200 Message-ID: <1370989102-24942-30-git-send-email-celestin.matte@ensimag.fr> References: <1370989102-24942-1-git-send-email-celestin.matte@ensimag.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: benoit.person@ensimag.fr, matthieu.moy@grenoble-inp.fr, =?UTF-8?q?C=C3=A9lestin=20Matte?= To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Wed Jun 12 00:19:15 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UmWuE-0007GU-Vd for gcvg-git-2@plane.gmane.org; Wed, 12 Jun 2013 00:19:11 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756871Ab3FKWSw convert rfc822-to-quoted-printable (ORCPT ); Tue, 11 Jun 2013 18:18:52 -0400 Received: from mx1.imag.fr ([129.88.30.5]:48177 "EHLO shiva.imag.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756850Ab3FKWSu (ORCPT ); Tue, 11 Jun 2013 18:18:50 -0400 Received: from ensimag.imag.fr (ensimag.imag.fr [195.221.228.12]) by shiva.imag.fr (8.13.8/8.13.8) with ESMTP id r5BMIk59012673 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 12 Jun 2013 00:18:46 +0200 Received: from ensibm.imag.fr (ensibm.imag.fr [195.221.228.8]) by ensimag.imag.fr (8.13.8/8.13.8/ImagV2.1.r_ens) with ESMTP id r5BMImwI024121; Wed, 12 Jun 2013 00:18:48 +0200 Received: from tohwi-K50IE.imag.fr (ensibm [195.221.228.8]) by ensibm.imag.fr (8.13.8/8.13.8/ImagV2.1.sb_ens.pm) with ESMTP id r5BMIb2n018360; Wed, 12 Jun 2013 00:18:48 +0200 X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1370989102-24942-1-git-send-email-celestin.matte@ensimag.fr> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0.1 (shiva.imag.fr [129.88.30.5]); Wed, 12 Jun 2013 00:18:46 +0200 (CEST) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Such a file allows to configure perlcritic. Here, it is used to prevent to remove many unwanted rules and configure= one to remove unwanted warnings. Signed-off-by: C=C3=A9lestin Matte Signed-off-by: Matthieu Moy --- contrib/mw-to-git/.perlcriticrc | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 contrib/mw-to-git/.perlcriticrc diff --git a/contrib/mw-to-git/.perlcriticrc b/contrib/mw-to-git/.perlc= riticrc new file mode 100644 index 0000000..a1f8451 --- /dev/null +++ b/contrib/mw-to-git/.perlcriticrc @@ -0,0 +1,28 @@ +# These 3 rules demand to add the s, m and x flag to *every* regexp. T= his is +# overkill and would be harmful for readability. +[-RegularExpressions::RequireExtendedFormatting] +[-RegularExpressions::RequireDotMatchAnything] +[-RegularExpressions::RequireLineBoundaryMatching] + +# This rules says that builtin functions should not be called with par= enthesis +# e.g.: (taken from CPAN's documentation) +# open($handle, '>', $filename); #not ok +# open $handle, '>', $filename; #ok +# Applying such a rule would mean modifying a huge number of lines for= a +# question of style. +[-CodeLayout::ProhibitParensWithBuiltins] + +# This rule states that each system call should have its return value = checked +# The problem is that it includes the print call. Checking every print= call's +# return value would be harmful to the code readabilty. +# This configuration keeps all default function but print. +[InputOutput::RequireCheckedSyscalls] +functions =3D open say close + +# This rules demands to add a dependancy for the Readonly module. This= is not +# wished. +[-ValuesAndExpressions::ProhibitConstantPragma] + +# This rule is not really useful (rather a question of style) and prod= uces many +# warnings among the code. +[-ValuesAndExpressions::ProhibitNoisyQuotes] --=20 1.7.9.5