From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?C=C3=A9lestin=20Matte?= Subject: [PATCH v4 09/31] git-remote-mediawiki: Change the behaviour of a split Date: Wed, 12 Jun 2013 00:18:00 +0200 Message-ID: <1370989102-24942-10-git-send-email-celestin.matte@ensimag.fr> References: <1370989102-24942-1-git-send-email-celestin.matte@ensimag.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: benoit.person@ensimag.fr, matthieu.moy@grenoble-inp.fr, =?UTF-8?q?C=C3=A9lestin=20Matte?= To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Wed Jun 12 00:21:00 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UmWvz-00006V-Qm for gcvg-git-2@plane.gmane.org; Wed, 12 Jun 2013 00:21:00 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757564Ab3FKWUt convert rfc822-to-quoted-printable (ORCPT ); Tue, 11 Jun 2013 18:20:49 -0400 Received: from mx1.imag.fr ([129.88.30.5]:48132 "EHLO shiva.imag.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756710Ab3FKWSm (ORCPT ); Tue, 11 Jun 2013 18:18:42 -0400 Received: from ensimag.imag.fr (ensimag.imag.fr [195.221.228.12]) by shiva.imag.fr (8.13.8/8.13.8) with ESMTP id r5BMIc3N012526 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 12 Jun 2013 00:18:38 +0200 Received: from ensibm.imag.fr (ensibm.imag.fr [195.221.228.8]) by ensimag.imag.fr (8.13.8/8.13.8/ImagV2.1.r_ens) with ESMTP id r5BMIeeh024016; Wed, 12 Jun 2013 00:18:40 +0200 Received: from tohwi-K50IE.imag.fr (ensibm [195.221.228.8]) by ensibm.imag.fr (8.13.8/8.13.8/ImagV2.1.sb_ens.pm) with ESMTP id r5BMIb2T018360; Wed, 12 Jun 2013 00:18:40 +0200 X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1370989102-24942-1-git-send-email-celestin.matte@ensimag.fr> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0.1 (shiva.imag.fr [129.88.30.5]); Wed, 12 Jun 2013 00:18:38 +0200 (CEST) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: A "split ' '" is turned into a "split / /", which changes its behaviour= : the old method matched a run of whitespaces (/\s*/), while the new one will= match a single whitespace, which is what we want here. Indeed, in other context= s, changing split(' ') to split(/ /) could potentially be a regression, ho= wever, here, when parsing the output of "rev-list --parents", whose output SHA= -1's are each separated by a single space, splitting on a single space is perfec= tly correct. Signed-off-by: C=C3=A9lestin Matte Signed-off-by: Matthieu Moy --- contrib/mw-to-git/git-remote-mediawiki.perl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl b/contrib/mw-t= o-git/git-remote-mediawiki.perl index 7ce640f..7537305 100755 --- a/contrib/mw-to-git/git-remote-mediawiki.perl +++ b/contrib/mw-to-git/git-remote-mediawiki.perl @@ -1168,7 +1168,7 @@ sub mw_push_revision { my %local_ancestry; foreach my $line (@local_ancestry) { if (my ($child, $parents) =3D $line =3D~ /^-?([a-f0-9]+) ([a-f0-9 ]= +)/) { - foreach my $parent (split(' ', $parents)) { + foreach my $parent (split(/ /, $parents)) { $local_ancestry{$parent} =3D $child; } } elsif (!$line =3D~ /^([a-f0-9]+)/) { --=20 1.7.9.5