From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?C=C3=A9lestin=20Matte?= Subject: [PATCH 09/18] Check return value of open and remove import of unused open2 Date: Thu, 6 Jun 2013 21:34:14 +0200 Message-ID: <1370547263-13558-10-git-send-email-celestin.matte@ensimag.fr> References: <1370547263-13558-1-git-send-email-celestin.matte@ensimag.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: benoit.person@ensimag.fr, matthieu.moy@grenoble-inp.fr, =?UTF-8?q?C=C3=A9lestin=20Matte?= To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Thu Jun 06 21:35:26 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ukfxx-00015n-G4 for gcvg-git-2@plane.gmane.org; Thu, 06 Jun 2013 21:35:21 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753719Ab3FFTfR convert rfc822-to-quoted-printable (ORCPT ); Thu, 6 Jun 2013 15:35:17 -0400 Received: from mx1.imag.fr ([129.88.30.5]:44288 "EHLO shiva.imag.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753561Ab3FFTfM (ORCPT ); Thu, 6 Jun 2013 15:35:12 -0400 Received: from ensimag.imag.fr (ensimag.imag.fr [195.221.228.12]) by shiva.imag.fr (8.13.8/8.13.8) with ESMTP id r56JYsfR005285 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 6 Jun 2013 21:34:54 +0200 Received: from ensibm.imag.fr (ensibm.imag.fr [195.221.228.8]) by ensimag.imag.fr (8.13.8/8.13.8/ImagV2.1.r_ens) with ESMTP id r56JYuwH021418; Thu, 6 Jun 2013 21:34:56 +0200 Received: from tohwi-K50IE.imag.fr (ensibm [195.221.228.8]) by ensibm.imag.fr (8.13.8/8.13.8/ImagV2.1.sb_ens.pm) with ESMTP id r56JYTow023108; Thu, 6 Jun 2013 21:34:56 +0200 X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1370547263-13558-1-git-send-email-celestin.matte@ensimag.fr> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0.1 (shiva.imag.fr [129.88.30.5]); Thu, 06 Jun 2013 21:34:54 +0200 (CEST) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-MailScanner-ID: r56JYsfR005285 X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: celestin.matte@ensimag.fr MailScanner-NULL-Check: 1371152095.24461@5qUPz+XmiIJRmvsBuTrfwA Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Signed-off-by: C=C3=A9lestin Matte Signed-off-by: Matthieu Moy --- contrib/mw-to-git/git-remote-mediawiki.perl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl b/contrib/mw-t= o-git/git-remote-mediawiki.perl index ae6dd2e..1c34ada 100755 --- a/contrib/mw-to-git/git-remote-mediawiki.perl +++ b/contrib/mw-to-git/git-remote-mediawiki.perl @@ -22,7 +22,6 @@ binmode STDERR, ":encoding(UTF-8)"; binmode STDOUT, ":encoding(UTF-8)"; =20 use URI::Escape; -use IPC::Open2; use Readonly; =20 # Mediawiki filenames can contain forward slashes. This variable decid= es by which pattern they should be replaced @@ -338,7 +337,8 @@ sub get_mw_pages { sub run_git { my $args =3D shift; my $encoding =3D (shift || "encoding(UTF-8)"); - open(my $git, "-|:$encoding", "git " . $args); + open(my $git, "-|:$encoding", "git " . $args) + or die "Unable to open: $!\n"; my $res =3D do {=20 local $/ =3D undef; <$git> --=20 1.7.9.5