git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH v2 2/6] send-email: fix suppress-cc=self on cccmd
Date: Thu, 30 May 2013 10:11:15 +0300	[thread overview]
Message-ID: <1369897638-27299-3-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1369897638-27299-1-git-send-email-mst@redhat.com>

When cccmd is used, old-style suppress-from filter
is applied by the newer suppress-cc=self isn't.
Fix this up.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 git-send-email.perl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/git-send-email.perl b/git-send-email.perl
index bd13cc8..a138615 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -1462,7 +1462,7 @@ sub recipients_cmd {
 		$address =~ s/^\s*//g;
 		$address =~ s/\s*$//g;
 		$address = sanitize_address($address);
-		next if ($address eq $sanitized_sender and $suppress_from);
+		next if ($address eq $sender and $suppress_cc{'self'});
 		push @addresses, $address;
 		printf("($prefix) Adding %s: %s from: '%s'\n",
 		       $what, $address, $cmd) unless $quiet;
-- 
MST

  parent reply	other threads:[~2013-05-30  7:10 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-30  7:11 [PATCH v2 0/6] git send-email suppress-cc=self fixes Michael S. Tsirkin
2013-05-30  7:11 ` [PATCH v2 1/6] t/send-email.sh: add test for suppress-cc=self Michael S. Tsirkin
2013-06-03 16:19   ` Junio C Hamano
2013-05-30  7:11 ` Michael S. Tsirkin [this message]
2013-06-03 15:58   ` [PATCH v2 2/6] send-email: fix suppress-cc=self on cccmd Junio C Hamano
2013-06-03 16:15     ` Michael S. Tsirkin
2013-06-03 18:04       ` Junio C Hamano
2013-06-03 19:58         ` Michael S. Tsirkin
2013-06-03 21:55           ` Junio C Hamano
2013-05-30  7:11 ` [PATCH v2 3/6] t/send-email: test " Michael S. Tsirkin
2013-05-30  7:11 ` [PATCH v2 4/6] send-email: make --suppress-cc=self sanitize input Michael S. Tsirkin
2013-06-03 16:17   ` Junio C Hamano
2013-06-03 16:32     ` Michael S. Tsirkin
2013-06-03 18:02       ` Junio C Hamano
2013-05-30  7:11 ` [PATCH v2 5/6] t/send-email: add test with quoted sender Michael S. Tsirkin
2013-05-30  7:11 ` [PATCH v2 6/6] t/send-email: test suppress-cc=self with non-ascii Michael S. Tsirkin
2013-06-03 16:18 ` [PATCH v2 0/6] git send-email suppress-cc=self fixes Junio C Hamano
2013-06-03 16:36   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369897638-27299-3-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).