From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>
Cc: Johan Herland <johan@herland.net>,
Thomas Rast <trast@inf.ethz.ch>,
git@vger.kernel.org, Michael Haggerty <mhagger@alum.mit.edu>
Subject: [PATCH v2 00/25] Remove assumptions about each_ref_fn arg lifetimes
Date: Sat, 25 May 2013 11:07:59 +0200 [thread overview]
Message-ID: <1369472904-12875-1-git-send-email-mhagger@alum.mit.edu> (raw)
This is version two of the patch series. Aside from addressing
Junio's comments about the first version, it goes significantly
further than v1:
I did a manual audit of the 50 (!) functions that are used as an
each_ref_fn callback to the for_each_ref()-style functions. (I hope I
haven't missed any.) I checked that they do not make the assumption
that the lifetimes of the refname and sha1 arguments extend past the
duration of the callback invocation. There were a number of callers
that got this wrong; I believe I have fixed them all.
I also changed how object_array_entry manages its name field. Like
the RFC in the first version of this patch series, I change
add_object_array_with_mode() to make a copy of the name before storing
it in its field. But (at Peff's suggestion) I also make an
optimization like that of strbuf of not copying the name if it is the
empty string, but rather using a pointer to a static empty string.
After this patch series, the test suite runs without errors under
valgrind even when I change refs.c:do_one_ref() to pass temporary
copies of refname and sha1 to the callback functions then free them
immediately. (Before this patch series, such a test failed in many
places.) But it is still not enough to make Peff's
jk/packed-refs-race series work correctly under the "hyperactive
repository" stress-test in which the packed-refs file is made to
always look stale,
refs.c:get_packed_refs():
- if (refs->packed &&
- !stat_validity_check(&refs->packed_validity, packed_refs_file))
+ if (refs->packed /* &&
+ !stat_validity_check(&refs->packed_validity, packed_refs_file) */)
Michael Haggerty (25):
describe: make own copy of refname
fetch: make own copies of refnames
add_rev_cmdline(): make a copy of the name argument
builtin_diff_tree(): make it obvious that function wants two entries
cmd_diff(): use an object_array for holding trees
cmd_diff(): rename local variable "list" -> "entry"
cmd_diff(): make it obvious which cases are exclusive of each other
revision: split some overly-long lines
object_array: add function object_array_filter()
revision: use object_array_filter() in implementation of gc_boundary()
object_array_remove_duplicates(): rewrite to reduce copying
fsck: don't put a void*-shaped peg in a char*-shaped hole
find_first_merges(): initialize merges variable using initializer
find_first_merges(): remove unnecessary code
object_array_entry: fix memory handling of the name field
do_fetch(): reduce scope of peer_item
do_fetch(): clean up existing_refs before exiting
add_existing(): do not retain a reference to sha1
show_head_ref(): do not shadow name of argument
show_head_ref(): rename first parameter to "refname"
string_list_add_one_ref(): rename first parameter to "refname"
string_list_add_refs_by_glob(): add a comment about memory management
exclude_existing(): set existing_refs.strdup_strings
register_ref(): make a copy of the bad reference SHA-1
refs: document the lifetime of the args passed to each_ref_fn
bisect.c | 5 ++--
builtin/describe.c | 6 +++--
builtin/diff.c | 69 ++++++++++++++++++++++++++---------------------------
builtin/fetch.c | 29 ++++++++++++----------
builtin/fsck.c | 2 +-
builtin/show-ref.c | 2 +-
bundle.c | 2 +-
http-backend.c | 6 ++---
notes.c | 9 ++++---
object.c | 70 ++++++++++++++++++++++++++++++++++++++++++++----------
object.h | 25 +++++++++++++++++--
refs.h | 22 ++++++++++++-----
revision.c | 64 +++++++++++++++++++++++++++++--------------------
revision.h | 32 ++++++++++++++++---------
submodule.c | 6 ++---
15 files changed, 228 insertions(+), 121 deletions(-)
--
1.8.2.3
next reply other threads:[~2013-05-25 9:09 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-25 9:07 Michael Haggerty [this message]
2013-05-25 9:08 ` [PATCH v2 01/25] describe: make own copy of refname Michael Haggerty
2013-05-25 9:08 ` [PATCH v2 02/25] fetch: make own copies of refnames Michael Haggerty
2013-05-25 9:08 ` [PATCH v2 03/25] add_rev_cmdline(): make a copy of the name argument Michael Haggerty
2013-05-25 9:08 ` [PATCH v2 04/25] builtin_diff_tree(): make it obvious that function wants two entries Michael Haggerty
2013-05-25 9:08 ` [PATCH v2 05/25] cmd_diff(): use an object_array for holding trees Michael Haggerty
2013-05-25 9:08 ` [PATCH v2 06/25] cmd_diff(): rename local variable "list" -> "entry" Michael Haggerty
2013-05-25 9:08 ` [PATCH v2 07/25] cmd_diff(): make it obvious which cases are exclusive of each other Michael Haggerty
2013-05-25 9:08 ` [PATCH v2 08/25] revision: split some overly-long lines Michael Haggerty
2013-05-25 9:08 ` [PATCH v2 09/25] object_array: add function object_array_filter() Michael Haggerty
2013-05-25 9:08 ` [PATCH v2 10/25] revision: use object_array_filter() in implementation of gc_boundary() Michael Haggerty
2013-05-25 9:08 ` [PATCH v2 11/25] object_array_remove_duplicates(): rewrite to reduce copying Michael Haggerty
2013-05-29 16:18 ` Junio C Hamano
2013-05-30 21:14 ` Michael Haggerty
2013-06-02 21:02 ` Junio C Hamano
2013-05-25 9:08 ` [PATCH v2 12/25] fsck: don't put a void*-shaped peg in a char*-shaped hole Michael Haggerty
2013-05-25 9:08 ` [PATCH v2 13/25] find_first_merges(): initialize merges variable using initializer Michael Haggerty
2013-05-25 9:08 ` [PATCH v2 14/25] find_first_merges(): remove unnecessary code Michael Haggerty
2013-05-25 9:08 ` [PATCH v2 15/25] object_array_entry: fix memory handling of the name field Michael Haggerty
2013-05-29 16:24 ` Junio C Hamano
2013-05-25 9:08 ` [PATCH v2 16/25] do_fetch(): reduce scope of peer_item Michael Haggerty
2013-05-25 9:08 ` [PATCH v2 17/25] do_fetch(): clean up existing_refs before exiting Michael Haggerty
2013-05-25 9:08 ` [PATCH v2 18/25] add_existing(): do not retain a reference to sha1 Michael Haggerty
2013-05-25 9:08 ` [PATCH v2 19/25] show_head_ref(): do not shadow name of argument Michael Haggerty
2013-05-25 9:08 ` [PATCH v2 20/25] show_head_ref(): rename first parameter to "refname" Michael Haggerty
2013-05-25 9:08 ` [PATCH v2 21/25] string_list_add_one_ref(): " Michael Haggerty
2013-05-25 9:08 ` [PATCH v2 22/25] string_list_add_refs_by_glob(): add a comment about memory management Michael Haggerty
2013-05-29 8:21 ` Thomas Rast
2013-05-30 19:29 ` Michael Haggerty
2013-05-30 22:05 ` [PATCH v2 FIXUP 22/25] fixup! " Michael Haggerty
2013-06-03 15:31 ` Junio C Hamano
2013-05-25 9:08 ` [PATCH v2 23/25] exclude_existing(): set existing_refs.strdup_strings Michael Haggerty
2013-05-25 9:08 ` [PATCH v2 24/25] register_ref(): make a copy of the bad reference SHA-1 Michael Haggerty
2013-05-29 16:53 ` Junio C Hamano
2013-05-30 21:51 ` Michael Haggerty
2013-05-30 22:09 ` Philip Oakley
2013-05-25 9:08 ` [PATCH v2 25/25] refs: document the lifetime of the args passed to each_ref_fn Michael Haggerty
2013-05-29 16:54 ` Junio C Hamano
2013-05-29 8:25 ` [PATCH v2 00/25] Remove assumptions about each_ref_fn arg lifetimes Thomas Rast
2013-05-30 19:55 ` Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369472904-12875-1-git-send-email-mhagger@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johan@herland.net \
--cc=peff@peff.net \
--cc=trast@inf.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).