From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Git List <git@vger.kernel.org>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: [PATCH 1/3] for-each-ref: introduce %C(...) for color
Date: Fri, 24 May 2013 19:49:35 +0530 [thread overview]
Message-ID: <1369405177-7855-2-git-send-email-artagnon@gmail.com> (raw)
In-Reply-To: <1369405177-7855-1-git-send-email-artagnon@gmail.com>
Since 'git branch' misses important options like --sort, --count, and
--format that are present in 'git for-each-ref'. Until we are in a
position to fix 'git branch', let us enhance the 'git for-each-ref'
format so it can atleast colorize output.
You can use the following format in for-each-ref:
%C(green)%(refname:short)%C(reset)
To display refs in green. Future patches will attempt to extend the
format even more to get useful output.
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
builtin/for-each-ref.c | 26 ++++++++++++++++++++++----
1 file changed, 22 insertions(+), 4 deletions(-)
diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c
index 7f059c3..1563b25 100644
--- a/builtin/for-each-ref.c
+++ b/builtin/for-each-ref.c
@@ -9,6 +9,7 @@
#include "quote.h"
#include "parse-options.h"
#include "remote.h"
+#include "color.h"
/* Quoting styles */
#define QUOTE_NONE 0
@@ -155,10 +156,13 @@ static const char *find_next(const char *cp)
while (*cp) {
if (*cp == '%') {
/*
+ * %C( is the start of a color;
* %( is the start of an atom;
* %% is a quoted per-cent.
*/
- if (cp[1] == '(')
+ if (cp[1] == 'C' && cp[2] == '(')
+ return cp;
+ else if (cp[1] == '(')
return cp;
else if (cp[1] == '%')
cp++; /* skip over two % */
@@ -180,8 +184,12 @@ static int verify_format(const char *format)
const char *ep = strchr(sp, ')');
if (!ep)
return error("malformed format string %s", sp);
- /* sp points at "%(" and ep points at the closing ")" */
- parse_atom(sp + 2, ep);
+ /*
+ * Ignore color specifications: %C(
+ * sp points at "%(" and ep points at the closing ")"
+ */
+ if (prefixcmp(sp, "%C("))
+ parse_atom(sp + 2, ep);
cp = ep + 1;
}
return 0;
@@ -928,12 +936,22 @@ static void emit(const char *cp, const char *ep)
static void show_ref(struct refinfo *info, const char *format, int quote_style)
{
const char *cp, *sp, *ep;
+ char color[COLOR_MAXLEN];
for (cp = format; *cp && (sp = find_next(cp)); cp = ep + 1) {
ep = strchr(sp, ')');
if (cp < sp)
emit(cp, sp);
- print_value(info, parse_atom(sp + 2, ep), quote_style);
+
+ /* Do we have a color specification? */
+ if (!prefixcmp(sp, "%C("))
+ color_parse_mem(sp + 3,
+ ep - sp - 3,
+ "--format ", color);
+ else {
+ printf("%s", color);
+ print_value(info, parse_atom(sp + 2, ep), quote_style);
+ }
}
if (*cp) {
sp = cp + strlen(cp);
--
1.8.3.rc3.2.g99b8f3f.dirty
next prev parent reply other threads:[~2013-05-24 14:19 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-24 14:19 [PATCH v2 0/3] Towards a useable git-branch Ramkumar Ramachandra
2013-05-24 14:19 ` Ramkumar Ramachandra [this message]
2013-05-24 20:56 ` [PATCH 1/3] for-each-ref: introduce %C(...) for color Antoine Pelisse
2013-05-25 11:50 ` Ramkumar Ramachandra
2013-05-25 12:20 ` John Keeping
2013-05-25 12:54 ` Ramkumar Ramachandra
2013-05-25 12:35 ` Antoine Pelisse
2013-05-24 23:41 ` David Aguilar
2013-05-25 11:51 ` Ramkumar Ramachandra
2013-05-25 6:29 ` Eric Sunshine
2013-05-24 14:19 ` [PATCH 2/3] for-each-ref: introduce %(HEAD) marker Ramkumar Ramachandra
2013-05-24 20:28 ` Philip Oakley
2013-05-24 14:19 ` [PATCH 3/3] for-each-ref: introduce %(upstream:track[short]) Ramkumar Ramachandra
2013-05-24 15:27 ` [PATCH v2 0/3] Towards a useable git-branch Duy Nguyen
2013-05-24 15:58 ` Ramkumar Ramachandra
2013-05-24 17:52 ` Junio C Hamano
2013-05-24 18:01 ` Ramkumar Ramachandra
2013-05-24 18:08 ` Ramkumar Ramachandra
2013-05-24 22:51 ` Duy Nguyen
2013-05-25 6:26 ` Duy Nguyen
2013-05-25 11:35 ` Duy Nguyen
2013-05-25 11:48 ` Ramkumar Ramachandra
2013-05-28 14:01 ` Ramkumar Ramachandra
2013-05-28 14:24 ` Ramkumar Ramachandra
2013-05-30 4:19 ` Duy Nguyen
2013-06-04 12:52 ` Ramkumar Ramachandra
2013-06-04 13:11 ` Duy Nguyen
2013-05-28 14:28 ` Ramkumar Ramachandra
2013-05-29 3:04 ` Duy Nguyen
2013-05-29 21:12 ` Ramkumar Ramachandra
2013-05-29 3:22 ` Duy Nguyen
-- strict thread matches above, loose matches on Subject: below --
2013-09-27 12:10 [PATCH 0/3] Juggling between hot branches Ramkumar Ramachandra
2013-09-27 12:10 ` [PATCH 1/3] for-each-ref: introduce %C(...) for color Ramkumar Ramachandra
2013-09-27 13:16 ` Phil Hord
2013-10-31 9:46 [PATCH (resend) 0/3] Minor f-e-r enhacements Ramkumar Ramachandra
2013-10-31 9:46 ` [PATCH 1/3] for-each-ref: introduce %C(...) for color Ramkumar Ramachandra
2013-10-31 20:50 ` Junio C Hamano
2013-11-01 8:37 ` Ramkumar Ramachandra
2013-11-01 15:05 ` Junio C Hamano
2013-11-02 6:02 ` Ramkumar Ramachandra
2013-11-04 18:17 ` Junio C Hamano
2013-11-07 6:36 ` Ramkumar Ramachandra
2013-11-07 18:02 ` Junio C Hamano
2013-11-08 12:14 ` Ramkumar Ramachandra
2013-11-08 17:30 ` Junio C Hamano
2013-11-12 3:38 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369405177-7855-2-git-send-email-artagnon@gmail.com \
--to=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).