From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?Nguy=E1=BB=85n=20Th=C3=A1i=20Ng=E1=BB=8Dc=20Duy?= Subject: [PATCH 7/9] for-each-ref: prepoplulate all atoms before show_ref() Date: Sun, 19 May 2013 17:27:13 +0700 Message-ID: <1368959235-27777-8-git-send-email-pclouds@gmail.com> References: <1368959235-27777-1-git-send-email-pclouds@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: =?UTF-8?q?Nguy=E1=BB=85n=20Th=C3=A1i=20Ng=E1=BB=8Dc=20Duy?= To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Sun May 19 12:27:12 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ue0pY-0006qt-5u for gcvg-git-2@plane.gmane.org; Sun, 19 May 2013 12:27:08 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754229Ab3ESK0z convert rfc822-to-quoted-printable (ORCPT ); Sun, 19 May 2013 06:26:55 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:52954 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754183Ab3ESK0x (ORCPT ); Sun, 19 May 2013 06:26:53 -0400 Received: by mail-pa0-f52.google.com with SMTP id bg2so4837940pad.39 for ; Sun, 19 May 2013 03:26:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=mkKYXqQs0FcwBLdGEdpjKj0KCNGZ71cDlFWq/uQb/yM=; b=yNm2XfM1QwcDVzrG7yYWn6jxo5FcsVp5qWaCj1ycx4c+xz73eYytPK4h37YJaY/7eD q6Uilx57krfT2kLLSF0I/KGjjvzHfhRoZdxJcNiD8AuATDCy5/AQTiA+NJkX+OhwR6Nd Nc6+Z2Szk2GJ3ajvyumFfLlU9e4ql0q9kWO3LLmOrnf9G1yG85w3UvnNRPqcCmZXxlwO qCHSZf+lL0RXb3H6qGCqD+/L5CgPbQDGby2ky2pAyTRn+SkY+39VilacyL4RoVE6MQgq laSsd6dNbeggvqbN0y71xyFAydiMlh97HVGvl5UAqLrb7ZOO7WoY5rvBLnvjAq45Q0g5 JJzA== X-Received: by 10.68.130.199 with SMTP id og7mr56600138pbb.132.1368959212564; Sun, 19 May 2013 03:26:52 -0700 (PDT) Received: from lanh ([115.73.232.21]) by mx.google.com with ESMTPSA id k2sm20688056pat.7.2013.05.19.03.26.49 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 19 May 2013 03:26:51 -0700 (PDT) Received: by lanh (sSMTP sendmail emulation); Sun, 19 May 2013 17:28:03 +0700 X-Mailer: git-send-email 1.8.2.83.gc99314b In-Reply-To: <1368959235-27777-1-git-send-email-pclouds@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: By the time show_ref() is called, atom values for all refs are ready. This can be taken advantage of later. Signed-off-by: Nguy=E1=BB=85n Th=C3=A1i Ng=E1=BB=8Dc Duy --- builtin/for-each-ref.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c index db5c211..a9d189c 100644 --- a/builtin/for-each-ref.c +++ b/builtin/for-each-ref.c @@ -1010,15 +1010,24 @@ static void show_ref(struct strbuf *sb, struct = refinfo *info, static void show_refs(struct refinfo **refs, int maxcount, const char *format, int quote_style) { - struct strbuf sb =3D STRBUF_INIT; + struct strbuf *sb; int i; =20 + sb =3D xmalloc(sizeof(*sb) * maxcount); for (i =3D 0; i < maxcount; i++) { - strbuf_reset(&sb); - show_ref(&sb, refs[i], format, quote_style); - fputs(sb.buf, stdout); + strbuf_init(sb + i, 256); + if (!refs[i]->value) { + populate_value(refs[i]); + fill_missing_values(refs[i]->value); + } + } + + for (i =3D 0; i < maxcount; i++) { + show_ref(sb + i, refs[i], format, quote_style); + fputs(sb[i].buf, stdout); + strbuf_release(sb + i); } - strbuf_release(&sb); + free(sb); } =20 static struct ref_sort *default_sort(void) --=20 1.8.2.83.gc99314b