From: Pete Wyckoff <pw@padd.com>
To: git@vger.kernel.org
Subject: [PATCH 4/6] git p4 test: display unresolvable host error
Date: Fri, 23 Nov 2012 17:35:37 -0500 [thread overview]
Message-ID: <1353710139-16207-5-git-send-email-pw@padd.com> (raw)
In-Reply-To: <1353710139-16207-1-git-send-email-pw@padd.com>
This test passes already. Make sure p4 diagnostic errors are displayed.
Signed-off-by: Pete Wyckoff <pw@padd.com>
---
t/t9800-git-p4-basic.sh | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/t/t9800-git-p4-basic.sh b/t/t9800-git-p4-basic.sh
index 05797c3..8c59796 100755
--- a/t/t9800-git-p4-basic.sh
+++ b/t/t9800-git-p4-basic.sh
@@ -183,6 +183,18 @@ test_expect_success 'initial import time from top change time' '
)
'
+test_expect_success 'unresolvable host in P4PORT should display error' '
+ test_when_finished cleanup_git &&
+ git p4 clone --dest="$git" //depot &&
+ (
+ cd "$git" &&
+ P4PORT=nosuchhost:65537 &&
+ export P4PORT &&
+ test_expect_code 1 git p4 sync >out 2>err &&
+ grep "connect to nosuchhost" err
+ )
+'
+
test_expect_success 'kill p4d' '
kill_p4d
'
--
1.8.0.276.gd9397fc
next prev parent reply other threads:[~2012-11-23 22:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-23 22:35 [PATCH 0/6] git p4 error handling Pete Wyckoff
2012-11-23 22:35 ` [PATCH 1/6] git p4: catch p4 describe errors Pete Wyckoff
2012-11-23 22:35 ` [PATCH 2/6] git p4: handle servers without move support Pete Wyckoff
2012-11-23 22:35 ` [PATCH 3/6] git p4: catch p4 errors when streaming file contents Pete Wyckoff
2012-11-23 22:35 ` Pete Wyckoff [this message]
2012-11-23 22:35 ` [PATCH 5/6] git p4: fix labelDetails typo in exception Pete Wyckoff
2012-11-23 22:35 ` [PATCH 6/6] git p4: remove unneeded cmd initialization Pete Wyckoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353710139-16207-5-git-send-email-pw@padd.com \
--to=pw@padd.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).