* [PATCH] gitk: Add workaround for system where Shift-F5 mapped to Shift-XF86_Switch_VT_5
@ 2012-10-01 15:16 Andrew Wong
2012-10-01 15:16 ` Andrew Wong
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Wong @ 2012-10-01 15:16 UTC (permalink / raw)
To: git; +Cc: szeder, paulus, Andrew Wong
I was running into the same issue too. It turns out that on some machines
Shift-F5 is mapped to Shift-XF86_Switch_VT_5. My patch includes a workaround.
The same workaround was used for Shift-F4.
Andrew Wong (1):
gitk: Add workaround for system where Shift-F5 mapped to
Shift-XF86_Switch_VT_5
gitk-git/gitk | 1 +
1 file changed, 1 insertion(+)
--
1.7.12.1.382.gb0576a6
^ permalink raw reply [flat|nested] 4+ messages in thread* gitk: can't reload commits with new key binding
@ 2012-09-30 10:19 SZEDER Gábor
2012-10-01 15:26 ` Andrew Wong
0 siblings, 1 reply; 4+ messages in thread
From: SZEDER Gábor @ 2012-09-30 10:19 UTC (permalink / raw)
To: git; +Cc: Felipe Contreras, Paul Mackerras
Hi,
a135f214 (gitk: Avoid Meta1-F5, 2012-04-07) changed the key binding
for reloading commits to shift-F5, but this new key binding doesn't
seem to be working here, because it doesn't call reloadcommits().
Choosing the reload menu item works. Shift-F5 works properly in other
applications.
Any ideas?
Thanks,
Gábor
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: gitk: can't reload commits with new key binding
2012-09-30 10:19 gitk: can't reload commits with new key binding SZEDER Gábor
@ 2012-10-01 15:26 ` Andrew Wong
2012-10-01 15:26 ` [PATCH] gitk: Add workaround for system where Shift-F5 mapped to Shift-XF86_Switch_VT_5 Andrew Wong
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Wong @ 2012-10-01 15:26 UTC (permalink / raw)
To: git; +Cc: szeder, paulus, Andrew Wong
Sorry, my previous "git send-email" screwed up. Resending the email again.
I was running into the same issue too. It turns out that on some machines
Shift-F5 is mapped to Shift-XF86_Switch_VT_5. My patch includes a workaround.
The same workaround was used for Shift-F4.
Andrew Wong (1):
gitk: Add workaround for system where Shift-F5 mapped to
Shift-XF86_Switch_VT_5
gitk-git/gitk | 1 +
1 file changed, 1 insertion(+)
--
1.7.12.1.382.gb0576a6
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] gitk: Add workaround for system where Shift-F5 mapped to Shift-XF86_Switch_VT_5
2012-10-01 15:26 ` Andrew Wong
@ 2012-10-01 15:26 ` Andrew Wong
2012-10-01 17:27 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Wong @ 2012-10-01 15:26 UTC (permalink / raw)
To: git; +Cc: szeder, paulus, Andrew Wong
The same workaround was used for Shift-F4 in:
cea07cf8dc9b3677e0c50433c0d72bce83adbdc7
Signed-off-by: Andrew Wong <andrew.kw.w@gmail.com>
---
gitk-git/gitk | 1 +
1 file changed, 1 insertion(+)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index d93bd99..698b84a 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -2496,6 +2496,7 @@ proc makewindow {} {
bindkey f nextfile
bind . <F5> updatecommits
bind . <Shift-F5> reloadcommits
+ catch { bind . <Shift-Key-XF86_Switch_VT_5> reloadcommits }
bind . <F2> showrefs
bind . <Shift-F4> {newview 0}
catch { bind . <Shift-Key-XF86_Switch_VT_4> {newview 0} }
--
1.7.12.1.382.gb0576a6
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] gitk: Add workaround for system where Shift-F5 mapped to Shift-XF86_Switch_VT_5
2012-10-01 15:26 ` [PATCH] gitk: Add workaround for system where Shift-F5 mapped to Shift-XF86_Switch_VT_5 Andrew Wong
@ 2012-10-01 17:27 ` Junio C Hamano
0 siblings, 0 replies; 4+ messages in thread
From: Junio C Hamano @ 2012-10-01 17:27 UTC (permalink / raw)
To: Andrew Wong; +Cc: git, szeder, paulus
Andrew Wong <andrew.kw.w@gmail.com> writes:
> The same workaround was used for Shift-F4 in:
> cea07cf8dc9b3677e0c50433c0d72bce83adbdc7
>
> Signed-off-by: Andrew Wong <andrew.kw.w@gmail.com>
> ---
> gitk-git/gitk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/gitk-git/gitk b/gitk-git/gitk
> index d93bd99..698b84a 100755
> --- a/gitk-git/gitk
> +++ b/gitk-git/gitk
> @@ -2496,6 +2496,7 @@ proc makewindow {} {
> bindkey f nextfile
> bind . <F5> updatecommits
> bind . <Shift-F5> reloadcommits
> + catch { bind . <Shift-Key-XF86_Switch_VT_5> reloadcommits }
> bind . <F2> showrefs
> bind . <Shift-F4> {newview 0}
> catch { bind . <Shift-Key-XF86_Switch_VT_4> {newview 0} }
Wouldn't it make more sense to have a small helper function to wrap
binding both <Shift-Fn> and <Shift-Key-XF86_Switch_VT_n> to the same
thing and have F4 and F5 binding use that to avoid repetition?
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-10-01 17:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-01 15:16 [PATCH] gitk: Add workaround for system where Shift-F5 mapped to Shift-XF86_Switch_VT_5 Andrew Wong
2012-10-01 15:16 ` Andrew Wong
-- strict thread matches above, loose matches on Subject: below --
2012-09-30 10:19 gitk: can't reload commits with new key binding SZEDER Gábor
2012-10-01 15:26 ` Andrew Wong
2012-10-01 15:26 ` [PATCH] gitk: Add workaround for system where Shift-F5 mapped to Shift-XF86_Switch_VT_5 Andrew Wong
2012-10-01 17:27 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).