From: Lawrence Mitchell <wence@gmx.li>
To: "Rüdiger Sonderfeld" <ruediger@c-plusplus.de>
Cc: jrnieder@gmail.com, git@vger.kernel.org, davidk@lysator.liu.se,
user42@zip.com.au, osv@javad.com
Subject: [PATCH 1/3] git-blame.el: Do not use goto-line in lisp code
Date: Sun, 10 Jun 2012 12:58:02 +0100 [thread overview]
Message-ID: <1339329484-12088-1-git-send-email-wence@gmx.li> (raw)
In-Reply-To: <20120610073803.GA29461@burratino>
From: Rüdiger Sonderfeld <ruediger@c-plusplus.de>
goto-line is a user-level command, instead use the lisp-level
construct recommended in Emacs documentation.
Signed-off-by: Rüdiger Sonderfeld <ruediger@c-plusplus.de>
Signed-off-by: Lawrence Mitchell <wence@gmx.li>
---
contrib/emacs/git-blame.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Here we go, all Rüdiger's changes look sensible, I've split them into bits though
diff --git a/contrib/emacs/git-blame.el b/contrib/emacs/git-blame.el
index 37d797e..5428ff7 100644
--- a/contrib/emacs/git-blame.el
+++ b/contrib/emacs/git-blame.el
@@ -389,7 +389,8 @@ See also function `git-blame-mode'."
(set-buffer git-blame-file)
(let ((inhibit-point-motion-hooks t)
(inhibit-modification-hooks t))
- (goto-line start-line)
+ (goto-char (point-min))
+ (forward-line (1- start-line))
(let* ((start (point))
(end (progn (forward-line num-lines) (point)))
(ovl (make-overlay start end))
--
1.7.10.2.552.gaa3bb87
next prev parent reply other threads:[~2012-06-10 12:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 15:44 [PATCH] git-blame.el: Fix compilation warnings Rüdiger Sonderfeld
2012-01-12 16:26 ` Jonathan Nieder
2012-01-12 17:08 ` Rüdiger Sonderfeld
2012-01-13 23:31 ` Sending patches with KMail (Re: [PATCH] git-blame.el: Fix compilation warnings.) Jonathan Nieder
2012-01-14 0:59 ` Junio C Hamano
2012-01-14 18:31 ` Sending patches with KMail Jonathan Nieder
2012-01-14 18:34 ` Jonathan Nieder
2012-01-15 2:14 ` Junio C Hamano
2012-01-14 19:18 ` Sending patches with KMail (Re: [PATCH] git-blame.el: Fix compilation warnings.) Rüdiger Sonderfeld
2012-06-10 7:38 ` [PATCH] git-blame.el: use mapc instead of mapcar Jonathan Nieder
2012-06-10 11:58 ` Lawrence Mitchell [this message]
2012-06-10 11:58 ` [PATCH 2/3] git-blame.el: Use with-current-buffer where appropriate Lawrence Mitchell
2012-06-10 11:58 ` [PATCH 3/3] git-blame.el: Do not use bare 0 to mean (point-min) Lawrence Mitchell
2012-06-14 5:08 ` [PATCH 1/3] git-blame.el: Do not use goto-line in lisp code Jonathan Nieder
2012-06-14 9:14 ` Lawrence Mitchell
2012-06-14 9:37 ` [PATCH v2 " Lawrence Mitchell
2012-06-14 9:37 ` [PATCH v2 2/3] git-blame.el: Use with-current-buffer where appropriate Lawrence Mitchell
2012-06-14 9:38 ` [PATCH v2 3/3] git-blame.el: Do not use bare 0 to mean (point-min) Lawrence Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339329484-12088-1-git-send-email-wence@gmx.li \
--to=wence@gmx.li \
--cc=davidk@lysator.liu.se \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=osv@javad.com \
--cc=ruediger@c-plusplus.de \
--cc=user42@zip.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).