git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Joe Perches <joe@perches.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, jeffrey.t.kirsher@intel.com
Subject: Re: [PATCH] git-send-email: Add auto-cc to all body signatures
Date: Thu, 08 Dec 2011 12:51:26 -0800	[thread overview]
Message-ID: <1323377486.1762.71.camel@joe2Laptop> (raw)
In-Reply-To: <7v8vmmj1ng.fsf@alter.siamese.dyndns.org>

On Thu, 2011-12-08 at 11:37 -0800, Junio C Hamano wrote:
> Joe Perches <joe@perches.com> writes:
> > Many types of signatures are used by various projects.
> > The most common type is formatted:
> > 	"[some_signature_type]-by: First Last <email@domain.tld>"
> > e.g:
> > 	"Reported-by: First Last <email@domain.tld>" (no quotes are used)
> This is just a phrasing issue, but I am a bit reluctant about the name
> "signature".

I've called all these markings signatures.
Maybe email-address-tags or another name could be used.
I'm not bothered one way or another by any chosen name.

> Does your change do the right thing on such an address-less entry?  The
> answer to this question must start with the definition of "the right thing
> to do is X", of course.

All addresses go through "extract_valid_address".
Invalid addresses are not used.

  reply	other threads:[~2011-12-08 20:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-29  1:34 [PATCH] git-send-email: Add auto-cc to all body signatures Joe Perches
2011-07-29  1:43 ` Jeff Kirsher
2011-12-08  2:58   ` Joe Perches
2011-12-08 19:37     ` Junio C Hamano
2011-12-08 20:51       ` Joe Perches [this message]
2015-12-02 10:04         ` Rasmus Villemoes
2015-12-02 17:00           ` [PATCH V3] " Joe Perches
2015-12-02 17:58             ` Junio C Hamano
2015-12-02 18:20               ` Joe Perches
2015-12-02 18:28               ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1323377486.1762.71.camel@joe2Laptop \
    --to=joe@perches.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jeffrey.t.kirsher@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).