From: Ben Walton <bwalton@artsci.utoronto.ca>
To: Eric Wong <normalperson@yhbt.net>
Cc: Jonathan Nieder <jrnieder@gmail.com>, git <git@vger.kernel.org>
Subject: Re: [PATCH] Escape file:// URL's to meet subversion SVN::Ra requirements
Date: Thu, 03 Nov 2011 22:11:49 -0400 [thread overview]
Message-ID: <1320372215-sup-8341@pinkfloyd.chass.utoronto.ca> (raw)
In-Reply-To: <20111102220941.GA3925@dcvr.yhbt.net>
Excerpts from Eric Wong's message of Wed Nov 02 18:09:41 -0400 2011:
Hi Eric,
> I don't have much time to help you fix it, but I got numerous errors
> on SVN 1.6.x (svn 1.6.12). Can you make sure things continue to
> work on 1.6 and earlier, also?
Yes, it's a bit of a mess, I think. It looks as though the
modification required within Git::SVN::Ra is going to negatively
impact other code paths that interact with that package from the
outside.
For example, when doing git svn init --minimize-url ..., the minimized
url is not escaped while the url is. The minimized url is used to
strip off the head from the full url using a regex. This now breaks
because of the escaping.
Fixing this locally to the use of the minimized url let me move on
farther but I then got another core dump.
> Maybe just enable the escaping for file:// on >= SVN 1.7
I think that it would be best if this change was only effective for
1.7.
I wonder if all URL-ish objects should be (conditionally iff svn >=
1.7) subjected to escaping?
This would require some restructuring and will take me a bit of time
to work out as I need to familiarize myself with the code to a deeper
level.
Pointers welcomed. :)
Thanks
-Ben
--
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302
next prev parent reply other threads:[~2011-11-04 2:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-02 16:38 (unknown), Ben Walton
2011-11-02 16:38 ` [PATCH] Escape file:// URL's to meet subversion SVN::Ra requirements Ben Walton
2011-11-02 18:20 ` Jonathan Nieder
2011-11-02 19:05 ` Ben Walton
2011-11-02 22:09 ` Eric Wong
2011-11-04 2:11 ` Ben Walton [this message]
2011-11-04 6:38 ` Jonathan Nieder
2012-07-16 20:16 ` Michael Witten
2011-12-17 8:45 ` Jonathan Nieder
2011-12-17 9:50 ` Jonathan Nieder
2011-12-17 23:48 ` Ben Walton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320372215-sup-8341@pinkfloyd.chass.utoronto.ca \
--to=bwalton@artsci.utoronto.ca \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).