From: Yann Dirson <ydirson@altern.org>
To: git@vger.kernel.org
Subject: [PATCH v6] generalizing sorted-array handling
Date: Wed, 8 Dec 2010 23:51:29 +0100 [thread overview]
Message-ID: <1291848695-24601-1-git-send-email-ydirson@altern.org> (raw)
I hope the improvements to the usage syntax in this version would help
to get more feedback. I don't plan to do much more structural work on
this, unless reviewers complain. I want to get my focus back to
bulk-rename/builk-rm patches, which will make heavy use of this API.
Changes from v5:
* moved doc to Documentation/api-sorted-array.txt as suggested by
Jonathan Nieder, made it a bit more comprehensive as well.
* changed API with:
* renamed low-level wrapper-decl macros with a leading underscore
* provide high-level wrapper-decl macros for everyday use, which
declare the required generic funcs for use (as static funcs)
Those high-level macros make the entry points more numerousas
previously noted, but we gain much in usage clarity, as well as
consistent API (no more argument differences between macros of a
single level)
By using those macros we lose the control we had on all the
intermediate funcs, but that should not be much of a problem.
Notes on current API:
* The macro names are a bit heavy-weight. Better ideas welcome.
* could gain a dealloc API, to minimize the explicit use of the _nr
and _alloc vars
The following binary-search occurences were not converted:
* read-cache.c::index_name_pos has widely-used API with 2 low-coupled
cmp/init params: sorted-array could be generalized at the cost of
using stdarg, but is it worth it ?
* pack-revindex.c::find_pack_revindex is a bit special and needs more
thought
* cache-tree.c::subtree_pos and sha1_file::find_pack_entry_one too
* sha1_lookup.c stuff probably too special
next reply other threads:[~2010-12-08 22:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 22:51 Yann Dirson [this message]
2010-12-08 22:51 ` [PATCH 1/6] Introduce sorted-array binary-search function Yann Dirson
2010-12-10 22:29 ` Junio C Hamano
2010-12-30 0:40 ` Yann Dirson
2010-12-30 1:06 ` Erik Faye-Lund
2010-12-30 10:49 ` Yann Dirson
2010-12-08 22:51 ` [PATCH 2/6] Convert diffcore-rename's rename_dst to the new sorted-array API Yann Dirson
2010-12-10 22:32 ` Junio C Hamano
2010-12-08 22:51 ` [PATCH 3/6] Convert diffcore-rename's rename_src " Yann Dirson
2010-12-08 22:51 ` [PATCH 4/6] Convert pack-objects.c " Yann Dirson
2010-12-08 22:51 ` [PATCH 5/6] Use sorted-array API for commit.c's commit_graft Yann Dirson
2010-12-08 22:51 ` [PATCH 6/6] [RFC] subvert sorted-array to replace binary-search in unpack-objects Yann Dirson
2010-12-10 23:00 ` Junio C Hamano
2010-12-10 23:22 ` [PATCH v6] generalizing sorted-array handling Junio C Hamano
2010-12-30 0:01 ` Yann Dirson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291848695-24601-1-git-send-email-ydirson@altern.org \
--to=ydirson@altern.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).