From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= Subject: [PATCH/RFC 3/3] t/t7008-grep-binary.sh: un-TODO a test that needs REG_STARTEND Date: Tue, 17 Aug 2010 03:25:48 +0000 Message-ID: <1282015548-19074-4-git-send-email-avarab@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Paolo Bonzini , Andreas Schwab , Jonathan Nieder , Junio C Hamano , =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Aug 17 05:26:44 2010 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OlCp2-0001sx-Cw for gcvg-git-2@lo.gmane.org; Tue, 17 Aug 2010 05:26:44 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755619Ab0HQD0f convert rfc822-to-quoted-printable (ORCPT ); Mon, 16 Aug 2010 23:26:35 -0400 Received: from mail-ww0-f44.google.com ([74.125.82.44]:52582 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755586Ab0HQD0c (ORCPT ); Mon, 16 Aug 2010 23:26:32 -0400 Received: by wwi17 with SMTP id 17so452482wwi.1 for ; Mon, 16 Aug 2010 20:26:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer:in-reply-to:references:mime-version :content-type:content-transfer-encoding; bh=zsEATZ32Zn+8zZXY5q9qh4457qCFLjQyjZGiQxW3Xck=; b=DWJ3Y3Q+qC4vxFHiJdNa91YVg1niPQxiZqtLWccIbufsHijH5xWujVS1Zi37lVEHf4 pzMFBwujVFtusPGXMNfkQnJTkvD8qMX9dIVoU8wqO//SbRbtDAXHbwQ0nZhjkhv/0w/U R/s+HW+Bh8rDy6b/6nhkB7OJ8Xqr7YRPGSVlE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :mime-version:content-type:content-transfer-encoding; b=n6PQrxUA2oduFYXmONq9tzlzlyTRmoOu2y6UwyTEUEr5sDkZMhdFADUO0TcUjQnjCm 9LPQ+wyxvbyMsxTbNaHVKacJUd6/C8jpZFPwQOPaoN3gcTKmVBiBYOG7J3hib4RhIgiz uaw/gDTnLoI7S4yLMo6ncH+fru487U5MQzvVI= Received: by 10.227.142.84 with SMTP id p20mr5146769wbu.182.1282015591657; Mon, 16 Aug 2010 20:26:31 -0700 (PDT) Received: from v.nix.is (v.nix.is [109.74.193.250]) by mx.google.com with ESMTPS id r10sm6060786wbe.0.2010.08.16.20.26.30 (version=SSLv3 cipher=RC4-MD5); Mon, 16 Aug 2010 20:26:30 -0700 (PDT) X-Mailer: git-send-email 1.7.2.1.389.gc3d0b In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Now that we have a regex engine that supports REG_STARTEND this test should fail if "git grep" can't grep NULL characters. Platforms that don't have a POSIX regex engine that supports REG_STARTEND should always define NO_REGEX=3DYesPlease when compiling. Signed-off-by: =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason --- t/t7008-grep-binary.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/t/t7008-grep-binary.sh b/t/t7008-grep-binary.sh index eb8ca88..c0f9f3f 100755 --- a/t/t7008-grep-binary.sh +++ b/t/t7008-grep-binary.sh @@ -61,7 +61,7 @@ test_expect_success 'git grep -Fi iLE a' ' =20 # This test actually passes on platforms where regexec() supports the # flag REG_STARTEND. -test_expect_failure 'git grep ile a' ' +test_expect_success 'git grep ile a' ' git grep ile a ' =20 --=20 1.7.2.1.389.gc3d0b