From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: [PATCH v2 0/7] tests: use skip_all=* to skip tests
Date: Wed, 11 Aug 2010 19:04:03 +0000 [thread overview]
Message-ID: <1281553450-26467-1-git-send-email-avarab@gmail.com> (raw)
In-Reply-To: <7vd3tpxao1.fsf@alter.siamese.dyndns.org>
On Wed, Aug 11, 2010 at 18:32, Junio C Hamano <gitster@pobox.com> wrote:
> Except for a few which I'll comment separately all of these looked
> reasonable (I didn't look at 7/7 very carefully, though).
Thanks for the review. Here's a v2 that fixes the isssues raised.
Like v1 aside from these fixes, all but one spotted by Junio:
diff --git a/t/t1304-default-acl.sh b/t/t1304-default-acl.sh
index 0e6cb4f..b5d89a2 100755
--- a/t/t1304-default-acl.sh
+++ b/t/t1304-default-acl.sh
@@ -28 +27,0 @@ fi
-
diff --git a/t/t4016-diff-quote.sh b/t/t4016-diff-quote.sh
index 10e2db3..ab0c2f0 100755
--- a/t/t4016-diff-quote.sh
+++ b/t/t4016-diff-quote.sh
@@ -14 +14 @@ P2='pathname with SP'
-if P3='pathname
+P3='pathname
@@ -16 +16 @@ with LF'
-: 2>/dev/null >"$P1" && test -f "$P1" && rm -f "$P1"
+if : 2>/dev/null >"$P1" && test -f "$P1" && rm -f "$P1"
diff --git a/t/t5705-clone-2gb.sh b/t/t5705-clone-2gb.sh
index 694e28d..e9783c3 100755
--- a/t/t5705-clone-2gb.sh
+++ b/t/t5705-clone-2gb.sh
@@ -6 +6,6 @@ test_description='Test cloning a repository larger than 2 gigabyte'
-test -n "$GIT_TEST_CLONE_2GB" && test_set_prereq CLONE_2GB
+if test -z "$GIT_TEST_CLONE_2GB"
+then
+ say 'Skipping expensive 2GB clone test; enable it with GIT_TEST_CLONE_2GB=t'
+else
+ test_set_prereq CLONE_2GB
+fi
Ævar Arnfjörð Bjarmason (7):
t/t1304-default-acl: change from skip_all=* to prereq skip
t/t5705-clone-2gb: change from skip_all=* to prereq skip
t/t7005-editor: change from skip_all=* to prereq skip
t/t5503-tagfollow: change from skip_all=* to prereq skip
t/t4016-diff-quote: change from skip_all=* to prereq skip
t/t3902-quoted: change from skip_all=* to prereq skip
t/t3300-funny-names: change from skip_all=* to prereq skip
t/t1304-default-acl.sh | 14 +++++---
t/t3300-funny-names.sh | 82 +++++++++++++++++++++++++++++++++++-------------
t/t3902-quoted.sh | 38 ++++++++++++----------
t/t4016-diff-quote.sh | 22 +++++++++----
t/t5503-tagfollow.sh | 33 ++++++++++++++-----
t/t5705-clone-2gb.sh | 16 +++++----
t/t7005-editor.sh | 10 +++---
7 files changed, 142 insertions(+), 73 deletions(-)
--
1.7.2.1.295.gdf931
next prev parent reply other threads:[~2010-08-11 19:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-10 19:52 [PATCH 0/7] tests: use skip_all=* to skip tests Ævar Arnfjörð Bjarmason
2010-08-10 19:52 ` [PATCH 1/7] t/t1304-default-acl: change from skip_all=* to prereq skip Ævar Arnfjörð Bjarmason
2010-08-10 19:52 ` [PATCH 2/7] t/t5705-clone-2gb: " Ævar Arnfjörð Bjarmason
2010-08-11 18:32 ` Junio C Hamano
2010-08-10 19:52 ` [PATCH 3/7] t/t7005-editor: " Ævar Arnfjörð Bjarmason
2010-08-10 19:52 ` [PATCH 4/7] t/t5503-tagfollow: " Ævar Arnfjörð Bjarmason
2010-08-11 18:32 ` Junio C Hamano
2010-08-11 18:47 ` Ævar Arnfjörð Bjarmason
2010-08-12 17:23 ` Junio C Hamano
2010-08-11 20:20 ` Johannes Sixt
2010-08-10 19:52 ` [PATCH 5/7] t/t4016-diff-quote: " Ævar Arnfjörð Bjarmason
2010-08-11 18:32 ` Junio C Hamano
2010-08-10 19:52 ` [PATCH 6/7] t/t3902-quoted: " Ævar Arnfjörð Bjarmason
2010-08-10 19:52 ` [PATCH 7/7] t/t3300-funny-names: " Ævar Arnfjörð Bjarmason
2010-08-11 18:32 ` [PATCH 0/7] tests: use skip_all=* to skip tests Junio C Hamano
2010-08-11 19:04 ` Ævar Arnfjörð Bjarmason [this message]
2010-08-12 6:22 ` case where diff output needs improving? (was Re: [PATCH v2 0/7] tests: use skip_all=* to skip tests) Raja R Harinath
2010-08-12 6:43 ` Ævar Arnfjörð Bjarmason
2010-08-11 19:04 ` [PATCH v2 1/7] t/t1304-default-acl: change from skip_all=* to prereq skip Ævar Arnfjörð Bjarmason
2010-08-11 19:04 ` [PATCH v2 2/7] t/t5705-clone-2gb: " Ævar Arnfjörð Bjarmason
2010-08-11 19:04 ` [PATCH v2 3/7] t/t7005-editor: " Ævar Arnfjörð Bjarmason
2010-08-11 19:04 ` [PATCH v2 4/7] t/t5503-tagfollow: " Ævar Arnfjörð Bjarmason
2010-08-11 19:04 ` [PATCH v2 5/7] t/t4016-diff-quote: " Ævar Arnfjörð Bjarmason
2010-08-11 19:04 ` [PATCH v2 6/7] t/t3902-quoted: " Ævar Arnfjörð Bjarmason
2010-08-11 19:04 ` [PATCH v2 7/7] t/t3300-funny-names: " Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281553450-26467-1-git-send-email-avarab@gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).