From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= Subject: [PATCH] Add option to git-commit to allow empty log messages Date: Sun, 4 Apr 2010 14:49:16 +0000 Message-ID: <1270392557-26538-1-git-send-email-avarab@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: gitster@pobox.com, =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Sun Apr 04 16:49:56 2010 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NyR95-0002Ae-7O for gcvg-git-2@lo.gmane.org; Sun, 04 Apr 2010 16:49:51 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754576Ab0DDOtq convert rfc822-to-quoted-printable (ORCPT ); Sun, 4 Apr 2010 10:49:46 -0400 Received: from mail-gx0-f217.google.com ([209.85.217.217]:57890 "EHLO mail-gx0-f217.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754515Ab0DDOtp (ORCPT ); Sun, 4 Apr 2010 10:49:45 -0400 Received: by gxk9 with SMTP id 9so2528454gxk.8 for ; Sun, 04 Apr 2010 07:49:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer:in-reply-to:references:mime-version :content-type:content-transfer-encoding; bh=y3x3AJUhtwzE5/GPPTztlp71qDaSuuSLL3YKypaVeXc=; b=CjdM16Ocq6ofg/eQUGK7Umdsqu1pj8IV7atFq4y5jYTH+nj+x8qKmDM4xHHth+akkc 6YZxT6E4sf/vSJJUDwGIsITJPOgrsjXmoIv7WVbFG4N75Jt28OcNiU/l++zicPqcSpt3 KrxsibzJKaZroXAwKpzk6PFZ9Qfo1Lyoi3Dzk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :mime-version:content-type:content-transfer-encoding; b=dtwhzLHKadzO59UteSHg2E6wZX9i/GxvmlClcfW/FCneDBbRe6VINq8fTV+03iVYMa hnYYfnXkWka+A2yRrnmHxcMdVC9EAchWtfAa/scBio7NfJXYW+JlBkkVI4Yazb4rNe+S PpDzDWmowOJ6QyMoMKnEdEDAbuDPuV63q6O78= Received: by 10.150.61.4 with SMTP id j4mr5012090yba.303.1270392584201; Sun, 04 Apr 2010 07:49:44 -0700 (PDT) Received: from localhost.localdomain ([72.14.241.33]) by mx.google.com with ESMTPS id 7sm3008179ywf.25.2010.04.04.07.49.41 (version=SSLv3 cipher=RC4-MD5); Sun, 04 Apr 2010 07:49:43 -0700 (PDT) X-Mailer: git-send-email 1.7.0.4.298.gc81d In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Change git-commit(1) to accept a --allow-empty-message option analogous to the existing --allow-empty option which allows empty trees. This is mainly for compatability with foreign SCM systems. Signed-off-by: =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason --- Documentation/git-commit.txt | 12 +++++++-- builtin/commit.c | 7 +++-- t/t7510-commit-allow-empty-message.sh | 41 +++++++++++++++++++++++++= ++++++++ 3 files changed, 54 insertions(+), 6 deletions(-) create mode 100755 t/t7510-commit-allow-empty-message.sh diff --git a/Documentation/git-commit.txt b/Documentation/git-commit.tx= t index 64fb458..2c1c2e1 100644 --- a/Documentation/git-commit.txt +++ b/Documentation/git-commit.txt @@ -10,9 +10,9 @@ SYNOPSIS [verse] 'git commit' [-a | --interactive] [-s] [-v] [-u] [--amend] [--dr= y-run] [(-c | -C) ] [-F | -m ] [--reset-author] - [--allow-empty] [--no-verify] [-e] [--author=3D] - [--date=3D] [--cleanup=3D] [--status | --no-status] [-= -] - [[-i | -o ]...] + [--allow-empty] [--allow-empty-message] [--no-verify] [-e] + [--author=3D] [--date=3D] [--cleanup=3D] + [--status | --no-status] [--] [[-i | -o ]...] =20 DESCRIPTION ----------- @@ -131,6 +131,12 @@ OPTIONS from making such a commit. This option bypasses the safety, and is primarily for use by foreign scm interface scripts. =20 +--allow-empty-message:: + Like --allow-empty this command is primarily for use by foreign + scm interface scripts. It allows you to create a commit with an + empty commit message without using plumbing commands like + linkgit:git-commit-tree[1]. + --cleanup=3D:: This option sets how the commit message is cleaned up. The '' can be one of 'verbatim', 'whitespace', 'strip', diff --git a/builtin/commit.c b/builtin/commit.c index c5ab683..7fd963e 100644 --- a/builtin/commit.c +++ b/builtin/commit.c @@ -65,8 +65,8 @@ static const char *template_file; static char *edit_message, *use_message; static char *author_name, *author_email, *author_date; static int all, edit_flag, also, interactive, only, amend, signoff; -static int quiet, verbose, no_verify, allow_empty, dry_run, renew_auth= orship; -static int no_post_rewrite; +static int quiet, verbose, no_verify, allow_empty, allow_empty_message= , dry_run; +static int no_post_rewrite, renew_authorship; static char *untracked_files_arg, *force_date; /* * The default commit message cleanup mode will remove the lines @@ -141,6 +141,7 @@ static struct option builtin_commit_options[] =3D { OPT_BOOLEAN(0, "no-post-rewrite", &no_post_rewrite, "bypass post-rewr= ite hook"), { OPTION_STRING, 'u', "untracked-files", &untracked_files_arg, "mode"= , "show untracked files, optional modes: all, normal, no. (Default: all= )", PARSE_OPT_OPTARG, NULL, (intptr_t)"all" }, OPT_BOOLEAN(0, "allow-empty", &allow_empty, "ok to record an empty ch= ange"), + OPT_BOOLEAN(0, "allow-empty-message", &allow_empty_message, "ok to re= cord a change with an empty message"), /* end commit contents options */ =20 OPT_END() @@ -1293,7 +1294,7 @@ int cmd_commit(int argc, const char **argv, const= char *prefix) =20 if (cleanup_mode !=3D CLEANUP_NONE) stripspace(&sb, cleanup_mode =3D=3D CLEANUP_ALL); - if (message_is_empty(&sb)) { + if (message_is_empty(&sb) && !allow_empty_message) { rollback_index_files(); fprintf(stderr, "Aborting commit due to empty commit message.\n"); exit(1); diff --git a/t/t7510-commit-allow-empty-message.sh b/t/t7510-commit-all= ow-empty-message.sh new file mode 100755 index 0000000..d7dc0da --- /dev/null +++ b/t/t7510-commit-allow-empty-message.sh @@ -0,0 +1,41 @@ +#!/bin/sh +# +# Copyright (c) 2010 =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason +# + +test_description=3D'git commit --allow-empty-message' + +. ./test-lib.sh + +commit_msg_is () { + test "`git log --pretty=3Dformat:%s%b -1`" =3D "$1" +} + +# A sanity check to see if commit is working at all. +test_expect_success 'a basic commit in an empty tree should succeed' ' + ( + echo content > foo && + git add foo && + git commit -m "initial commit" + ) && + commit_msg_is "initial commit" +' + +test_expect_success 'Commit no message with --allow-empty-message' ' + ( + echo "more content" >> foo && + git add foo && + printf "" | git commit --allow-empty-message + ) && + commit_msg_is "" +' + +test_expect_success 'Commit a message with --allow-empty-message' ' + ( + echo "even more content" >> foo && + git add foo && + git commit --allow-empty-message -m"hello there" + ) && + commit_msg_is "hello there" +' +test_done --=20 1.7.0.4.298.gc81d