From: newren@gmail.com
To: git@vger.kernel.org
Cc: Johannes.Schindelin@gmx.de, kusmabite@gmail.com,
Elijah Newren <newren@gmail.com>
Subject: [PATCHv3 1/7] fast-export: Set revs.topo_order before calling setup_revisions
Date: Thu, 25 Jun 2009 22:48:27 -0600 [thread overview]
Message-ID: <1245991713-12782-2-git-send-email-newren@gmail.com> (raw)
In-Reply-To: <1245991713-12782-1-git-send-email-newren@gmail.com>
From: Elijah Newren <newren@gmail.com>
setup_revisions sets a variety of flags based on the setting of other
flags, such as setting the limited flag when topo_order is set. To avoid
circumventing any invariants created by setup_revisions, we set
revs.topo_order before calling it rather than after.
Signed-off-by: Elijah Newren <newren@gmail.com>
---
This patch is new since the last series.
builtin-fast-export.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/builtin-fast-export.c b/builtin-fast-export.c
index 6cef810..e0cfa60 100644
--- a/builtin-fast-export.c
+++ b/builtin-fast-export.c
@@ -514,6 +514,7 @@ int cmd_fast_export(int argc, const char **argv, const char *prefix)
git_config(git_default_config, NULL);
init_revisions(&revs, prefix);
+ revs.topo_order = 1;
argc = setup_revisions(argc, argv, &revs, NULL);
argc = parse_options(argc, argv, prefix, options, fast_export_usage, 0);
if (argc > 1)
@@ -524,7 +525,6 @@ int cmd_fast_export(int argc, const char **argv, const char *prefix)
get_tags_and_duplicates(&revs.pending, &extra_refs);
- revs.topo_order = 1;
if (prepare_revision_walk(&revs))
die("revision walk setup failed");
revs.diffopt.format_callback = show_filemodify;
--
1.6.3.2.323.geb889
next prev parent reply other threads:[~2009-06-26 4:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-26 4:48 A few fast export fixups -- round 3 newren
2009-06-26 4:48 ` newren [this message]
2009-06-26 4:48 ` [PATCHv3 2/7] fast-export: Omit tags that tag trees newren
2009-06-26 4:48 ` [PATCHv3 3/7] fast-export: Make sure we show actual ref names instead of "(null)" newren
2009-06-26 4:48 ` [PATCHv3 4/7] fast-export: Do parent rewriting to avoid dropping relevant commits newren
2009-06-26 4:48 ` [PATCHv3 5/7] fast-export: Add a --tag-of-filtered-object option for newly dangling tags newren
2009-06-26 4:48 ` [PATCHv3 6/7] Add new fast-export testcases newren
2009-06-26 4:48 ` [PATCHv3 7/7] fast-export: Document the fact that git-rev-list arguments are accepted newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245991713-12782-2-git-send-email-newren@gmail.com \
--to=newren@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=kusmabite@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).