git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* [PATCH] builtin-remote: Make "remote show" display all urls
@ 2009-06-06 15:16 Michael J Gruber
  0 siblings, 0 replies; only message in thread
From: Michael J Gruber @ 2009-06-06 15:16 UTC (permalink / raw)
  To: git; +Cc: Junio C Hamano

Currently, "git remote -v" lists all urls whereas "git remote show
$remote" shows only the first. Make it so that both show all.

Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
---
While looking around what I need to change in builtin-remote.c for the pushurls
I noticed the above asymmetric behaviour. While I'm not sure what multiple urls
are good for (as far as fetches are concerned) I think we should still show them
(they may all be used for push).

This is on top of maint.

 builtin-remote.c |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/builtin-remote.c b/builtin-remote.c
index fda9a54..d436412 100644
--- a/builtin-remote.c
+++ b/builtin-remote.c
@@ -1003,9 +1003,12 @@ static int show(int argc, const char **argv)
 
 		get_remote_ref_states(*argv, &states, query_flag);
 
-		printf("* remote %s\n  URL: %s\n", *argv,
-			states.remote->url_nr > 0 ?
-				states.remote->url[0] : "(no URL)");
+		printf("* remote %s\n", *argv);
+		if (states.remote->url_nr) {
+			for (i=0; i < states.remote->url_nr; i++)
+				printf("  URL: %s\n", states.remote->url[i]);
+		} else
+			printf("  URL: %s\n", "(no URL)");
 		if (no_query)
 			printf("  HEAD branch: (not queried)\n");
 		else if (!states.heads.nr)
-- 
1.6.3.2.277.gd10543

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2009-06-06 15:16 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-06 15:16 [PATCH] builtin-remote: Make "remote show" display all urls Michael J Gruber

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).