* [PATCH] gitattributes documentation: link to gitignore for glob format
@ 2008-09-21 12:43 Nguyễn Thái Ngọc Duy
2008-09-21 13:00 ` Wincent Colaiuta
0 siblings, 1 reply; 3+ messages in thread
From: Nguyễn Thái Ngọc Duy @ 2008-09-21 12:43 UTC (permalink / raw
To: git; +Cc: Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
Documentation/gitattributes.txt | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/Documentation/gitattributes.txt b/Documentation/gitattributes.txt
index 9a75257..45c11df 100644
--- a/Documentation/gitattributes.txt
+++ b/Documentation/gitattributes.txt
@@ -21,7 +21,9 @@ Each line in `gitattributes` file is of form:
glob attr1 attr2 ...
That is, a glob pattern followed by an attributes list,
-separated by whitespaces. When the glob pattern matches the
+separated by whitespaces. Glob pattern format is as same as
+one used by `gitignore` files. Please refer to linkgit:gitignore[5]
+for more information. When the glob pattern matches the
path in question, the attributes listed on the line are given to
the path.
--
1.6.0.2.427.g8dbf1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gitattributes documentation: link to gitignore for glob format
2008-09-21 12:43 [PATCH] gitattributes documentation: link to gitignore for glob format Nguyễn Thái Ngọc Duy
@ 2008-09-21 13:00 ` Wincent Colaiuta
2008-09-21 13:23 ` Nguyễn Thái Ngọc Duy
0 siblings, 1 reply; 3+ messages in thread
From: Wincent Colaiuta @ 2008-09-21 13:00 UTC (permalink / raw
To: Nguyễn Thái Ngọc Duy; +Cc: git
El 21/9/2008, a las 14:43, Nguyễn Thái Ngọc Duy escribió:
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
> Documentation/gitattributes.txt | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/Documentation/gitattributes.txt b/Documentation/
> gitattributes.txt
> index 9a75257..45c11df 100644
> --- a/Documentation/gitattributes.txt
> +++ b/Documentation/gitattributes.txt
> @@ -21,7 +21,9 @@ Each line in `gitattributes` file is of form:
> glob attr1 attr2 ...
>
> That is, a glob pattern followed by an attributes list,
> -separated by whitespaces. When the glob pattern matches the
> +separated by whitespaces. Glob pattern format is as same as
It's "whitespace", not "whitespaces". And the sentence you added has
two errors:
"as same as" should be "the same as"
> +one used by `gitignore` files. Please refer to linkgit:gitignore[5]
> +for more information. When the glob pattern matches the
And: "as one" should be "as the one".
And as a style point, you probably should start the sentence with "The
glob pattern" rather than "Glob pattern".
Did you actually proofread this before sending it?
Cheers,
Wincent
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] gitattributes documentation: link to gitignore for glob format
2008-09-21 13:00 ` Wincent Colaiuta
@ 2008-09-21 13:23 ` Nguyễn Thái Ngọc Duy
0 siblings, 0 replies; 3+ messages in thread
From: Nguyễn Thái Ngọc Duy @ 2008-09-21 13:23 UTC (permalink / raw
To: git, Wincent Colaiuta; +Cc: Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
On 9/21/08, Wincent Colaiuta <win@wincent.com> wrote:
> Did you actually proofread this before sending it?
I did, but obviously I should have been more serious on
English classes.
Documentation/gitattributes.txt | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/Documentation/gitattributes.txt b/Documentation/gitattributes.txt
index 9a75257..708a9b5 100644
--- a/Documentation/gitattributes.txt
+++ b/Documentation/gitattributes.txt
@@ -21,7 +21,9 @@ Each line in `gitattributes` file is of form:
glob attr1 attr2 ...
That is, a glob pattern followed by an attributes list,
-separated by whitespaces. When the glob pattern matches the
+separated by whitespace. The glob pattern format is the same as
+the one used by `gitignore` files. Please refer to linkgit:gitignore[5]
+for more information. When the glob pattern matches the
path in question, the attributes listed on the line are given to
the path.
--
1.6.0.2.427.g8dbf1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-09-21 13:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-21 12:43 [PATCH] gitattributes documentation: link to gitignore for glob format Nguyễn Thái Ngọc Duy
2008-09-21 13:00 ` Wincent Colaiuta
2008-09-21 13:23 ` Nguyễn Thái Ngọc Duy
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).