From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 5FFF71F770 for ; Mon, 31 Dec 2018 11:13:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727191AbeLaLNH convert rfc822-to-8bit (ORCPT ); Mon, 31 Dec 2018 06:13:07 -0500 Received: from smtp.msys.ch ([46.175.8.2]:45581 "EHLO sleipnir.msys.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727078AbeLaLNG (ORCPT ); Mon, 31 Dec 2018 06:13:06 -0500 Received: from mail.msys.ch (smtp.msys.ch [46.175.8.2]) by sleipnir.msys.ch (8.14.3/8.14.3) with ESMTP id wBVD1ROO012705 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 31 Dec 2018 13:01:28 GMT Received: from dev.arcapos.ch (dev.arcapos.ch [46.175.8.141]) (authenticated bits=0) by mail.msys.ch (8.14.3/8.14.3) with ESMTP id wBVD1Q93022591 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 31 Dec 2018 13:01:26 GMT Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: Regression in git-subtree.sh, introduced in 2.20.1, after 315a84f9aa0e2e629b0680068646b0032518ebed From: Marc Balmer In-Reply-To: Date: Mon, 31 Dec 2018 12:12:56 +0100 Cc: Git Mailing List , roger.strain@swri.org, Junio C Hamano Content-Transfer-Encoding: 8BIT Message-Id: <11AC6C27-4C74-43B1-89F6-98ABBFE74E0E@msys.ch> References: To: Duy Nguyen X-Mailer: Apple Mail (2.3445.102.3) X-SMTP-Vilter-Version: 1.3.6 X-Spamd-Symbols: BAYES_00,RCVD_IN_DNSWL_LOW Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org > Am 31.12.2018 um 11:51 schrieb Duy Nguyen : > > On Mon, Dec 31, 2018 at 5:44 PM Marc Balmer wrote: >> >> Hi >> >> One of the last three commits in git-subtree.sh introduced a regression leading to a segfault. >> >> Here is the error message when I try to split out my i18n files: >> >> $ git subtree split --prefix=i18n >> cache for e39a2a0c6431773a5d831eb3cb7f1cd40d0da623 already exists! >> (Lots of output omitted) >> 436/627 (1819) [1455] <- Stays at 436/ while the numbers in () and [] increase, then segfaults: >> /usr/libexec/git-core/git-subtree: line 751: 54693 Done eval "$grl" >> 54694 Segmentation fault (core dumped) | while read rev parents; do > > Do you still have this core dump? Could you run it and see if it's > "git" that crashed (and where) or "sh"? It is /usr/bin/bash that segfaults. My guess is, that it runs out of memory (as described above, git-subtree enters an infinite loop untils it segafults). > >> process_split_commit "$rev" "$parents" 0; >> done >> >> Please note that this regression can not easily be reproduced, normally a subtree split just works. >> >> Reverting the last three commits "fixes" the issue. So I kindly ask the last three commits to be reverted. > > Please provide the SHA-1 of the "good" commit you tested. I reverted these three commits (actually the last three commits to contrib/subtree/git-subtree.sh): 19ad68d95d6f8104eca1e86f8d1dfae50c7fb268 68f8ff81513fb3599ef3dfc3dd11da36d868e91b 315a84f9aa0e2e629b0680068646b0032518ebed And then it worked. - Marc -- > Duy