* [PATCH] Install man3 manpages to $PREFIX/share/man/man3 even for site installs
@ 2007-07-19 12:45 martin f. krafft
2007-07-20 0:42 ` Junio C Hamano
0 siblings, 1 reply; 6+ messages in thread
From: martin f. krafft @ 2007-07-19 12:45 UTC (permalink / raw
To: git
MakeMaker supports three installation modes: perl, site, and vendor. The first
and third install manpages to $PREFIX/share/man, only site installs to
$PREFIX/man. For consistency with the rest of git, which does not make the
distinction and writes all manpages to $PREFIX/share/man, this change makes
sure that perl does too, even when it's installed in site mode.
Signed-off-by: martin f. krafft <madduck@madduck.net>
---
perl/Makefile.PL | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/perl/Makefile.PL b/perl/Makefile.PL
index 4375161..6aecd89 100644
--- a/perl/Makefile.PL
+++ b/perl/Makefile.PL
@@ -29,5 +29,6 @@ WriteMakefile(
VERSION_FROM => 'Git.pm',
PM => \%pm,
MAKEFILE => 'perl.mak',
+ INSTALLSITEMAN3DIR => '$(SITEPREFIX)/share/man/man3',
%extra
);
--
1.5.3.rc2.19.gc4fba-dirty
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Install man3 manpages to $PREFIX/share/man/man3 even for site installs
2007-07-19 12:45 martin f. krafft
@ 2007-07-20 0:42 ` Junio C Hamano
2007-07-20 0:46 ` Randal L. Schwartz
0 siblings, 1 reply; 6+ messages in thread
From: Junio C Hamano @ 2007-07-20 0:42 UTC (permalink / raw
To: Randal L. Schwartz; +Cc: git, martin f. krafft
Randal, I cannot decide if this is the right thing to do, or
better than what we currently do. Could you care to enlighten
us please?
"martin f. krafft" <madduck@madduck.net> writes:
> MakeMaker supports three installation modes: perl, site, and vendor. The first
> and third install manpages to $PREFIX/share/man, only site installs to
> $PREFIX/man. For consistency with the rest of git, which does not make the
> distinction and writes all manpages to $PREFIX/share/man, this change makes
> sure that perl does too, even when it's installed in site mode.
>
> Signed-off-by: martin f. krafft <madduck@madduck.net>
> ---
> perl/Makefile.PL | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/perl/Makefile.PL b/perl/Makefile.PL
> index 4375161..6aecd89 100644
> --- a/perl/Makefile.PL
> +++ b/perl/Makefile.PL
> @@ -29,5 +29,6 @@ WriteMakefile(
> VERSION_FROM => 'Git.pm',
> PM => \%pm,
> MAKEFILE => 'perl.mak',
> + INSTALLSITEMAN3DIR => '$(SITEPREFIX)/share/man/man3',
> %extra
> );
> --
> 1.5.3.rc2.19.gc4fba-dirty
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Install man3 manpages to $PREFIX/share/man/man3 even for site installs
2007-07-20 0:42 ` Junio C Hamano
@ 2007-07-20 0:46 ` Randal L. Schwartz
0 siblings, 0 replies; 6+ messages in thread
From: Randal L. Schwartz @ 2007-07-20 0:46 UTC (permalink / raw
To: Junio C Hamano; +Cc: git, martin f. krafft
>>>>> "Junio" == Junio C Hamano <gitster@pobox.com> writes:
Junio> Randal, I cannot decide if this is the right thing to do, or
Junio> better than what we currently do. Could you care to enlighten
Junio> us please?
I'll have to research it. On *every single* major release of Perl, and even
some of the minor ones, the rules for what Makefile.PL does have changed.
It's really maddening.
--
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>
Perl/Unix/security consulting, Technical writing, Comedy, etc. etc.
See PerlTraining.Stonehenge.com for onsite and open-enrollment Perl training!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Install section 3 manpages to .../share/man for consistency
@ 2007-08-20 7:23 martin f. krafft
2007-08-20 7:23 ` [PATCH] Install man3 manpages to $PREFIX/share/man/man3 even for site installs martin f. krafft
0 siblings, 1 reply; 6+ messages in thread
From: martin f. krafft @ 2007-08-20 7:23 UTC (permalink / raw
To: git
When an admin installs git site-wide, e.g. to /usr/local, perl's makemaker
decides to use 'site' mode (as opposed to distro or user mode). For whatever
reason, it then installs all perl-related manpages (those in section 3) to
.../man, while the rest of git happily installs manpages to .../share/man.
In as such, this is different from the patch proposed in this thread:
http://marc.info/?t=117862141100003&r=1&w=2
My patch should only ever affect site installs and does not cause
installations to $HOME to go to $HOME/share/...
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] Install man3 manpages to $PREFIX/share/man/man3 even for site installs
2007-08-20 7:23 Install section 3 manpages to .../share/man for consistency martin f. krafft
@ 2007-08-20 7:23 ` martin f. krafft
2007-08-23 8:11 ` Junio C Hamano
0 siblings, 1 reply; 6+ messages in thread
From: martin f. krafft @ 2007-08-20 7:23 UTC (permalink / raw
To: git
MakeMaker supports three installation modes: perl, site, and vendor. The first
and third install manpages to $PREFIX/share/man, only site installs to
$PREFIX/man. For consistency with the rest of git, which does not make the
distinction and writes all manpages to $PREFIX/share/man, this change makes
sure that perl does too, even when it's installed in site mode.
Signed-off-by: martin f. krafft <madduck@madduck.net>
---
perl/Makefile.PL | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/perl/Makefile.PL b/perl/Makefile.PL
index 4375161..6aecd89 100644
--- a/perl/Makefile.PL
+++ b/perl/Makefile.PL
@@ -29,5 +29,6 @@ WriteMakefile(
VERSION_FROM => 'Git.pm',
PM => \%pm,
MAKEFILE => 'perl.mak',
+ INSTALLSITEMAN3DIR => '$(SITEPREFIX)/share/man/man3',
%extra
);
--
1.5.3.rc5.40.g2f82
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Install man3 manpages to $PREFIX/share/man/man3 even for site installs
2007-08-20 7:23 ` [PATCH] Install man3 manpages to $PREFIX/share/man/man3 even for site installs martin f. krafft
@ 2007-08-23 8:11 ` Junio C Hamano
0 siblings, 0 replies; 6+ messages in thread
From: Junio C Hamano @ 2007-08-23 8:11 UTC (permalink / raw
To: martin f. krafft; +Cc: git
Sorry for keeping you waiting for quite a while. I've had a
chance to test building an RPM tonight, and this does not seem
to affect the output (the perl manpage is already installed in
/usr/share/man/man3), so I'd say this is probably safe to
apply.
For people who do private installs, the path is changed from
$prefix/man/man3/ to $prefix/share/man/man3 (where $prefix is
typically set to $HOME), but all the other manual pages are
installed in $prefix/share/man/man[1-7] anyway, so this change
cannot hurt.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-08-23 8:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-20 7:23 Install section 3 manpages to .../share/man for consistency martin f. krafft
2007-08-20 7:23 ` [PATCH] Install man3 manpages to $PREFIX/share/man/man3 even for site installs martin f. krafft
2007-08-23 8:11 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2007-07-19 12:45 martin f. krafft
2007-07-20 0:42 ` Junio C Hamano
2007-07-20 0:46 ` Randal L. Schwartz
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).