From: "Uwe Kleine-König" <ukleinek@informatik.uni-freiburg.de>
To: Git Mailing List <git@vger.kernel.org>
Cc: "Uwe Kleine-König" <ukleinek@informatik.uni-freiburg.de>
Subject: [PATCH 1/2] send-email: rfc822 forbids using <address@domain> without a non-empty "phrase"
Date: Thu, 9 Aug 2007 15:27:57 +0200 [thread overview]
Message-ID: <1186666080946-git-send-email-ukleinek@informatik.uni-freiburg.de> (raw)
In-Reply-To: <11866660781833-git-send-email-ukleinek@informatik.uni-freiburg.de>
Email::Valid does respect this considering such a mailbox specification
invalid. b06c6bc831cbb9e9eb82fd3ffd5a2b674cd940d0 addressed the issue, but
only if Email::Valid is available.
Signed-off-by: Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de>
---
git-send-email.perl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index 39e433b..a02ab96 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -408,8 +408,8 @@ sub extract_valid_address {
# check for a local address:
return $address if ($address =~ /^($local_part_regexp)$/);
+ $address =~ s/^\s*<(.*)>\s*$/$1/;
if ($have_email_valid) {
- $address =~ s/^\s*<(.*)>\s*$/$1/;
return scalar Email::Valid->address($address);
} else {
# less robust/correct than the monster regexp in Email::Valid,
--
1.5.3.rc3.943.g14c81
next prev parent reply other threads:[~2007-08-09 13:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-09 13:27 [PATCH 0/2] patches for send-email Uwe Kleine-König
2007-08-09 13:27 ` Uwe Kleine-König [this message]
2007-08-09 13:27 ` [PATCH 2/2] send-email: get all the quoting of realnames right Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1186666080946-git-send-email-ukleinek@informatik.uni-freiburg.de \
--to=ukleinek@informatik.uni-freiburg.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).