From: "Kristian Høgsberg" <krh@redhat.com>
To: Carlos Rica <jasampler@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Implement git commit as a builtin.
Date: Fri, 20 Jul 2007 10:45:24 -0400 [thread overview]
Message-ID: <1184942724.26967.105.camel@hinata.boston.redhat.com> (raw)
In-Reply-To: <1b46aba20707181427y12bd8b62pe30df61219e7c1f7@mail.gmail.com>
On Wed, 2007-07-18 at 23:27 +0200, Carlos Rica wrote:
> 2007/7/18, Kristian Høgsberg <krh@redhat.com>:
> > + if (buffer) {
> > + len = strip_lines(buffer, len);
> > +
> > + if (fwrite(buffer, 1, len, fp) < len)
> > + die("could not write commit template: %s\n",
> > + strerror(errno));
> > + }
> ....
> > + len = strip_lines(buffer, len);
> > +
> > + if (message_is_empty(buffer, len))
> > + die("* no commit message? aborting commit.");
> > +
>
> Hi Kristian, you could call to the new stripspace() function
> in builtin-stripspace.c, to reduce code in your file. The only
> thing you should consider is that the new stripspace()
> removes always the last '\n' in the file (if any), so you have to
> add it when you need.
Yup, I'm keeping an eye on all your changes, and it looks like it's all
falling in place nicely. Once I have the last few pieces of
functionality ported over I'll rebase and update builtin-commit to use
the new functionality you've landed.
A couple of things that might be interesting right now is: 1) pick out
the test case I made for commit and get it upstream, and 2) take the
changes I did to wt-status.c (making it able to run on a different index
and output to a specified FILE pointer) and get that upstream.
cheers,
Kristian
prev parent reply other threads:[~2007-07-20 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-18 19:19 [PATCH] Implement git commit as a builtin Kristian Høgsberg
2007-07-18 19:43 ` Nicolas Pitre
2007-07-18 21:27 ` Carlos Rica
2007-07-20 14:45 ` Kristian Høgsberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1184942724.26967.105.camel@hinata.boston.redhat.com \
--to=krh@redhat.com \
--cc=git@vger.kernel.org \
--cc=jasampler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).