git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Robin H\. Johnson" <robbat2@gentoo.org>
To: git@vger.kernel.org
Cc: Junio C Hamano <junkio@cox.net>,
	"Robin H\. Johnson" <robbat2@gentoo.org>
Subject: [PATCH 4/9] Change the scope of the $cc variable as it is not needed outside of send_message.
Date: Wed, 25 Apr 2007 19:37:18 -0700	[thread overview]
Message-ID: <11775550433288-git-send-email-robbat2@gentoo.org> (raw)
In-Reply-To: <11775550432268-git-send-email-robbat2@gentoo.org>

From: Robin H. Johnson <robbat2@gentoo.org>

$cc is only used inside the send_message scope, so lets clean it out of the global scope.

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
---
 git-send-email.perl |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/git-send-email.perl b/git-send-email.perl
index 8af235f..5210a40 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -379,7 +379,7 @@ if (@files) {
 }
 
 # Variables we set as part of the loop over files
-our ($message_id, $cc, %mail, $subject, $reply_to, $references, $message);
+our ($message_id, %mail, $subject, $reply_to, $references, $message);
 
 sub extract_valid_address {
 	my $address = shift;
@@ -420,7 +420,6 @@ sub make_message_id
 
 
 
-$cc = "";
 $time = time - scalar $#files;
 
 sub unquote_rfc2047 {
@@ -448,6 +447,7 @@ sub send_message
 		my ($name, $addr) = ($from =~ /^(.*?)(\s+<.*)/);
 		$from = "\"$name\"$addr";
 	}
+	my $cc = join(", ", unique_email_list(@cc));
 	my $ccline = "";
 	if ($cc ne '') {
 		$ccline = "\nCc: $cc";
@@ -594,7 +594,6 @@ foreach my $t (@files) {
 		$message = "From: $author_not_sender\n\n$message";
 	}
 
-	$cc = join(", ", unique_email_list(@cc));
 
 	send_message();
 
-- 
1.5.2.rc0.43.g2f4c7

  reply	other threads:[~2007-04-26  2:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-26  2:37 git-send-email fixes, cleanups and improvements Robin H. Johnson
2007-04-26  2:37 ` [PATCH 1/9] Document --dry-run parameter to send-email Robin H. Johnson
2007-04-26  2:37   ` [PATCH 2/9] Prefix Dry- to the message status to denote dry-runs Robin H. Johnson
2007-04-26  2:37     ` [PATCH 3/9] Debugging cleanup improvements Robin H. Johnson
2007-04-26  2:37       ` Robin H. Johnson [this message]
2007-04-26  2:37         ` [PATCH 5/9] Perform correct quoting of recipient names Robin H. Johnson
2007-04-26  2:37           ` [PATCH 6/9] Validate @recipients before using it for sendmail and Net::SMTP Robin H. Johnson
2007-04-26  2:37             ` [PATCH 7/9] Ensure clean addresses are always used with Net::SMTP Robin H. Johnson
2007-04-26  2:37               ` [PATCH 8/9] Allow users to optionally specify their envelope sender Robin H. Johnson
2007-04-26  2:37                 ` [PATCH 9/9] Document --dry-run and envelope-sender for git-send-email Robin H. Johnson
2007-04-26  4:15           ` [PATCH 5/9] Perform correct quoting of recipient names Junio C Hamano
2007-04-26  4:41             ` Robin H. Johnson
2007-04-26  4:53               ` [PATCH 10/9] Sanitize @to recipients Robin H. Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11775550433288-git-send-email-robbat2@gentoo.org \
    --to=robbat2@gentoo.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).