* [PATCH] fix git-checkout-cache segfault on parisc
@ 2005-08-13 15:29 James Bottomley
0 siblings, 0 replies; only message in thread
From: James Bottomley @ 2005-08-13 15:29 UTC (permalink / raw
To: junkio; +Cc: git, PARISC list
This one I think is Linus' fault, so send him a brown paper bag with my
complements ...
The index cleanup code is executed via atexit() which is *after* main
has completed, so the stack allocated cache_file has gone out of scope.
Parisc seems to use stack in the destructor functions, so cache_file
gets partially overwritten leading to the predictable disastrous
consequences.
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
---
James
diff --git a/checkout-cache.c b/checkout-cache.c
--- a/checkout-cache.c
+++ b/checkout-cache.c
@@ -80,10 +80,11 @@ static int checkout_all(void)
static const char checkout_cache_usage[] =
"git-checkout-cache [-u] [-q] [-a] [-f] [-n] [--prefix=<string>] [--] <file>...";
+static struct cache_file cache_file;
+
int main(int argc, char **argv)
{
int i, force_filename = 0;
- struct cache_file cache_file;
int newfd = -1;
if (read_cache() < 0) {
diff --git a/index.c b/index.c
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-08-13 15:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-08-13 15:29 [PATCH] fix git-checkout-cache segfault on parisc James Bottomley
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).