From: Barret Rhoden <email@example.com>
To: firstname.lastname@example.org, email@example.com
Cc: "Jeff King" <firstname.lastname@example.org>,
"Stefan Beller" <email@example.com>,
"Jeff Smith" <firstname.lastname@example.org>,
"Junio C Hamano" <email@example.com>,
"René Scharfe" <firstname.lastname@example.org>,
"Ævar Arnfjörð Bjarmason" <email@example.com>,
"David Kastrup" <firstname.lastname@example.org>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] blame - fix some issues identified by coverage report.
Date: Mon, 3 Jun 2019 11:26:52 -0400 [thread overview]
Message-ID: <email@example.com> (raw)
Hi Michael -
On 6/1/19 5:09 PM, firstname.lastname@example.org wrote:
> From: Michael Platings <email@example.com>
> Thanks to Derrick Stolee for highlighting missing coverage.
> In the case of "certainties[i] = CERTAINTY_NOT_CALCULATED" this was
> defeating an optimization that preserved results of calculations
> between line-matching passes. This had caused other code to never
> be executed - that code is now executed and only discards calculation
> results that are no longer valid.
> In the case of "max_search_distance_b = 0" this was never executed
> because another statement was added earlier in the function to return
> early in such a case.
> Signed-off-by: Michael Platings <firstname.lastname@example.org>
If it's OK with you, I can squash this into your existing patch in the
blame-ignore patch set.
next prev parent reply other threads:[~2019-06-03 15:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Re: [PATCH v7 7/8] blame: add a fingerprint heuristic to match ignored lines>
2019-06-01 21:09 ` [PATCH] blame - fix some issues identified by coverage report michael
2019-06-03 15:26 ` Barret Rhoden [this message]
2019-06-03 18:08 ` Junio C Hamano
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).