mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Barret Rhoden <>
Cc: "Jeff King" <>,
	"Stefan Beller" <>,
	"Jeff Smith" <>,
	"Junio C Hamano" <>,
	"René Scharfe" <>,
	"Ævar Arnfjörð Bjarmason" <>,
	"David Kastrup" <>,
	"Johannes Schindelin" <>
Subject: Re: [PATCH] blame - fix some issues identified by coverage report.
Date: Mon, 3 Jun 2019 11:26:52 -0400	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Michael -

On 6/1/19 5:09 PM, wrote:
> From: Michael Platings <>
> Thanks to Derrick Stolee for highlighting missing coverage.
> In the case of "certainties[i] = CERTAINTY_NOT_CALCULATED" this was
> defeating an optimization that preserved results of calculations
> between line-matching passes. This had caused other code to never
> be executed - that code is now executed and only discards calculation
> results that are no longer valid.
> In the case of "max_search_distance_b = 0" this was never executed
> because another statement was added earlier in the function to return
> early in such a case.
> Signed-off-by: Michael Platings <>

If it's OK with you, I can squash this into your existing patch in the 
blame-ignore patch set.



  reply	other threads:[~2019-06-03 15:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Re: [PATCH v7 7/8] blame: add a fingerprint heuristic to match ignored lines>
2019-06-01 21:09 ` [PATCH] blame - fix some issues identified by coverage report michael
2019-06-03 15:26   ` Barret Rhoden [this message]
2019-06-03 18:08     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).