git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Alejandro Colomar <alx.manpages@gmail.com>
To: Theodore Dubois <tbodt@google.com>
Cc: linux-man@vger.kernel.org, mtk.manpages@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH] getpriority: Only getpriority translation the priority values
Date: Sat, 14 May 2022 16:37:41 +0200	[thread overview]
Message-ID: <0fc70bd3-5883-47e4-1814-6ed6c756a400@gmail.com> (raw)
In-Reply-To: <20220510220821.1481801-1-tbodt@google.com>

Hi Theodore,

On 5/11/22 00:08, Theodore Dubois wrote:
> The translation is needed to avoid returning a negative number from a
> successful syscall, and this requirement doesn't apply to setpriority.
> See the implementation of getpriority in kernel/sys.c.
> 
> Signed-off-by: Theodore Dubois <tbodt@google.com>

Patch applied.

BTW, I had to manually edit the patch.
It's the second time I see this (I can't find the other one), your patch 
didn't apply for the following reason: the a/ and b/ prefixes in the 
file paths are missing.  Did you use git-format-patch(1) to produce the 
patch?  Can you reproduce this?

I CCd the git mailing list in case they know what's going on.

Thanks,

Alex

> ---
>   man2/getpriority.2 | 17 ++++-------------
>   1 file changed, 4 insertions(+), 13 deletions(-)
> 
> diff --git man2/getpriority.2 man2/getpriority.2

Should have been:
diff --git a/man2/getpriority.2 b/man2/getpriority.2

> index 3e1be3e6c..24c1b7f11 100644
> --- man2/getpriority.2
> +++ man2/getpriority.2

Should have been:

--- a/man2/getpriority.2
+++ b/man2/getpriority.2


> @@ -206,20 +206,11 @@ All BSD-like systems (SunOS 4.1.3, Ultrix 4.2,
>   manner as Linux 2.6.12 and later.
>   .\"
>   .SS C library/kernel differences
> -Within the kernel, nice values are actually represented
> -using the range 40..1
> -(since negative numbers are error codes) and these are the values
> -employed by the
> -.BR setpriority ()
> -and
> -.BR getpriority ()
> -system calls.
> -The glibc wrapper functions for these system calls handle the
> -translations between the user-land and kernel representations
> -of the nice value according to the formula
> +The getpriority system call returns nice values translated to the range 40..1,
> +since a negative return value would be interpreted as an error.
> +The glibc wrapper function for getpriority translates the value back according to the formula
>   .IR "unice\ =\ 20\ \-\ knice" .
> -(Thus, the kernel's 40..1 range corresponds to the
> -range \-20..19 as seen by user space.)
> +(Thus, the 40..1 range returned by the kernel corresponds to the range \-20..19 as seen by user space.)
>   .SH BUGS
>   According to POSIX, the nice value is a per-process setting.
>   However, under the current Linux/NPTL implementation of POSIX threads,

-- 
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/

       reply	other threads:[~2022-05-14 14:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220510220821.1481801-1-tbodt@google.com>
2022-05-14 14:37 ` Alejandro Colomar [this message]
2022-05-14 15:00   ` Alejandro Colomar
2022-05-14 18:43   ` Martin Ågren
2022-05-14 21:18     ` Alejandro Colomar
2022-05-17 17:02     ` Theodore Dubois
2022-05-18 17:21       ` Perhaps we want {diff,log,format}.noprefix and friends? Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0fc70bd3-5883-47e4-1814-6ed6c756a400@gmail.com \
    --to=alx.manpages@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=linux-man@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=tbodt@google.com \
    --subject='Re: [PATCH] getpriority: Only getpriority translation the priority values' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).