From: "Torsten Bögershausen" <tboegi@web.de>
To: Sven Strickroth <email@cs-ware.de>, git@vger.kernel.org
Cc: gitster@pobox.com, peff@peff.net, johannes.schindelin@gmx.de
Subject: Re: [PATCH] Unbreak real_path on Windows for already absolute paths (with Visual Studio)
Date: Tue, 9 Apr 2019 07:53:09 +0200 [thread overview]
Message-ID: <0f629384-638f-bfb9-89da-ade335e364fd@web.de> (raw)
In-Reply-To: <6c7d4155-e554-dc9a-053e-f3a8c7cd4075@cs-ware.de>
On 2019-04-08 13:16, Sven Strickroth wrote:
> A path such as 'c:/somepath/submodule/../.git/modules/submodule' wasn't
> resolved correctly any more, because the *nix variant of
> offset_1st_component is used instead of the Win32 specific version.
>
> Regression was introduced in commit
> 25d90d1cb72ce51407324259516843406142fe89.
Was it ?
25d90d1cb merged this commit:
1cadad6f6 (junio/tb/use-common-win32-pathfuncs-on-cygwin)
And, if I read that correctly, 1cadad6f6 does not change anything for MSVC.
And the problem with the missing/wrong path resolution was there before
1cadad6f6 and after 1cadad6f6.
From that point of view, the patch looks correct, but:
The other question:
In config.mak.uname we need to add a line
compat/win32/path-utils.o
for the Windows build.
In the git-for windows codebase I see
COMPAT_OBJS +=compat/win32/path-utils
3 times:
For Cygwin, MINGW and Windows.
In git.git only for Cygwin and MINGW.
(I don't have MSVC, so I can't test)
>
> Signed-off-by: Sven Strickroth <email@cs-ware.de>
> ---
> git-compat-util.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/git-compat-util.h b/git-compat-util.h
> index e0275da7e0..9be177e588 100644
> --- a/git-compat-util.h
> +++ b/git-compat-util.h
> @@ -210,6 +210,7 @@
> #include "compat/mingw.h"
> #include "compat/win32/fscache.h"
> #elif defined(_MSC_VER)
> +#include "compat/win32/path-utils.h"
> #include "compat/msvc.h"
> #include "compat/win32/fscache.h"
> #else
>
next prev parent reply other threads:[~2019-04-09 5:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 11:16 [PATCH] Unbreak real_path on Windows for already absolute paths (with Visual Studio) Sven Strickroth
2019-04-09 2:36 ` Taylor Blau
2019-04-09 5:53 ` Torsten Bögershausen [this message]
2019-04-09 7:34 ` Sven Strickroth
2019-04-08 11:26 ` [PATCH v2] MSVC: Unbreak real_path for Windows paths Sven Strickroth
2019-04-09 11:45 ` Junio C Hamano
2019-04-09 16:19 ` [PATCH] Unbreak real_path on Windows for already absolute paths (with Visual Studio) Torsten Bögershausen
2019-04-09 16:46 ` Junio C Hamano
2019-04-10 5:32 ` Torsten Bögershausen
2019-04-12 1:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f629384-638f-bfb9-89da-ade335e364fd@web.de \
--to=tboegi@web.de \
--cc=email@cs-ware.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).