From: Alban Gruin <alban.gruin@gmail.com>
To: Stephen Boyd <sboyd@kernel.org>, git@vger.kernel.org
Cc: Adrian Johnson <ajohnson@redneon.com>,
William Duclot <william.duclot@ensimag.grenoble-inp.fr>,
Johannes Sixt <j6t@kdbg.org>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH] userdiff: Add a builtin pattern for dts files
Date: Thu, 17 Jan 2019 22:26:30 +0100 [thread overview]
Message-ID: <0dc48713-7a17-623f-af75-67cca2cd63b6@gmail.com> (raw)
In-Reply-To: <154749087173.169631.13885160480779834976@swboyd.mtv.corp.google.com>
Hi, sorry for the late answer.
Le 14/01/2019 à 19:34, Stephen Boyd a écrit :
> Quoting Alban Gruin (2019-01-13 13:26:21)
>> Hi Stephen,
>>
>> thank you for your patch. I left a few comments below.
>>
>> Le 11/01/2019 à 22:51, Stephen Boyd a écrit :
>>> diff --git a/userdiff.c b/userdiff.c
>>> index 97007abe5b16..2bc964e11089 100644
>>> --- a/userdiff.c
>>> +++ b/userdiff.c
>>> @@ -23,6 +23,15 @@ IPATTERN("ada",
>>> "[a-zA-Z][a-zA-Z0-9_]*"
>>> "|[-+]?[0-9][0-9#_.aAbBcCdDeEfF]*([eE][+-]?[0-9_]+)?"
>>> "|=>|\\.\\.|\\*\\*|:=|/=|>=|<=|<<|>>|<>"),
>>> +PATTERNS("dts",
>>> + /* Node name (with optional label and unit address) */
>>> + "^[ \t]*((([a-zA-Z_][a-zA-Z0-9_]*: )?[a-zA-Z][a-zA-Z0-9,._+-]*(@[a-zA-Z0-9,._+-]+)?"
>>
>> From the spec, label and node names “shall be [between] 1 to 31
>> characters in length”. It’s not enforced here, and I guess it’s not
>> really git’s job to check for this kind of rule. Others may disagree
>> with me, though.
>>
>> Should labels end with exactly one space after the colon, or can there
>> be more, or none at all?
>
> There can be any number of spaces after the colon. I can fix the regex
> here to accept any amount of whitespace after the colon.
>
>>
>>> + /* Reference */
>>> + "|&[a-zA-Z_][a-zA-Z0-9_]*[ \t]*)[ \t]*\\{)[ \t]*$",
>>
>> It’s not specified in the spec, but these lines must end with a curly
>> brace?
>
> That isn't common but it is supported. I can change the regex to look
> for a line that ends in '{' or something that isn't ';' with anything
> after the node name?
>
>> What if there is a comment after the curly brace?
>
> There can be a comment after the curly brace or before the curly brace.
> The spec allows C style /* */ type comments, in addition to C++ style //
> comments. I've never really seen that happen in practice though so it's
> not very common. Grepping the linux sources shows two hits:
>
> arch/arm/boot/dts/lpc3250-ea3250.dts:&ohci /* &usbd */ {
> arch/arm/boot/dts/lpc3250-phy3250.dts:&ohci /* &usbd */ {
>
I grepped through Linux and uboot’s sources and it seems that “it is not
common” is actually “it does not exists in the wild”. Perhaps it’s not
worth to support them.
>>
>>> + /* -- */
>>> + /* Property names and math operators */
>>> + "[a-zA-Z0-9,._+?#-]+"
>>> + "|[-+*/%&^|!~]"),
>>
>> There is a `%' operator here and in your tests, but it’s not mentioned
>> in the spec if I’m not mistaken. Does it actually exists?
>
> The compiler doesn't seem to complain when it's used. I can send a patch
> to update the spec for this rather esoteric feature. I can also include
> more tests and support for the boolean relational operators which also
> seem to be supported but probably never used.
>
I’d like you to do this, yes.
To be fair, I don’t know what to think about this patch after Junio’s
message.
next prev parent reply other threads:[~2019-01-17 21:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 21:51 [PATCH] userdiff: Add a builtin pattern for dts files Stephen Boyd
2019-01-13 21:26 ` Alban Gruin
2019-01-14 18:34 ` Junio C Hamano
2019-01-17 21:26 ` Alban Gruin
2019-01-14 18:34 ` Stephen Boyd
2019-01-17 21:26 ` Alban Gruin [this message]
2019-01-17 22:13 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dc48713-7a17-623f-af75-67cca2cd63b6@gmail.com \
--to=alban.gruin@gmail.com \
--cc=ajohnson@redneon.com \
--cc=devicetree@vger.kernel.org \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=william.duclot@ensimag.grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).