From: Derrick Stolee <stolee@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Oct 2020, #02; Fri, 9)
Date: Fri, 9 Oct 2020 12:31:37 -0400 [thread overview]
Message-ID: <0d8e4419-cf7c-360a-f676-1ded0c99bcf5@gmail.com> (raw)
In-Reply-To: <xmqqpn5rtld1.fsf@gitster.c.googlers.com>
On 10/9/2020 12:28 PM, Junio C Hamano wrote:
> Derrick Stolee <stolee@gmail.com> writes:
>
>> As for discarding them all: we would need to add code to "reparse"
>> a commit from the object database. Perhaps that is doable, but we
>> have so far not removed data from a parsed 'struct commit'. This
>> is probably the easiest way forward to guarantee correct data here.
>
> Oh, no, by "discarding" I just meant to blow away suspect on-disk
> files and recompute them from scratch. I didn't have anything
> clever like correcting in-core data structure by parsing the commits
> and updating.
Naturally, I'm over-thinking this. Your "throw away the current
stack" idea has merit and I'll take a look at how that could be
accomplished. It certainly would be non-trivial to communicate
at the current layer, but there might be a clever way to do this.
>> Again, let's find a way to test this before committing.
>
> Yes, that is sensible. After all this is not a recent regression.
Thanks,
-Stolee
prev parent reply other threads:[~2020-10-09 16:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 15:59 What's cooking in git.git (Oct 2020, #02; Fri, 9) Junio C Hamano
2020-10-09 16:15 ` Derrick Stolee
2020-10-09 16:28 ` Junio C Hamano
2020-10-09 16:31 ` Derrick Stolee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d8e4419-cf7c-360a-f676-1ded0c99bcf5@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).