git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff Hostetler <git@jeffhostetler.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>,
	"Derrick Stolee" <stolee@gmail.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Git Mailing List" <git@vger.kernel.org>,
	"Jeff King" <peff@peff.net>, "Junio C Hamano" <gitster@pobox.com>,
	"Josh Steadmon" <steadmon@google.com>,
	"Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Subject: Re: I made a flame graph renderer for git's trace2 output
Date: Mon, 20 May 2019 14:49:26 -0400	[thread overview]
Message-ID: <0c3e48e0-ef87-39c2-a984-ba7deede0651@jeffhostetler.com> (raw)
In-Reply-To: <20190510170014.GQ14763@szeder.dev>



On 5/10/2019 1:00 PM, SZEDER Gábor wrote:
> On Fri, May 10, 2019 at 12:38:52PM -0400, Derrick Stolee wrote:
>> export GIT_TR2_EVENT=~/git-tr2-event.txt
> 
> Hrm,  better late than never, or at least better late than after it's
> in a release...
> 
> Why does an environment variable that is supposed to be set by users
> have this "TR2" abbreviation in its prefix?  What exactly, if
> anything, did we gain by omitting "ACE" and not calling it
> "GIT_TRACE2_..."?
> 
> Ken Thompson springs to mind, who (allegedly?) later regretted
> spelling creat()/O_CREAT without the 'e'...
> 

For closure here on this thread.  I chose TR2 rather than TRACE2
somewhat at random for convenience during testing.  Changing is fine
as you suggest in your other patch series.

Thanks
Jeff

  reply	other threads:[~2019-05-20 18:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-10 15:09 I made a flame graph renderer for git's trace2 output Ævar Arnfjörð Bjarmason
2019-05-10 16:38 ` Derrick Stolee
2019-05-10 17:00   ` SZEDER Gábor
2019-05-20 18:49     ` Jeff Hostetler [this message]
2019-05-10 21:03 ` Jeff King
2019-05-10 21:57   ` Ævar Arnfjörð Bjarmason
2019-05-20 18:22     ` Jeff Hostetler
2019-05-21 14:19       ` Ævar Arnfjörð Bjarmason
2019-05-21 20:46         ` Jeff Hostetler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c3e48e0-ef87-39c2-a984-ba7deede0651@jeffhostetler.com \
    --to=git@jeffhostetler.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=steadmon@google.com \
    --cc=stolee@gmail.com \
    --cc=szeder.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).