From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 9E6D01F4B4 for ; Wed, 14 Oct 2020 10:27:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727821AbgJNK1Z (ORCPT ); Wed, 14 Oct 2020 06:27:25 -0400 Received: from dd36226.kasserver.com ([85.13.153.21]:60024 "EHLO dd36226.kasserver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726307AbgJNK1Z (ORCPT ); Wed, 14 Oct 2020 06:27:25 -0400 Received: from client3368.local (i5C745714.versanet.de [92.116.87.20]) by dd36226.kasserver.com (Postfix) with ESMTPSA id F3CFC3C03AC; Wed, 14 Oct 2020 12:27:23 +0200 (CEST) Subject: Re: [PATCH] git-gui: Make usettk off by default on Mac OS X To: Pratyush Yadav Cc: git@vger.kernel.org References: <20201013190243.62313-1-stefan@haller-berlin.de> <20201014100111.c43f2fqipc52dtsg@yadavpratyush.com> From: Stefan Haller Message-ID: <0aef1f02-5eed-41ed-c402-540fa50d79f1@haller-berlin.de> Date: Wed, 14 Oct 2020 12:27:23 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20201014100111.c43f2fqipc52dtsg@yadavpratyush.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 14.10.20 12:01, Pratyush Yadav wrote: > Hi Stefan, > > On 13/10/20 09:02PM, Stefan Haller wrote: >> This option is supposed to make a Tcl/Tk app look more like a native app >> for the respective platform. This doesn't seem to work on Mac, it looks >> worse than the non-ttk appearance (for instance, the colored pane >> headers are grey). > > I think we should actually fix the root of the problem instead of just > fixing the symptoms by disabling ttk. > > There were recently some changes to how git-gui works with ttk in commit > c02efc1 (git-gui: improve dark mode support, 2020-09-26). Are you > running git-gui with that commit? If yes, what results do you see with > it reverted. If no, what results do you see with it applied? I agree that it would be better to fix the root cause; my suspicion was that the themed widgets on Mac simply don't support a background color, but I didn't investigate that any further. I was indeed not running with "git-gui: improve dark mode support" yet, but applying it didn't make a difference. I'm also happy to drop this if you are uncomfortable with it; it's easy enough to set gui.usettk to 0 to fix the problem locally. Best, Stefan