From: Taylor Blau <me@ttaylorr.com> To: git@vger.kernel.org Cc: peff@peff.net, dstolee@microsoft.com, gitster@pobox.com, jonathantanmy@google.com Subject: [PATCH v5 06/27] midx: fix `*.rev` cleanups with `--object-dir` Date: Tue, 31 Aug 2021 16:51:55 -0400 [thread overview] Message-ID: <0aacaa928395bdc041cc366a25047442ff7a33f1.1630443072.git.me@ttaylorr.com> (raw) In-Reply-To: <cover.1630443072.git.me@ttaylorr.com> If using --object-dir to point into an object directory which belongs to a different repository than the one in the current working directory, such as: git init repo git -C repo ... # add some objects cd alternate git multi-pack-index --object-dir ../repo/.git/objects write the binary will segfault trying to access the object-dir via the repo it found, but that's not fully initialized. Worse, if we later call clear_midx_files_ext(), we will use `the_repository` and remove files out of the wrong object directory. Fix this by using the given object_dir (or the object directory of `the_repository` if `--object-dir` wasn't given) to properly to clean up the *.rev files, avoiding the crash. Original-patch-by: Johannes Berg <johannes@sipsolutions.net> Signed-off-by: Taylor Blau <me@ttaylorr.com> --- midx.c | 10 +++++----- t/t5319-multi-pack-index.sh | 28 ++++++++++++++++++++++++++++ 2 files changed, 33 insertions(+), 5 deletions(-) diff --git a/midx.c b/midx.c index 321c6fdd2f..902e1a7a7d 100644 --- a/midx.c +++ b/midx.c @@ -882,7 +882,7 @@ static void write_midx_reverse_index(char *midx_name, unsigned char *midx_hash, strbuf_release(&buf); } -static void clear_midx_files_ext(struct repository *r, const char *ext, +static void clear_midx_files_ext(const char *object_dir, const char *ext, unsigned char *keep_hash); static int midx_checksum_valid(struct multi_pack_index *m) @@ -1086,7 +1086,7 @@ static int write_midx_internal(const char *object_dir, struct multi_pack_index * if (flags & MIDX_WRITE_REV_INDEX) write_midx_reverse_index(midx_name, midx_hash, &ctx); - clear_midx_files_ext(the_repository, ".rev", midx_hash); + clear_midx_files_ext(object_dir, ".rev", midx_hash); commit_lock_file(&lk); @@ -1135,7 +1135,7 @@ static void clear_midx_file_ext(const char *full_path, size_t full_path_len, die_errno(_("failed to remove %s"), full_path); } -static void clear_midx_files_ext(struct repository *r, const char *ext, +static void clear_midx_files_ext(const char *object_dir, const char *ext, unsigned char *keep_hash) { struct clear_midx_data data; @@ -1146,7 +1146,7 @@ static void clear_midx_files_ext(struct repository *r, const char *ext, hash_to_hex(keep_hash), ext); data.ext = ext; - for_each_file_in_pack_dir(r->objects->odb->path, + for_each_file_in_pack_dir(object_dir, clear_midx_file_ext, &data); @@ -1165,7 +1165,7 @@ void clear_midx_file(struct repository *r) if (remove_path(midx)) die(_("failed to clear multi-pack-index at %s"), midx); - clear_midx_files_ext(r, ".rev", NULL); + clear_midx_files_ext(r->objects->odb->path, ".rev", NULL); free(midx); } diff --git a/t/t5319-multi-pack-index.sh b/t/t5319-multi-pack-index.sh index 9034e94c0a..e953cdd6d1 100755 --- a/t/t5319-multi-pack-index.sh +++ b/t/t5319-multi-pack-index.sh @@ -201,6 +201,34 @@ test_expect_success 'write midx with twelve packs' ' compare_results_with_midx "twelve packs" +test_expect_success 'multi-pack-index *.rev cleanup with --object-dir' ' + git init repo && + git clone -s repo alternate && + + test_when_finished "rm -rf repo alternate" && + + ( + cd repo && + test_commit base && + git repack -d + ) && + + ours="alternate/.git/objects/pack/multi-pack-index-123.rev" && + theirs="repo/.git/objects/pack/multi-pack-index-abc.rev" && + touch "$ours" "$theirs" && + + ( + cd alternate && + git multi-pack-index --object-dir ../repo/.git/objects write + ) && + + # writing a midx in "repo" should not remove the .rev file in the + # alternate + test_path_is_file repo/.git/objects/pack/multi-pack-index && + test_path_is_file $ours && + test_path_is_missing $theirs +' + test_expect_success 'warn on improper hash version' ' git init --object-format=sha1 sha1 && ( -- 2.33.0.96.g73915697e6
next prev parent reply other threads:[~2021-08-31 20:52 UTC|newest] Thread overview: 273+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-09 18:10 [PATCH 00/22] multi-pack reachability bitmaps Taylor Blau 2021-04-09 18:10 ` [PATCH 01/22] pack-bitmap.c: harden 'test_bitmap_walk()' to check type bitmaps Taylor Blau 2021-04-09 18:10 ` [PATCH 02/22] pack-bitmap-write.c: gracefully fail to write non-closed bitmaps Taylor Blau 2021-04-16 2:46 ` Jonathan Tan 2021-04-09 18:10 ` [PATCH 03/22] pack-bitmap-write.c: free existing bitmaps Taylor Blau 2021-04-09 18:10 ` [PATCH 04/22] Documentation: build 'technical/bitmap-format' by default Taylor Blau 2021-04-09 18:11 ` [PATCH 05/22] Documentation: describe MIDX-based bitmaps Taylor Blau 2021-04-09 18:11 ` [PATCH 06/22] midx: make a number of functions non-static Taylor Blau 2021-04-09 18:11 ` [PATCH 07/22] midx: clear auxiliary .rev after replacing the MIDX Taylor Blau 2021-04-09 18:11 ` [PATCH 08/22] midx: respect 'core.multiPackIndex' when writing Taylor Blau 2021-04-09 18:11 ` [PATCH 09/22] pack-bitmap.c: introduce 'bitmap_num_objects()' Taylor Blau 2021-04-09 18:11 ` [PATCH 10/22] pack-bitmap.c: introduce 'nth_bitmap_object_oid()' Taylor Blau 2021-04-09 18:11 ` [PATCH 11/22] pack-bitmap.c: introduce 'bitmap_is_preferred_refname()' Taylor Blau 2021-04-09 18:11 ` [PATCH 12/22] pack-bitmap: read multi-pack bitmaps Taylor Blau 2021-04-16 2:39 ` Jonathan Tan 2021-04-16 3:13 ` Taylor Blau 2021-04-09 18:11 ` [PATCH 13/22] pack-bitmap: write " Taylor Blau 2021-05-04 5:02 ` Jonathan Tan 2021-05-06 20:18 ` Taylor Blau 2021-05-06 22:00 ` Jonathan Tan 2021-04-09 18:11 ` [PATCH 14/22] t5310: move some tests to lib-bitmap.sh Taylor Blau 2021-04-09 18:11 ` [PATCH 15/22] t/helper/test-read-midx.c: add --checksum mode Taylor Blau 2021-04-09 18:12 ` [PATCH 16/22] t5326: test multi-pack bitmap behavior Taylor Blau 2021-05-04 17:51 ` Jonathan Tan 2021-04-09 18:12 ` [PATCH 17/22] t5310: disable GIT_TEST_MULTI_PACK_INDEX_WRITE_BITMAP Taylor Blau 2021-04-09 18:12 ` [PATCH 18/22] t5319: don't write MIDX bitmaps in t5319 Taylor Blau 2021-04-09 18:12 ` [PATCH 19/22] t7700: update to work with MIDX bitmap test knob Taylor Blau 2021-04-09 18:12 ` [PATCH 20/22] midx: respect 'GIT_TEST_MULTI_PACK_INDEX_WRITE_BITMAP' Taylor Blau 2021-04-09 18:12 ` [PATCH 21/22] p5310: extract full and partial bitmap tests Taylor Blau 2021-04-09 18:12 ` [PATCH 22/22] p5326: perf tests for MIDX bitmaps Taylor Blau 2021-05-04 18:00 ` Jonathan Tan 2021-05-05 0:55 ` Junio C Hamano 2021-06-21 22:24 ` [PATCH v2 00/24] multi-pack reachability bitmaps Taylor Blau 2021-06-21 22:24 ` [PATCH v2 01/24] pack-bitmap.c: harden 'test_bitmap_walk()' to check type bitmaps Taylor Blau 2021-06-24 23:02 ` Ævar Arnfjörð Bjarmason 2021-07-14 17:24 ` Taylor Blau 2021-07-21 9:45 ` Jeff King 2021-07-21 17:15 ` Taylor Blau 2021-06-21 22:25 ` [PATCH v2 02/24] pack-bitmap-write.c: gracefully fail to write non-closed bitmaps Taylor Blau 2021-06-24 23:23 ` Ævar Arnfjörð Bjarmason 2021-07-14 17:32 ` Taylor Blau 2021-07-14 18:44 ` Ævar Arnfjörð Bjarmason 2021-07-21 9:53 ` Jeff King 2021-07-21 9:50 ` Jeff King 2021-07-21 17:20 ` Taylor Blau 2021-07-23 7:37 ` Jeff King 2021-07-26 18:48 ` Taylor Blau 2021-07-27 17:11 ` Jeff King 2021-06-21 22:25 ` [PATCH v2 03/24] pack-bitmap-write.c: free existing bitmaps Taylor Blau 2021-07-21 9:54 ` Jeff King 2021-06-21 22:25 ` [PATCH v2 04/24] Documentation: build 'technical/bitmap-format' by default Taylor Blau 2021-06-24 23:35 ` Ævar Arnfjörð Bjarmason 2021-07-14 17:41 ` Taylor Blau 2021-07-14 22:58 ` Ævar Arnfjörð Bjarmason 2021-07-21 10:04 ` Jeff King 2021-07-21 10:10 ` Jeff King 2021-07-21 9:58 ` Jeff King 2021-07-21 10:08 ` Jeff King 2021-07-21 17:23 ` Taylor Blau 2021-07-23 7:39 ` Jeff King 2021-07-26 18:49 ` Taylor Blau 2021-06-21 22:25 ` [PATCH v2 05/24] Documentation: describe MIDX-based bitmaps Taylor Blau 2021-07-21 10:18 ` Jeff King 2021-07-21 17:53 ` Taylor Blau 2021-07-23 7:45 ` Jeff King 2021-06-21 22:25 ` [PATCH v2 06/24] midx: make a number of functions non-static Taylor Blau 2021-06-24 23:42 ` Ævar Arnfjörð Bjarmason 2021-07-14 23:01 ` Taylor Blau 2021-06-21 22:25 ` [PATCH v2 07/24] midx: clear auxiliary .rev after replacing the MIDX Taylor Blau 2021-07-21 10:19 ` Jeff King 2021-06-21 22:25 ` [PATCH v2 08/24] midx: respect 'core.multiPackIndex' when writing Taylor Blau 2021-06-24 23:43 ` Ævar Arnfjörð Bjarmason 2021-07-21 10:23 ` Jeff King 2021-07-21 19:22 ` Taylor Blau 2021-07-23 8:29 ` Jeff King 2021-07-26 18:59 ` Taylor Blau 2021-07-26 22:14 ` Taylor Blau 2021-07-27 17:29 ` Jeff King 2021-07-27 17:36 ` Taylor Blau 2021-07-27 17:42 ` Jeff King 2021-07-27 17:47 ` Taylor Blau 2021-07-27 17:55 ` Jeff King 2021-07-27 20:05 ` Taylor Blau 2021-07-28 17:46 ` Jeff King 2021-07-29 19:44 ` Taylor Blau 2021-08-12 19:59 ` Jeff King 2021-07-27 17:17 ` Jeff King 2021-06-21 22:25 ` [PATCH v2 09/24] midx: infer preferred pack when not given one Taylor Blau 2021-07-21 10:34 ` Jeff King 2021-07-21 20:16 ` Taylor Blau 2021-07-23 8:50 ` Jeff King 2021-07-26 19:44 ` Taylor Blau 2021-06-21 22:25 ` [PATCH v2 10/24] pack-bitmap.c: introduce 'bitmap_num_objects()' Taylor Blau 2021-07-21 10:35 ` Jeff King 2021-06-21 22:25 ` [PATCH v2 11/24] pack-bitmap.c: introduce 'nth_bitmap_object_oid()' Taylor Blau 2021-06-24 14:59 ` Taylor Blau 2021-07-21 10:37 ` Jeff King 2021-07-21 10:38 ` Jeff King 2021-06-21 22:25 ` [PATCH v2 12/24] pack-bitmap.c: introduce 'bitmap_is_preferred_refname()' Taylor Blau 2021-07-21 10:39 ` Jeff King 2021-07-21 20:18 ` Taylor Blau 2021-06-21 22:25 ` [PATCH v2 13/24] pack-bitmap: read multi-pack bitmaps Taylor Blau 2021-07-21 11:32 ` Jeff King 2021-07-21 23:01 ` Taylor Blau 2021-07-23 9:40 ` Jeff King 2021-07-23 10:00 ` Jeff King 2021-07-26 20:36 ` Taylor Blau 2021-06-21 22:25 ` [PATCH v2 14/24] pack-bitmap: write " Taylor Blau 2021-06-24 23:45 ` Ævar Arnfjörð Bjarmason 2021-07-15 14:33 ` Taylor Blau 2021-07-21 12:09 ` Jeff King 2021-07-26 18:12 ` Taylor Blau 2021-07-26 18:23 ` Taylor Blau 2021-07-27 17:11 ` Jeff King 2021-07-27 20:33 ` Taylor Blau 2021-07-28 17:52 ` Jeff King 2021-07-29 19:33 ` Taylor Blau 2021-08-12 20:00 ` Jeff King 2021-06-21 22:25 ` [PATCH v2 15/24] t5310: move some tests to lib-bitmap.sh Taylor Blau 2021-06-21 22:25 ` [PATCH v2 16/24] t/helper/test-read-midx.c: add --checksum mode Taylor Blau 2021-06-21 22:25 ` [PATCH v2 17/24] t5326: test multi-pack bitmap behavior Taylor Blau 2021-06-21 22:25 ` [PATCH v2 18/24] t0410: disable GIT_TEST_MULTI_PACK_INDEX_WRITE_BITMAP Taylor Blau 2021-06-21 22:25 ` [PATCH v2 19/24] t5310: " Taylor Blau 2021-06-21 22:25 ` [PATCH v2 20/24] t5319: don't write MIDX bitmaps in t5319 Taylor Blau 2021-06-21 22:25 ` [PATCH v2 21/24] t7700: update to work with MIDX bitmap test knob Taylor Blau 2021-06-21 22:25 ` [PATCH v2 22/24] midx: respect 'GIT_TEST_MULTI_PACK_INDEX_WRITE_BITMAP' Taylor Blau 2021-06-25 0:03 ` Ævar Arnfjörð Bjarmason 2021-06-21 22:25 ` [PATCH v2 23/24] p5310: extract full and partial bitmap tests Taylor Blau 2021-06-21 22:26 ` [PATCH v2 24/24] p5326: perf tests for MIDX bitmaps Taylor Blau 2021-06-25 9:06 ` [PATCH v2 00/24] multi-pack reachability bitmaps Ævar Arnfjörð Bjarmason 2021-07-15 14:36 ` Taylor Blau 2021-07-21 12:12 ` Jeff King 2021-07-27 21:19 ` [PATCH v3 00/25] " Taylor Blau 2021-07-27 21:19 ` [PATCH v3 01/25] pack-bitmap.c: harden 'test_bitmap_walk()' to check type bitmaps Taylor Blau 2021-07-27 21:19 ` [PATCH v3 02/25] pack-bitmap-write.c: gracefully fail to write non-closed bitmaps Taylor Blau 2021-07-27 21:19 ` [PATCH v3 03/25] pack-bitmap-write.c: free existing bitmaps Taylor Blau 2021-07-27 21:19 ` [PATCH v3 04/25] Documentation: describe MIDX-based bitmaps Taylor Blau 2021-07-27 21:19 ` [PATCH v3 05/25] midx: clear auxiliary .rev after replacing the MIDX Taylor Blau 2021-07-27 21:19 ` [PATCH v3 06/25] midx: reject empty `--preferred-pack`'s Taylor Blau 2021-07-27 21:19 ` [PATCH v3 07/25] midx: infer preferred pack when not given one Taylor Blau 2021-07-27 21:19 ` [PATCH v3 08/25] midx: close linked MIDXs, avoid leaking memory Taylor Blau 2021-07-27 21:19 ` [PATCH v3 09/25] midx: avoid opening multiple MIDXs when writing Taylor Blau 2021-07-29 19:30 ` Taylor Blau 2021-08-12 20:15 ` Jeff King 2021-08-12 20:22 ` Jeff King 2021-08-12 21:20 ` Taylor Blau 2021-07-27 21:19 ` [PATCH v3 10/25] pack-bitmap.c: introduce 'bitmap_num_objects()' Taylor Blau 2021-07-27 21:19 ` [PATCH v3 11/25] pack-bitmap.c: introduce 'nth_bitmap_object_oid()' Taylor Blau 2021-07-27 21:19 ` [PATCH v3 12/25] pack-bitmap.c: introduce 'bitmap_is_preferred_refname()' Taylor Blau 2021-07-27 21:19 ` [PATCH v3 13/25] pack-bitmap.c: avoid redundant calls to try_partial_reuse Taylor Blau 2021-07-27 21:19 ` [PATCH v3 14/25] pack-bitmap: read multi-pack bitmaps Taylor Blau 2021-07-27 21:20 ` [PATCH v3 15/25] pack-bitmap: write " Taylor Blau 2021-07-27 21:20 ` [PATCH v3 16/25] t5310: move some tests to lib-bitmap.sh Taylor Blau 2021-08-12 20:25 ` Jeff King 2021-07-27 21:20 ` [PATCH v3 17/25] t/helper/test-read-midx.c: add --checksum mode Taylor Blau 2021-08-12 20:31 ` Jeff King 2021-08-12 21:31 ` Taylor Blau 2021-07-27 21:20 ` [PATCH v3 18/25] t5326: test multi-pack bitmap behavior Taylor Blau 2021-08-12 21:02 ` Jeff King 2021-08-12 21:07 ` Jeff King 2021-08-12 22:38 ` Taylor Blau 2021-08-12 23:23 ` Jeff King 2021-07-27 21:20 ` [PATCH v3 19/25] t0410: disable GIT_TEST_MULTI_PACK_INDEX_WRITE_BITMAP Taylor Blau 2021-07-27 21:20 ` [PATCH v3 20/25] t5310: " Taylor Blau 2021-07-27 21:20 ` [PATCH v3 21/25] t5319: don't write MIDX bitmaps in t5319 Taylor Blau 2021-07-27 21:20 ` [PATCH v3 22/25] t7700: update to work with MIDX bitmap test knob Taylor Blau 2021-07-27 21:20 ` [PATCH v3 23/25] midx: respect 'GIT_TEST_MULTI_PACK_INDEX_WRITE_BITMAP' Taylor Blau 2021-08-12 21:09 ` Jeff King 2021-07-27 21:20 ` [PATCH v3 24/25] p5310: extract full and partial bitmap tests Taylor Blau 2021-07-27 21:20 ` [PATCH v3 25/25] p5326: perf tests for MIDX bitmaps Taylor Blau 2021-08-12 21:18 ` Jeff King 2021-08-12 21:21 ` [PATCH v3 00/25] multi-pack reachability bitmaps Jeff King 2021-08-12 22:41 ` Taylor Blau 2021-08-24 16:15 ` [PATCH v4 " Taylor Blau 2021-08-24 16:15 ` [PATCH v4 01/25] pack-bitmap.c: harden 'test_bitmap_walk()' to check type bitmaps Taylor Blau 2021-08-24 16:15 ` [PATCH v4 02/25] pack-bitmap-write.c: gracefully fail to write non-closed bitmaps Taylor Blau 2021-08-24 16:15 ` [PATCH v4 03/25] pack-bitmap-write.c: free existing bitmaps Taylor Blau 2021-08-24 16:15 ` [PATCH v4 04/25] Documentation: describe MIDX-based bitmaps Taylor Blau 2021-08-24 16:16 ` [PATCH v4 05/25] midx: clear auxiliary .rev after replacing the MIDX Taylor Blau 2021-08-24 20:27 ` Junio C Hamano 2021-08-24 20:34 ` Taylor Blau 2021-08-24 21:12 ` Junio C Hamano 2021-08-24 21:24 ` Taylor Blau 2021-08-24 22:01 ` Taylor Blau 2021-08-24 22:04 ` Junio C Hamano 2021-08-24 22:06 ` Junio C Hamano 2021-08-24 22:10 ` Taylor Blau 2021-08-27 6:01 ` Junio C Hamano 2021-08-27 18:03 ` Taylor Blau 2021-08-29 22:56 ` Junio C Hamano 2021-08-30 0:07 ` Taylor Blau 2021-08-30 0:34 ` Junio C Hamano 2021-08-30 0:43 ` Taylor Blau 2021-08-30 22:10 ` brian m. carlson 2021-08-30 22:28 ` Junio C Hamano 2021-08-30 22:33 ` Taylor Blau 2021-08-31 5:19 ` Jeff King 2021-08-31 16:29 ` Junio C Hamano 2021-08-31 16:39 ` Taylor Blau 2021-08-31 17:44 ` Junio C Hamano 2021-08-31 18:48 ` Taylor Blau 2021-08-31 1:21 ` Derrick Stolee 2021-08-31 5:37 ` Jeff King 2021-08-31 16:33 ` Junio C Hamano 2021-08-31 16:43 ` Taylor Blau 2021-08-31 17:17 ` Derrick Stolee 2021-09-01 10:03 ` Jeff King 2021-08-24 16:16 ` [PATCH v4 06/25] midx: reject empty `--preferred-pack`'s Taylor Blau 2021-08-24 16:16 ` [PATCH v4 07/25] midx: infer preferred pack when not given one Taylor Blau 2021-08-24 16:16 ` [PATCH v4 08/25] midx: close linked MIDXs, avoid leaking memory Taylor Blau 2021-08-24 16:16 ` [PATCH v4 09/25] midx: avoid opening multiple MIDXs when writing Taylor Blau 2021-08-24 16:16 ` [PATCH v4 10/25] pack-bitmap.c: introduce 'bitmap_num_objects()' Taylor Blau 2021-08-24 16:16 ` [PATCH v4 11/25] pack-bitmap.c: introduce 'nth_bitmap_object_oid()' Taylor Blau 2021-08-24 16:16 ` [PATCH v4 12/25] pack-bitmap.c: introduce 'bitmap_is_preferred_refname()' Taylor Blau 2021-08-24 16:16 ` [PATCH v4 13/25] pack-bitmap.c: avoid redundant calls to try_partial_reuse Taylor Blau 2021-08-24 16:16 ` [PATCH v4 14/25] pack-bitmap: read multi-pack bitmaps Taylor Blau 2021-08-24 16:16 ` [PATCH v4 15/25] pack-bitmap: write " Taylor Blau 2021-08-24 16:16 ` [PATCH v4 16/25] t5310: move some tests to lib-bitmap.sh Taylor Blau 2021-08-24 16:16 ` [PATCH v4 17/25] t/helper/test-read-midx.c: add --checksum mode Taylor Blau 2021-08-24 16:16 ` [PATCH v4 18/25] t5326: test multi-pack bitmap behavior Taylor Blau 2021-08-24 16:16 ` [PATCH v4 19/25] t0410: disable GIT_TEST_MULTI_PACK_INDEX_WRITE_BITMAP Taylor Blau 2021-08-24 16:16 ` [PATCH v4 20/25] t5310: " Taylor Blau 2021-08-24 16:16 ` [PATCH v4 21/25] t5319: don't write MIDX bitmaps in t5319 Taylor Blau 2021-08-24 16:16 ` [PATCH v4 22/25] t7700: update to work with MIDX bitmap test knob Taylor Blau 2021-08-24 16:16 ` [PATCH v4 23/25] midx: respect 'GIT_TEST_MULTI_PACK_INDEX_WRITE_BITMAP' Taylor Blau 2021-08-24 16:16 ` [PATCH v4 24/25] p5310: extract full and partial bitmap tests Taylor Blau 2021-08-24 16:16 ` [PATCH v4 25/25] p5326: perf tests for MIDX bitmaps Taylor Blau 2021-08-25 0:28 ` [PATCH v4 00/25] multi-pack reachability bitmaps Jeff King 2021-08-25 2:10 ` Taylor Blau 2021-08-25 2:13 ` Taylor Blau 2021-08-25 7:36 ` Jeff King 2021-08-25 7:48 ` Johannes Berg 2021-08-26 18:49 ` Taylor Blau 2021-08-26 21:22 ` Taylor Blau 2021-08-27 21:30 ` Jeff King 2021-08-29 22:42 ` Junio C Hamano 2021-08-31 20:51 ` [PATCH v5 00/27] " Taylor Blau 2021-08-31 20:51 ` [PATCH v5 01/27] pack-bitmap.c: harden 'test_bitmap_walk()' to check type bitmaps Taylor Blau 2021-08-31 20:51 ` [PATCH v5 02/27] pack-bitmap-write.c: gracefully fail to write non-closed bitmaps Taylor Blau 2021-08-31 20:51 ` [PATCH v5 03/27] pack-bitmap-write.c: free existing bitmaps Taylor Blau 2021-08-31 20:51 ` [PATCH v5 04/27] Documentation: describe MIDX-based bitmaps Taylor Blau 2021-08-31 20:51 ` [PATCH v5 05/27] midx: disallow running outside of a repository Taylor Blau 2021-08-31 20:51 ` Taylor Blau [this message] 2021-08-31 20:51 ` [PATCH v5 07/27] midx: clear auxiliary .rev after replacing the MIDX Taylor Blau 2021-08-31 20:52 ` [PATCH v5 08/27] midx: reject empty `--preferred-pack`'s Taylor Blau 2021-08-31 20:52 ` [PATCH v5 09/27] midx: infer preferred pack when not given one Taylor Blau 2021-08-31 20:52 ` [PATCH v5 10/27] midx: close linked MIDXs, avoid leaking memory Taylor Blau 2021-08-31 20:52 ` [PATCH v5 11/27] midx: avoid opening multiple MIDXs when writing Taylor Blau 2021-08-31 20:52 ` [PATCH v5 12/27] pack-bitmap.c: introduce 'bitmap_num_objects()' Taylor Blau 2021-08-31 20:52 ` [PATCH v5 13/27] pack-bitmap.c: introduce 'nth_bitmap_object_oid()' Taylor Blau 2021-08-31 20:52 ` [PATCH v5 14/27] pack-bitmap.c: introduce 'bitmap_is_preferred_refname()' Taylor Blau 2021-08-31 20:52 ` [PATCH v5 15/27] pack-bitmap.c: avoid redundant calls to try_partial_reuse Taylor Blau 2021-08-31 20:52 ` [PATCH v5 16/27] pack-bitmap: read multi-pack bitmaps Taylor Blau 2021-08-31 20:52 ` [PATCH v5 17/27] pack-bitmap: write " Taylor Blau 2021-08-31 20:52 ` [PATCH v5 18/27] t5310: move some tests to lib-bitmap.sh Taylor Blau 2021-08-31 20:52 ` [PATCH v5 19/27] t/helper/test-read-midx.c: add --checksum mode Taylor Blau 2021-08-31 20:52 ` [PATCH v5 20/27] t5326: test multi-pack bitmap behavior Taylor Blau 2021-08-31 20:52 ` [PATCH v5 21/27] t0410: disable GIT_TEST_MULTI_PACK_INDEX_WRITE_BITMAP Taylor Blau 2021-08-31 20:52 ` [PATCH v5 22/27] t5310: " Taylor Blau 2021-08-31 20:52 ` [PATCH v5 23/27] t5319: don't write MIDX bitmaps in t5319 Taylor Blau 2021-08-31 20:52 ` [PATCH v5 24/27] t7700: update to work with MIDX bitmap test knob Taylor Blau 2021-08-31 20:52 ` [PATCH v5 25/27] midx: respect 'GIT_TEST_MULTI_PACK_INDEX_WRITE_BITMAP' Taylor Blau 2021-08-31 20:52 ` [PATCH v5 26/27] p5310: extract full and partial bitmap tests Taylor Blau 2021-08-31 20:52 ` [PATCH v5 27/27] p5326: perf tests for MIDX bitmaps Taylor Blau 2021-09-01 18:07 ` [PATCH v5 00/27] multi-pack reachability bitmaps Junio C Hamano 2021-09-01 19:08 ` Taylor Blau 2021-09-01 19:23 ` Junio C Hamano 2021-09-01 20:34 ` Taylor Blau 2021-09-01 20:49 ` Junio C Hamano 2021-09-01 20:54 ` Taylor Blau 2021-09-02 9:40 ` Jeff King 2021-09-02 9:38 ` Jeff King 2021-09-02 9:45 ` Jeff King
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0aacaa928395bdc041cc366a25047442ff7a33f1.1630443072.git.me@ttaylorr.com \ --to=me@ttaylorr.com \ --cc=dstolee@microsoft.com \ --cc=git@vger.kernel.org \ --cc=gitster@pobox.com \ --cc=jonathantanmy@google.com \ --cc=peff@peff.net \ --subject='Re: [PATCH v5 06/27] midx: fix `*.rev` cleanups with `--object-dir`' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).