From: Derrick Stolee <stolee@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>, git@vger.kernel.org
Cc: Jonathan Tan <jonathantanmy@google.com>,
Jeff King <peff@peff.net>,
Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH 0/5] Enable protocol v2 by default
Date: Thu, 26 Dec 2019 09:30:47 -0500 [thread overview]
Message-ID: <0a4f064b-8260-1662-2ead-b2e2c930d706@gmail.com> (raw)
In-Reply-To: <20191224005816.GC38316@google.com>
On 12/23/2019 7:58 PM, Jonathan Nieder wrote:
> Hi,
>
> The Git users at $DAYJOB have been using protocol v2 as a default for
> ~1.5 years now and others have been also reporting good experiences
> with it, so it seems like a good time to propose bumping the default
> version. It produces a significant performance improvement when
> fetching from repositories with many refs, such as
> https://chromium.googlesource.com/chromium/src.
The benefits of protocol v2 are very clear, assuming the server
supports it. And I'm pretty sure there is no downside, as a v0
server continues responding to the v2 request without any extra
round trips to agree on protocol.
> This only affects the client, not the server. (The server already
> defaults to supporting protocol v2.)
>
> This could go in 2.25 (most of the "next" population is likely already
> using protocol.version=2, so the -rc period would be one of the better
> ways to expand the user population using this) or could cook in "next"
> for a cycle. Either is fine by me.
I have no firm opinion on when this lands. The code change is much simpler
than I would have thought, and perhaps we had enough testing of the protocol
by experts.
This series looks good to me.
Thanks,
-Stolee
prev parent reply other threads:[~2019-12-26 14:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-24 0:58 [PATCH 0/5] Enable protocol v2 by default Jonathan Nieder
2019-12-24 0:59 ` [PATCH 1/5] fetch test: use more robust test for filtered objects Jonathan Nieder
2019-12-26 14:29 ` Derrick Stolee
2019-12-24 1:00 ` [PATCH 2/5] config doc: protocol.version is not experimental Jonathan Nieder
2019-12-24 1:01 ` [PATCH 3/5] test: request GIT_TEST_PROTOCOL_VERSION=0 when appropriate Jonathan Nieder
2019-12-26 19:26 ` Junio C Hamano
2019-12-26 19:53 ` [PATCH 0/2] avoid use of "VAR= cmd" with a shell function (Re: [PATCH 3/5] test: request GIT_TEST_PROTOCOL_VERSION=0 when appropriate) Jonathan Nieder
2019-12-26 19:55 ` [PATCH 1/2] fetch test: avoid use of "VAR= cmd" with a shell function Jonathan Nieder
2019-12-26 19:57 ` [PATCH 2/2] t/check-non-portable-shell: detect "FOO= shell_func", too Jonathan Nieder
2019-12-26 20:08 ` Junio C Hamano
2019-12-26 20:18 ` Junio C Hamano
2019-12-26 22:37 ` Jonathan Nieder
2019-12-26 23:12 ` [PATCH jn/test-lint-one-shot-export-to-shell-function] fetch test: mark test of "skipping" haves as v0-only Jonathan Nieder
2019-12-26 20:39 ` [PATCH 2/2] t/check-non-portable-shell: detect "FOO= shell_func", too Eric Sunshine
2019-12-24 1:02 ` [PATCH 4/5] protocol test: let protocol.version override GIT_TEST_PROTOCOL_VERSION Jonathan Nieder
2019-12-24 1:04 ` [PATCH 5/5] fetch: default to protocol version 2 Jonathan Nieder
2019-12-26 14:30 ` Derrick Stolee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a4f064b-8260-1662-2ead-b2e2c930d706@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=jeffhost@microsoft.com \
--cc=jonathantanmy@google.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).