From: Stefan Tauner <stefan.tauner@gmx.at>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: Un-paged commit messages in git filter-branch's commit-filter?
Date: Sun, 31 Jul 2016 18:39:35 +0200 [thread overview]
Message-ID: <0MTjMy-1buKad2Fg8-00QUQV@mail.gmx.com> (raw)
In-Reply-To: <20160616095947.GA15988@sigill.intra.peff.net>
On Thu, 16 Jun 2016 05:59:47 -0400
Jeff King <peff@peff.net> wrote:
> On Mon, Jun 13, 2016 at 08:28:18AM +0200, Stefan Tauner wrote:
>
> > I am trying to do a major cleanup of the repository in one of my
> > projects (and switch from git-svn to native git). I have developed a
> > commit-filter script over the last months that massages partially
> > dreadful commit messages into something acceptable. While I am not 100%
> > sure I think that upgrading git has broken it partially. AFAICT since
> > the update the commit-filter does not get the original message anymore
> > but at least the subject/first paragraph is run through a pager or
> > something similar:
> > The first line is broken into multiple lines (i.e. some line breaks are
> > inserted about every 72 characters where none have been before).
>
> There are some output formats that will wrap lines, but by default,
> filter-branch should not be using them (and I could not reproduce the
> issue in a simple test). Can you show us what your commit-filter looks
> like?
Thanks for your answer. I have tried to reproduce it in other (newly
created) repositories but failed. However, it seems to relate to some
kind of persistent paging setting, is that possible?
git config -l does not show anything suspicious.
The following commands produce paged output:
git show hash
git show --pretty=%B
git log hash^..hash
Commit message in gitk
These do NOT produce paged output:
git patch hash^..hash
Commit message in gitg 0.2.7
This is the script I tried to use to reproduce the problem:
#!/bin/bash
export LC_ALL=C
input=$(cat)
echo "===========================
$input
===========================" >> /tmp/paging_bug.txt
git commit-tree "$@" -m "$input"
--
Kind regards/Mit freundlichen Grüßen, Stefan Tauner
next prev parent reply other threads:[~2016-07-31 16:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 6:28 Un-paged commit messages in git filter-branch's commit-filter? Stefan Tauner
2016-06-16 9:59 ` Jeff King
2016-07-31 16:39 ` Stefan Tauner [this message]
2016-08-01 21:36 ` Jeff King
2016-08-01 21:49 ` Stefan Tauner
2016-08-01 23:24 ` Jeff King
2016-08-02 0:07 ` Eric Wong
2016-08-06 9:40 ` Stefan Tauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0MTjMy-1buKad2Fg8-00QUQV@mail.gmx.com \
--to=stefan.tauner@gmx.at \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).