From: "Philip Oakley" <philipoakley@iee.org>
To: "Kaartic Sivaraam" <kaarticsivaraam91196@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>
Cc: <git@vger.kernel.org>, <sandals@crustytoothpaste.net>
Subject: Re: [PATCH] wt-status.c: Modified status message shown for a parent-less branch
Date: Sat, 10 Jun 2017 15:44:08 +0100 [thread overview]
Message-ID: <0E6CC91ED74848B78F9A2DFC7DF48AE5@PhilipOakley> (raw)
In-Reply-To: 1497084241.8531.2.camel@gmail.com
From: "Kaartic Sivaraam" <kaarticsivaraam91196@gmail.com>
> On Sat, 2017-06-10 at 11:23 +0900, Junio C Hamano wrote:
>> $ git shortlog -20 --no-merges
>>
>> may help learning the preferred style of writing the title. We do
>> not say "[I] did this". Instead we phrase things in imperative
>> mood, giving an order to the codebase to "become like so". E.g.
> This style is a little new to me thus my commit message turned out to
> be a repercussion of my own style (which, I guess, targets other
> developers who read the log). Will be careful the next time :). Made
> the requested changes except for a few doubts they raised (see comments
> below).
>
>> And it wasn't just "a little" confusing.
>>
>> "git status" indicated "Initial commit" when HEAD points at
>> an unborn branch. This message is shared with the commit
>> log template "git commit" prepares for the user when
>> creating a commit (i.e. "You are about to create the initial
>> commit"),
> I didn't get that, where should I be seeing the line, "You are about to
> create the initial commit" in the commit template ? I just saw "Initial
> commit" in it.
>
>> Does this break "git commit", or is the update limited to "git
>> status"?
> This does seem to be breaking 'git commit' as it seems to be using the
> output of 'git status'. This change results in the following commit
> template for the initial commit,
>
> # Please enter the commit message for your changes. Lines starting
> # with '#' will be ignored, and an empty message aborts the commit.
> # On branch master
> #
> # Waiting for initial commit
To me this sounds perfectly natural. It is the current status. The line will
be ignored by the commit message anyway unless the user edits the start of
the line.
At most it is a feeling that maybe we should provide an imperative
statement, but even then, it's still stating the obvious (which is normally
a bad thing). If the user is adding a .gitignore file then the commit
message should say so, etc. Maybe the "Initial commit" is meant to be the
default (by convention) separator, or its just a convention we've become
used to.
> #
> # Changes to be committed:
> # new file: test-file
> #
>
> Looks odd. Not sure how to fix this. Maybe on of the alternatives have
> to be considered. "Your current branch does not have any commits" seems
> a good one.
>
> --
> Regards,
> Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
--
Philip
prev parent reply other threads:[~2017-06-10 14:44 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-10 1:52 [PATCH] wt-status.c: Modified status message shown for a parent-less branch Kaartic Sivaraam
2017-06-10 2:10 ` Kaartic Sivaraam
2017-06-10 2:23 ` Junio C Hamano
2017-06-10 8:44 ` Kaartic Sivaraam
2017-06-10 9:36 ` Kaartic Sivaraam
2017-06-10 10:21 ` Jeff King
2017-06-10 11:02 ` Junio C Hamano
2017-06-12 8:10 ` Kaartic Sivaraam
2017-06-12 18:28 ` Junio C Hamano
2017-06-12 21:20 ` Jeff King
2017-06-12 21:31 ` Junio C Hamano
2017-06-12 21:37 ` Jeff King
2017-06-15 8:19 ` Kaartic Sivaraam
2017-06-15 8:42 ` Jeff King
2017-06-15 11:43 ` Samuel Lijin
2017-06-15 13:12 ` Jeff King
2017-06-16 10:36 ` Kaartic Sivaraam
2017-06-16 10:50 ` Jeff King
2017-06-18 7:35 ` [PATCH/Almost final] " Kaartic Sivaraam
2017-06-18 7:53 ` [PATCH/ALMOST FINAL] Contextually notify user about an initial commit Kaartic Sivaraam
2017-06-18 8:34 ` Ævar Arnfjörð Bjarmason
2017-06-19 2:41 ` [PATCH 1/2] " Kaartic Sivaraam
2017-06-19 2:44 ` [PATCH 2/2] Add test for the new status message Kaartic Sivaraam
2017-06-19 4:32 ` Junio C Hamano
2017-06-19 17:59 ` Kaartic Sivaraam
2017-06-19 18:04 ` Jeff King
2017-06-19 18:33 ` Kaartic Sivaraam
2017-06-19 4:29 ` [PATCH 1/2] Contextually notify user about an initial commit Junio C Hamano
2017-06-19 2:41 ` [PATCH 2/2] Add test for the new status message Kaartic Sivaraam
2017-06-19 9:10 ` [PATCH/ALMOST FINAL] Contextually notify user about an initial commit Jeff King
2017-06-19 13:24 ` Kaartic Sivaraam
2017-06-19 15:47 ` Junio C Hamano
2017-06-20 3:02 ` [PATCH 1/3] " Kaartic Sivaraam
2017-06-20 3:02 ` [PATCH 2/3] Update test(s) that used old status message Kaartic Sivaraam
2017-06-20 3:02 ` [PATCH 3/3] Add tests for the contextual initial " Kaartic Sivaraam
2017-06-20 7:26 ` [PATCH 1/3] Contextually notify user about an initial commit Ævar Arnfjörð Bjarmason
2017-06-20 13:37 ` Kaartic Sivaraam
2017-06-20 14:41 ` Ævar Arnfjörð Bjarmason
2017-06-21 2:34 ` Kaartic Sivaraam
2017-06-21 2:37 ` [PATCH/FINAL] status: contextually " Kaartic Sivaraam
2017-06-21 14:35 ` Kaartic Sivaraam
2017-06-21 14:52 ` Ævar Arnfjörð Bjarmason
2017-06-21 17:45 ` Kaartic Sivaraam
2017-06-21 18:45 ` Junio C Hamano
2017-06-21 18:16 ` Kaartic Sivaraam
2017-06-22 2:10 ` Junio C Hamano
2017-06-22 3:01 ` Kaartic Sivaraam
2017-06-10 14:44 ` Philip Oakley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0E6CC91ED74848B78F9A2DFC7DF48AE5@PhilipOakley \
--to=philipoakley@iee.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kaarticsivaraam91196@gmail.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).