On Oct 16, 2007, at 4:53 PM, Johannes Sixt wrote: > Benoit Sigoure schrieb: >> * git-svn.perl (&traverse_ignore): Remove. >> (&prop_walk): New. >> (&cmd_show_ignore): Use prop_walk. > > This may be your favorite style of commit messaged, but I think the > concensus for git is a different style of commit message: We would > like to see *why* this change is good. But you only note *what* was > changed, something that can be seen by looking at the patch anyway. > > The commit message should be helpful when the commit is looked at > in isolation, like when you are doing some code archeology half a > year later and e.g. git-blame/git-bisect points you to this commit. > > Also a notice such as > > "With this we will be able to lift properties like svn:ignore into > .gitignore in a follow-up change." > > tells that this was actually part of a series and you don't have to > remember that half a year ago there were 4 more patches submitted > in the same second with this one. Indeed, sorry, I'll write more explanatory commit messages next time :) -- Benoit Sigoure aka Tsuna EPITA Research and Development Laboratory