From: "Zoli Szabó" <zoli.szabo@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Pratyush Yadav <me@yadavpratyush.com>, git@vger.kernel.org
Subject: Re: Re: [PATCH 1/1] git-gui: add possibility to open currently selected file
Date: Mon, 30 Dec 2019 18:13:33 +0200 [thread overview]
Message-ID: <090d6c63-ccc0-e83b-3673-1bbe29c5991c@gmail.com> (raw)
In-Reply-To: <xmqqh81iiv18.fsf@gitster-ct.c.googlers.com>
Adapted the commit message once again (PATCH v3).
On 2019.12.30 01:14, Junio C Hamano wrote:
> Zoli Szabó <zoli.szabo@gmail.com> writes:
>
>> On 2019.12.28 00:32, Junio C Hamano wrote:
>>
>>> The phrasing on the title is a bit awkward. "add possibility to do
>>> X" is better spelled "allow doing X", no?
>>
>> Thank you, Junio, for the hint. Updated the commit message accordingly
>> (PATCH v2).
>
> Also, do not start the body of the proposed log message with half
> sentence. The title is supposed to be a full sentence.
>
>
>
next prev parent reply other threads:[~2019-12-30 16:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-26 19:01 [PATCH 0/1] git-gui: add possibility to open currently selected file Zoli Szabó via GitGitGadget
2019-12-26 19:01 ` [PATCH 1/1] " Zoli Szabó via GitGitGadget
2019-12-27 19:34 ` Pratyush Yadav
2019-12-27 22:32 ` Junio C Hamano
2019-12-29 20:15 ` Zoli Szabó
2019-12-29 23:14 ` Junio C Hamano
2019-12-30 16:13 ` Zoli Szabó [this message]
2019-12-29 13:23 ` Zoli Szabó
2019-12-29 19:32 ` [PATCH v2 0/1] git-gui: allow opening " Zoli Szabó via GitGitGadget
2019-12-29 19:32 ` [PATCH v2 1/1] " Zoli Szabó via GitGitGadget
2019-12-30 15:56 ` [PATCH v3 0/1] " Zoli Szabó via GitGitGadget
2019-12-30 15:56 ` [PATCH v3 1/1] git-gui: allow opening currently selected file in default app Zoli Szabó via GitGitGadget
2019-12-30 19:41 ` Pratyush Yadav
2019-12-30 20:31 ` Zoli Szabó
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=090d6c63-ccc0-e83b-3673-1bbe29c5991c@gmail.com \
--to=zoli.szabo@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@yadavpratyush.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).