From: Johannes Sixt <j6t@kdbg.org>
To: Zach Riggle <zachriggle@gmail.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: git grep --show-function treats GOTO labels as function names
Date: Thu, 28 May 2020 21:01:25 +0200 [thread overview]
Message-ID: <07f56d7a-45cc-2d28-ec48-51b95015550e@kdbg.org> (raw)
In-Reply-To: <20200527231628.GC546534@coredump.intra.peff.net>
Am 28.05.20 um 01:16 schrieb Jeff King:
> On Wed, May 27, 2020 at 06:04:21PM -0500, Zach Riggle wrote:
>> It looks like that does the trick for "goto" labels, but there are
>> also some issue on function name parsing with attributes when they are
>> split onto a second line.
>>
>> $ cat attr.cpp
>> int main() __attribute__ ( (no_sanitize("alignment")) )
>> {
>> FOO
>> }
>> $ git grep --no-index --show-function -e FOO attr.cpp
>> attr.cpp=2=__attribute__ ( (no_sanitize("alignment")) )
>> attr.cpp:4: FOO
>
> From your output, I assume the problematic input actually splits the
> attribute onto the second line?
>
> I agree that's not ideal. The baked-in regex we use for matching C
> function lines is:
>
> $ git grep -nA4 cpp userdiff.c
> userdiff.c:173:PATTERNS("cpp",
> userdiff.c-174- /* Jump targets or access declarations */
> userdiff.c-175- "!^[ \t]*[A-Za-z_][A-Za-z_0-9]*:[[:space:]]*($|/[/*])\n"
> userdiff.c-176- /* functions/methods, variables, and compounds at top level */
> userdiff.c-177- "^((::[[:space:]]*)?[A-Za-z_].*)$",
>
> so we mistake it for a function name. I'm not sure how easy it is to do
> better, though. We can add a line like:
C and C++ have a very versatile syntax and it turned out to be virtually
impossible to capture actual function definitions with a regex. See
8a2e8da367f7 ("userdiff: have 'cpp' hunk header pattern catch more C++
anchor points", 2014-03-21) for details.
With the current pattern, we catch probably 95% of the coding patterns
and coding styles. The style under discussion falls into the remaining
5% because continuation lines are not indented.
-- Hannes
prev parent reply other threads:[~2020-05-28 19:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 22:29 git grep --show-function treats GOTO labels as function names Zach Riggle
2020-05-27 22:48 ` Jeff King
2020-05-27 22:54 ` Zach Riggle
2020-05-27 23:04 ` Zach Riggle
2020-05-27 23:05 ` Zach Riggle
2020-05-27 23:16 ` Jeff King
2020-05-28 19:01 ` Johannes Sixt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07f56d7a-45cc-2d28-ec48-51b95015550e@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=zachriggle@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).