From: "René Scharfe" <l.s.r@web.de>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 3/5] environ: GIT_FLUSH should be made a usual Boolean
Date: Wed, 4 Jan 2023 17:36:11 +0100 [thread overview]
Message-ID: <07b8e696-2736-142e-1937-7e60636de5f4@web.de> (raw)
In-Reply-To: <Y7Ury+2n77XBzNl+@coredump.intra.peff.net>
Am 04.01.23 um 08:33 schrieb Jeff King:
> On Tue, Jan 03, 2023 at 06:18:32PM +0100, René Scharfe wrote:
>
>> before with this patch
>> ---------------------- ----------------------- -----------------------
>> (unset) if stdin is not a file if stdin is not a file
>> GIT_FLUSH= no no
>> GIT_FLUSH=0 no no
>> GIT_FLUSH=1 yes yes
>> GIT_FLUSH=false no no
>> GIT_FLUSH=true no yes
>> GIT_FLUSH=bogus no if stdin is not a file
>> GIT_FLUSH=10000000000 yes if stdin is not a file
>
> These last two are unlike most of our other boolean variables, where we
> complain about bad values:
>
> $ GIT_TEST_ASSUME_DIFFERENT_OWNER=bogus git rev-parse
> fatal: bad boolean config value 'bogus' for 'GIT_TEST_ASSUME_DIFFERENT_OWNER'
>
> $ GIT_LITERAL_PATHSPECS=10000000000 git rev-list HEAD -- foo
> fatal: bad boolean config value '10000000000' for 'GIT_LITERAL_PATHSPECS'
>
>> This implementation ignores invalid values, and doesn't even report
>> them, as before. If we want to do that then we need to stop parsing
>> the variable lazily, in order to report errors before the first
>> output is written -- in maybe_flush_or_die() it's too late.
>
> Why is it too late then? If we're going to do a hard die() anyway (as
> above), whether it happens after a bit of output or not doesn't seem
> like that big a deal.
That's just sloppy for no good reason. And the output could be quite
long and might be shown after the error message.
I can kinda understand that if the user gives us a bogus value we might
feel justified to mockingly serve them normally for a moment and only
then kick them out for violating our rules. That's not how I would want
Git to behave, though -- too human.
> And if we never flush and look at the variable,
> and the user "gets away" with a bogus value, nothing is harmed. That's
> how existing variables work (e.g., try removing the pathspec from the
> rev-list invocation above).
I don't mind this part.
> If that behavior is OK, then we could just use git_env_bool() here
> (though the patch size isn't much different; as you noted, most of the
> change comes from flipping the variable).
The current behavior with atoi() is also to not report any errors. If
that is OK then we can continue to do so.. ;)
But this leaves the possibility that someone sets GIT_FLUSH=absolutely,
loses data due to lack of flushing and is dissatisfied with the lack of
parse errors.
René
next prev parent reply other threads:[~2023-01-04 16:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 1:46 BUG: Value for GIT_SSL_NO_VERIFY has no effect Brijesh Patel
2022-09-15 13:04 ` brian m. carlson
2022-09-15 15:27 ` Junio C Hamano
2022-09-15 16:06 ` [PATCH 0/5] Update docs on GIT_* environment variables Junio C Hamano
2022-09-15 16:06 ` [PATCH 1/5] environ: document GIT_SSL_NO_VERIFY Junio C Hamano
2022-09-15 16:06 ` [PATCH 2/5] environ: explain Boolean environment variables Junio C Hamano
2022-09-15 16:06 ` [PATCH 3/5] environ: GIT_FLUSH should be made a usual Boolean Junio C Hamano
2023-01-03 17:18 ` René Scharfe
2023-01-04 6:37 ` Junio C Hamano
2023-01-04 16:36 ` René Scharfe
2023-01-04 7:33 ` Jeff King
2023-01-04 16:36 ` René Scharfe [this message]
2023-01-06 9:10 ` Jeff King
2022-09-15 16:06 ` [PATCH 4/5] environ: simplify description of GIT_INDEX_FILE Junio C Hamano
2022-09-16 15:39 ` Todd Zullinger
2022-09-16 16:44 ` Junio C Hamano
2022-09-15 16:06 ` [PATCH 5/5] environ: GIT_INDEX_VERSION affects not just a new repository Junio C Hamano
2022-09-15 16:15 ` BUG: Value for GIT_SSL_NO_VERIFY has no effect brian m. carlson
2022-09-15 18:05 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07b8e696-2736-142e-1937-7e60636de5f4@web.de \
--to=l.s.r@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).