From: Andrey Portnoy <aportnoy@ucsd.edu>
To: unlisted-recipients:; (no To-header on input)
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/1] banned.h: fix vsprintf warning
Date: Mon, 26 Aug 2019 13:08:16 -0700 [thread overview]
Message-ID: <0766F8E0-9A36-4304-A99D-35CC65063F3A@ucsd.edu> (raw)
In-Reply-To: <20190826183317.GB23399@sigill.intra.peff.net>
> On Aug 26, 2019, at 11:33 AM, Jeff King <peff@peff.net> wrote:
>
> On Mon, Aug 26, 2019 at 09:24:10AM -0700, Junio C Hamano wrote:
>
>> "Andrey Portnoy via GitGitGadget" <gitgitgadget@gmail.com> writes:
>>
>>> Previously sprintf was the argument to the BANNED macro, where vsprintf is
>>> expected.
>>
>> Good eyes. Thanks.
>
> There's an identical patch in:
>
> https://public-inbox.org/git/cab687db8315dd4245e1703402a8c76218ee1115.1566762128.git.me@ttaylorr.com/
>
> and both were inspired by:
>
> https://news.ycombinator.com/item?id=20793298
Nope, mine was not “inspired by” that comment, noticed the bug myself. I did look at this header because it was posted on HN, though.
>
> whose author has little info there, but I think is separate from either
> submitter.
>
> I don't know if we want to try to spread credit around via trailers.
> "Racily-implemented-by:" ? :)
>
> Anyway, the original bug is mine and the patch is obviously correct.
>
> -Peff
>
prev parent reply other threads:[~2019-08-26 20:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 15:21 [PATCH 0/1] banned.h: fix vsprintf warning Andrey Portnoy via GitGitGadget
2019-08-26 15:21 ` [PATCH 1/1] " Andrey Portnoy via GitGitGadget
2019-08-26 16:24 ` [PATCH 0/1] " Junio C Hamano
2019-08-26 18:33 ` Jeff King
2019-08-26 18:40 ` Taylor Blau
2019-08-27 19:46 ` Junio C Hamano
2019-08-26 19:06 ` Andrey Portnoy
2019-08-26 20:08 ` Andrey Portnoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0766F8E0-9A36-4304-A99D-35CC65063F3A@ucsd.edu \
--to=aportnoy@ucsd.edu \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).