From: Johannes Sixt <j6t@kdbg.org>
To: Jeff King <peff@peff.net>, "Randall S. Becker" <rsbecker@nexbridge.com>
Cc: 'Junio C Hamano' <gitster@pobox.com>,
git@vger.kernel.org,
'Linux Kernel' <linux-kernel@vger.kernel.org>,
git-packagers@googlegroups.com
Subject: Re: [Breakage] Git v2.21.0-rc0 - t5318 (NonStop)
Date: Fri, 8 Feb 2019 19:29:33 +0100 [thread overview]
Message-ID: <0694f2f1-040a-1d8c-cd01-2cf51cdbe426@kdbg.org> (raw)
In-Reply-To: <20190208180321.GB27673@sigill.intra.peff.net>
Am 08.02.19 um 19:03 schrieb Jeff King:
> On Fri, Feb 08, 2019 at 12:49:59PM -0500, Randall S. Becker wrote:
>> Would you object to something like this:
>>
>> if [ ! -e /dev/zero ]; then
>> # use shred or some other mechanism (still trying to figure out a solution)
>> else
>> # existing dd
>> fi
>
> That's fine, as long as it's wrapped up in a function in order to keep
> the tests readable.
>
> Though I suspect we may be able to just find a solution that works
> everywhere, without having two different implementations. If we know we
> need $count bytes for dd, we could probably just generate a file with
> that many NULs in it.
>
> Other cases don't seem to actually care that they're getting NULs, and
> are just redirecting stdin from /dev/zero to get an infinite amount of
> input. They could probably use "yes" for that.
If the data does not have to be a sequence of zero bytes, the
alternatives are:
* `test-genrandom seed-string $size` for a sequence of reproducible
"random" bytes
* `printf "%0*d" $size 0` for a sequence of '0' characters.
In t5318, the zero bytes do matter, though.
-- Hannes
next prev parent reply other threads:[~2019-02-08 18:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 11:08 [Breakage] Git v2.21.0-rc0 - t5318 (NonStop) Randall S. Becker
2019-02-08 16:50 ` Jeff King
2019-02-08 17:49 ` Randall S. Becker
2019-02-08 18:03 ` Jeff King
2019-02-08 18:29 ` Johannes Sixt [this message]
2019-02-08 19:31 ` Junio C Hamano
2019-02-08 18:47 ` Randall S. Becker
2019-02-08 19:15 ` Jeff King
2019-02-08 19:26 ` Randall S. Becker
2019-02-08 19:31 ` Jeff King
2019-02-08 20:38 ` Randall S. Becker
2019-02-08 21:00 ` Jeff King
2019-02-08 21:44 ` Randall S. Becker
2019-02-08 22:07 ` brian m. carlson
2019-02-08 22:12 ` Randall S. Becker
2019-02-08 22:18 ` brian m. carlson
2019-02-08 22:36 ` Randall S. Becker
2019-02-08 22:35 ` Jeff King
2019-02-08 22:53 ` Randall S. Becker
2019-02-09 4:24 ` Jeff King
2019-02-09 8:39 ` Johannes Sixt
2019-02-09 16:55 ` Randall S. Becker
2019-02-09 23:29 ` Jeff King
2019-02-10 9:40 ` Johannes Sixt
2019-02-09 16:53 ` Randall S. Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0694f2f1-040a-1d8c-cd01-2cf51cdbe426@kdbg.org \
--to=j6t@kdbg.org \
--cc=git-packagers@googlegroups.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peff@peff.net \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).